linux-toradex.git/drivers/scsi/arcmsr, branch v4.16-rc4

scsi: arcmsr: avoid do_gettimeofday

2018-01-23T01:04:02+00:00

The arcmsr uses its own implementation of time_to_tm(), along with
do_gettimeofday() to read the current time. While the algorithm used
here is fine in principle, it suffers from two problems:

- it assigns the seconds portion of the timeval to a 32-bit unsigned
  integer that overflows in 2106 even on 64-bit architectures.

- do_gettimeofday() returns a time_t that overflows in 2038 on all
  32-bit systems.

This changes the time retrieval function to ktime_get_real_seconds(),
which returns a proper 64-bit value, and replaces the open-coded
time_to_tm() algorithm with a call to the safe time64_to_tm().

I checked way all numbers are indexed and found that months are given in
range 0..11 while the days are in range 1..31, same as 'struct tm', but
the year value that the firmware expects starts in 2000 while 'struct
tm' is based on year 1900, so it needs a small adjustment.

[mkp: checkpatch tweaks]

Fixes: b416c099472a ("scsi: arcmsr: Add a function to set date and time to firmware")
Signed-off-by: Arnd Bergmann 
Acked-by: Ching Huang 
Signed-off-by: Martin K. Petersen

scsi: arcmsr: simplify arcmsr_request_device_map routine

2017-12-21T02:11:51+00:00

Simplify arcmsr_request_device_map routine.

Signed-off-by: Ching Huang 
Signed-off-by: Martin K. Petersen

scsi: arcmsr: simplify all arcmsr_hbaX_get_config routine by call a new get_adapter_config function

2017-12-21T02:11:50+00:00

Simplify all arcmsr_hbaX_get_config routine by call a new
get_adapter_config function.

Signed-off-by: Ching Huang 
Signed-off-by: Martin K. Petersen

scsi: arcmsr: simplify arcmsr_hbaE_get_config function

2017-12-21T02:11:50+00:00

Simplify arcmsr_hbaE_get_config function.

Signed-off-by: Ching Huang 
Signed-off-by: Martin K. Petersen

scsi: arcmsr: waiting for iop firmware ready before issue get_config command to iop

2017-12-21T02:11:49+00:00

Waiting for iop firmware ready before issue get_config command to iop
for adapter type A and D.

Signed-off-by: Ching Huang 
Signed-off-by: Martin K. Petersen

scsi: arcmsr: simplify arcmsr_hbaC_get_config function

2017-12-21T02:11:49+00:00

Simplify arcmsr_hbaC_get_config function.

Signed-off-by: Ching Huang 
Signed-off-by: Martin K. Petersen

scsi: arcmsr: remove redundant check for secs < 0

2017-12-12T02:37:08+00:00

The check for secs being less than zero is redundant for two reasons.
Firstly, secs is unsigned so the check is always going to be false.
Secondly, if secs was signed the proceeding calculation of secs is never
going to be negative.  Hence we can remove this redundant check and day
and secs re-adjustment.

Detected by static analysis with smatch:
arcmsr_set_iop_datetime() warn: unsigned 'secs' is never less than zero.

Signed-off-by: Colin Ian King 
Acked-by: Ching Huang 
Signed-off-by: Martin K. Petersen

scsi: arcmsr: Fix command result for CHECK_CONDITION

2017-12-07T00:32:42+00:00

Fix report command result error when CHECK_CONDITION.

Signed-off-by: Ching Huang 
Signed-off-by: Martin K. Petersen

scsi: arcmsr: Update driver version to v1.40.00.04-20171130

2017-12-07T00:32:41+00:00

Update driver version to v1.40.00.04-20171130

Signed-off-by: Ching Huang 
Signed-off-by: Martin K. Petersen

scsi: arcmsr: Add driver module parameter msix_enable

2017-12-07T00:32:41+00:00

Add module parameter msix_enable so user has the option of disabling
MSI-X interrupts if there is a platform problem.

Signed-off-by: Ching Huang 
Signed-off-by: Martin K. Petersen