linux-toradex.git/drivers/scsi/arm, branch v4.10

scsi: ncr5380: Use correct types for DMA routines

2016-11-08T22:29:48+00:00

Apply prototypes to get consistent function signatures for the DMA
functions implemented in the board-specific drivers. To avoid using
macros to alter actual parameters, some of those functions are reworked
slightly.

This is a step toward the goal of passing the board-specific routines
to the core driver using an ops struct (as in a platform driver or
library module).

This also helps fix some inconsistent types: where the core driver uses
ints (cmd->SCp.this_residual and hostdata->dma_len) for keeping track of
transfers, certain board-specific routines used unsigned long.

While we are fixing these function signatures, pass the hostdata pointer
to DMA routines instead of a Scsi_Host pointer, for shorter and faster
code.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Ondrej Zary 
Tested-by: Michael Schmitz 
Acked-by: Russell King 
Signed-off-by: Martin K. Petersen

scsi: ncr5380: Expedite register polling

2016-11-08T22:29:48+00:00

Avoid the call to NCR5380_poll_politely2() when possible. The call is
easily short-circuited on the PIO fast path, using the inline wrapper.
This requires that the NCR5380_read macro be made available before
any #include "NCR5380.h" so a few declarations have to be moved too.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Ondrej Zary 
Tested-by: Michael Schmitz 
Signed-off-by: Martin K. Petersen

scsi: ncr5380: Use correct types for device register accessors

2016-11-08T22:29:48+00:00

For timeout values adopt unsigned long, which is the type of jiffies etc.

For chip register values and bit masks pass u8, which is the return type
of readb, inb etc.

For device register offsets adopt unsigned int, as it is suitable for
adding to base addresses.

Pass the NCR5380_hostdata pointer to the board-specific routines instead
of the Scsi_Host pointer. The board-specific code is concerned with
hardware and not with SCSI protocol or the mid-layer.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Ondrej Zary 
Tested-by: Michael Schmitz 
Acked-by: Russell King 
Signed-off-by: Martin K. Petersen

scsi: ncr5380: Store IO ports and addresses in host private data

2016-11-08T22:29:48+00:00

The various 5380 drivers inconsistently store register pointers
either in the Scsi_Host struct "legacy crap" area or in special,
board-specific members of the NCR5380_hostdata struct. Uniform
use of the latter struct makes for simpler and faster code (see
the following patches) and helps to reduce use of the
NCR5380_implementation_fields macro.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Ondrej Zary 
Tested-by: Michael Schmitz 
Acked-by: Russell King 
Signed-off-by: Martin K. Petersen

scsi: cumana_1: Remove unused cumanascsi_setup() function

2016-11-08T22:29:47+00:00

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Acked-by: Russell King 
Signed-off-by: Martin K. Petersen

scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS

2016-04-15T20:53:14+00:00

Rename SCSI_MAX_SG_SEGMENTS to SG_CHUNK_SIZE, which means the amount
we fit into a single scatterlist chunk.

Rename SCSI_MAX_SG_CHAIN_SEGMENTS to SG_MAX_SEGMENTS.

Will move these 2 generic definitions to scatterlist.h later.

Reviewed-by: Christoph Hellwig 
Acked-by: Bart Van Assche  (for ib_srp changes)
Signed-off-by: Ming Lin 
Acked-by: Tejun Heo 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Martin K. Petersen

ncr5380: Remove DONT_USE_INTR and AUTOPROBE_IRQ macros

2016-04-11T20:57:09+00:00

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Tested-by: Ondrej Zary 
Signed-off-by: Martin K. Petersen

ncr5380: Merge DMA implementation from atari_NCR5380 core driver

2016-04-11T20:57:09+00:00

Adopt the DMA implementation from atari_NCR5380.c. This means that
atari_scsi and sun3_scsi can make use of the NCR5380.c core driver
and the atari_NCR5380.c driver fork can be made redundant.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Tested-by: Ondrej Zary 
Signed-off-by: Martin K. Petersen

ncr5380: Adopt uniform DMA setup convention

2016-04-11T20:57:09+00:00

Standardize the DMA setup hooks so that the DMA implementation in
atari_NCR5380.c can be reconciled with pseudo DMA implementation in
NCR5380.c.

Calls to NCR5380_dma_recv_setup() and NCR5380_dma_send_setup() return
a negative value on failure, zero on PDMA transfer success and a positive
byte count for DMA setup success.

This convention is not entirely new, but is now applied consistently.

Also remove a pointless Status Register access: the *phase assignment is
redundant because after NCR5380_transfer_dma() returns control to
NCR5380_information_transfer(), that routine then returns control
to NCR5380_main(), which means *phase is dead.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Tested-by: Ondrej Zary 
Signed-off-by: Martin K. Petersen

ncr5380: Use DMA hooks for PDMA

2016-04-11T20:57:09+00:00

Those wrapper drivers which use DMA define the REAL_DMA macro and
those which use pseudo DMA define PSEUDO_DMA. These macros need to be
removed for a number of reasons, not least of which is to have drivers
share more code.

Redefine the PDMA send and receive hooks as DMA setup hooks, so that the
DMA code can be shared by all 5380 wrapper drivers. This will help to
reunify the forked core driver.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Tested-by: Ondrej Zary 
Signed-off-by: Martin K. Petersen