linux-toradex.git/drivers/scsi/atari_NCR5380.c, branch v4.1

ncr5380: Harmonize jiffies conversion with msecs_to_jiffies

2015-03-09T14:45:26+00:00

Instances of var * HZ / 1000 are replaced by msecs_to_jiffies(var).
In addition some timing constants that assumed HZ 100 were adjusted
to HZ independent settings based on review comments from Michael Schmitz
 and review of the original drivers in 1.0.31 and
2.2.16.

Signed-off-by: Nicholas Mc Guire 
Acked-by: Michael Schmitz 
Signed-off-by: Finn Thain 
Signed-off-by: James Bottomley

scsi: print single-character strings with seq_putc

2015-02-02T17:57:46+00:00

Using seq_putc to print a single character saves at least a strlen()
call and a memory access, and may also give a small .text reduction.

Signed-off-by: Rasmus Villemoes 
Reviewed-by: Finn Thain 
Signed-off-by: Christoph Hellwig

scsi: replace seq_printf with seq_puts

2015-02-02T17:57:45+00:00

Using seq_printf to print a simple string is a lot more expensive than
it needs to be, since seq_puts exists. Replace seq_printf with
seq_puts when possible.

Signed-off-by: Rasmus Villemoes 
Reviewed-by: Finn Thain 
Signed-off-by: Christoph Hellwig

atari_NCR5380: Fix "transfered" typo

2014-11-20T08:11:21+00:00

Signed-off-by: Finn Thain 
Signed-off-by: Christoph Hellwig

atari_NCR5380: Remove RESET_RUN_DONE macro

2014-11-20T08:11:20+00:00

There's no need to run the cmd->done callback for aborted commands. Remove
the old EH code and the RESET_RUN_DONE macro.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

atari_NCR5380: Move static co-routine variables to host data

2014-11-20T08:11:20+00:00

Unlike NCR5380.c, the atari_NCR5380.c core driver is limited to a single
instance because co-routine state is stored globally.

Fix this by removing the static scsi host pointer. For the co-routine,
obtain this pointer from the work_struct pointer instead. For the interrupt
handler, obtain it from the dev_id argument.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

atari_NCR5380: Move static TagAlloc array to host data

2014-11-20T08:11:19+00:00

The atari_NCR5380.c core driver keeps some per-host data in a static
variable which limits the driver to a single instance. Fix this by moving
TagAlloc to the hostdata struct.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

atari_NCR5380: Introduce FLAG_TAGGED_QUEUING

2014-11-20T08:11:19+00:00

The static variable setup_use_tagged_queuing is declared in mac_scsi.c,
sun3_scsi.c and atari_scsi.c and doesn't belong in the core driver.
None of the other NCR5380 drivers suffer from this layering issue which
makes merging the core drivers more difficult and will likely hinder plans
for future use of platform data to configure the driver.

Replace the static variable with a host flag. This way it can be reported
along with the other flags.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

atari_NCR5380: Merge from NCR5380.c

2014-11-20T08:11:18+00:00

The NCR5380.c core driver has moved on since the atari_NCR5380.c fork.
Some of those changes are also relevant to atari_NCR5380.c so apply them
there as well.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

atari_NCR5380: Merge from sun3_NCR5380.c

2014-11-20T08:11:17+00:00

There is very little difference between the sun3_NCR5380.c core driver
and atari_NCR5380.c. The former is a fork of the latter.

Merge the sun3_NCR5380.c core driver into atari_NCR5380.c so that
sun3_scsi.c can adopt the latter and the former can be deleted.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig