linux-toradex.git/drivers/scsi/atari_scsi.c, branch v5.0

scsi: remove the use_clustering flag

2018-12-19T04:19:21+00:00

The same effects can be achieved by setting the dma_boundary to
PAGE_SIZE - 1 and the max_segment_size to PAGE_SIZE, so shift those
settings into the drivers.  Note that in many cases the setting might
be bogus, but this keeps the status quo.

[mkp: fix myrs and myrb]

Signed-off-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: NCR5380: Move bus reset to host reset

2017-08-25T21:21:11+00:00

The bus reset handler really is a host reset, so move it to
eh_bus_reset_handler.

Signed-off-by: Hannes Reinecke 
Acked-by: Finn Thain 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: atari_scsi: Use m68k_realnum_memory for FastRAM test

2017-06-13T00:48:08+00:00

m68k_num_memory is unsuitable to test for the presence of FastRAM on
CT60 if the kernel is located in FastRAM: in arch/m68k/mm/motorola.c the
ST-RAM chunk is skipped and m68k_num_memory is decremented in this
case. m68k_realnum_memory still contains the actual number of RAM chunks
so use that.

Signed-off-by: Michael Schmitz 
Tested-by: Christian T. Steigies 
Signed-off-by: Martin K. Petersen

scsi: atari_scsi: Reset DMA during bus reset only under ST-DMA lock

2017-02-01T02:39:22+00:00

The atari_scsi driver should not access Falcon DMA chip registers unless
it has acquired exclusive access to that chip. If the driver doesn't
have exclusive access then there's no need for a DMA reset as there are
no scsi commands in progress.

Signed-off-by: Finn Thain 
Tested-by: Ondrej Zary 
Tested-by: Michael Schmitz 
Signed-off-by: Martin K. Petersen

scsi: ncr5380: Resolve various static checker warnings

2017-02-01T02:38:35+00:00

Avoid various warnings from "make C=1" by annotating a couple of
unlock-then-lock sequences, replacing a zero with NULL and correcting
some type casts.

Also avoid a warning from "make W=1" by adding braces.

Signed-off-by: Finn Thain 
Tested-by: Ondrej Zary 
Tested-by: Michael Schmitz 
Signed-off-by: Martin K. Petersen

scsi: ncr5380: Clean up dead code and redundant macro usage

2017-02-01T02:37:44+00:00

Remove dead code inside #if 0 conditionals.

Remove the #ifdef __KERNEL__ test, since NCR5380.h has no definitions
that relate to userspace code.

Remove two redundant macro definitions which were overlooked in
commit e9db3198e08b ("sun3_scsi: Adopt NCR5380.c core driver").

Signed-off-by: Finn Thain 
Tested-by: Ondrej Zary 
Tested-by: Michael Schmitz 
Signed-off-by: Martin K. Petersen

scsi: ncr5380: Use correct types for DMA routines

2016-11-08T22:29:48+00:00

Apply prototypes to get consistent function signatures for the DMA
functions implemented in the board-specific drivers. To avoid using
macros to alter actual parameters, some of those functions are reworked
slightly.

This is a step toward the goal of passing the board-specific routines
to the core driver using an ops struct (as in a platform driver or
library module).

This also helps fix some inconsistent types: where the core driver uses
ints (cmd->SCp.this_residual and hostdata->dma_len) for keeping track of
transfers, certain board-specific routines used unsigned long.

While we are fixing these function signatures, pass the hostdata pointer
to DMA routines instead of a Scsi_Host pointer, for shorter and faster
code.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Ondrej Zary 
Tested-by: Michael Schmitz 
Acked-by: Russell King 
Signed-off-by: Martin K. Petersen

scsi: ncr5380: Expedite register polling

2016-11-08T22:29:48+00:00

Avoid the call to NCR5380_poll_politely2() when possible. The call is
easily short-circuited on the PIO fast path, using the inline wrapper.
This requires that the NCR5380_read macro be made available before
any #include "NCR5380.h" so a few declarations have to be moved too.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Ondrej Zary 
Tested-by: Michael Schmitz 
Signed-off-by: Martin K. Petersen

scsi: ncr5380: Use correct types for device register accessors

2016-11-08T22:29:48+00:00

For timeout values adopt unsigned long, which is the type of jiffies etc.

For chip register values and bit masks pass u8, which is the return type
of readb, inb etc.

For device register offsets adopt unsigned int, as it is suitable for
adding to base addresses.

Pass the NCR5380_hostdata pointer to the board-specific routines instead
of the Scsi_Host pointer. The board-specific code is concerned with
hardware and not with SCSI protocol or the mid-layer.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Ondrej Zary 
Tested-by: Michael Schmitz 
Acked-by: Russell King 
Signed-off-by: Martin K. Petersen

scsi: atari_scsi: Make device register accessors re-entrant

2016-11-08T22:29:47+00:00

This patch fixes an old bug: accesses to device registers from the
interrupt handler (after reselection, DMA completion etc.) could mess
up a device register access elsewhere, if the latter takes place outside
of an irq lock (during selection etc.).

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Martin K. Petersen