linux-toradex.git/drivers/scsi/bfa, branch v3.6

[SCSI] bfa: Fix to set correct return error codes and misc cleanup.

2012-07-20T07:59:05+00:00

- Remove unnecessary if NULL check in function bfa_fcs_vport_free().
- Set correct return error codes in case of memory allocation failure
  in the BSG ELS/CT passthru command handler.

Signed-off-by: Krishna Gudipati 
Signed-off-by: James Bottomley

[SCSI] bfa: squelch lockdep complaint with a spin_lock_init

2012-07-20T07:59:03+00:00

Spotted this while looking at another issue...

INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator.
Pid: 298, comm: udevd Not tainted 3.3.0 #1
Call Trace:
  [] __lock_acquire+0x1363/0x1bb0
  [] ? __slab_alloc+0x4a0/0x4fd
  [] ? native_sched_clock+0x13/0x80
  [] ? sched_clock+0x9/0x10
  [] lock_acquire+0xa1/0x1e0
  [] ? bfa_fcs_lport_aen_post+0x43/0x160 [bfa]
  [] _raw_spin_lock_irqsave+0x65/0xb0
  [] ? bfa_fcs_lport_aen_post+0x43/0x160 [bfa]
  [] bfa_fcs_lport_aen_post+0x43/0x160 [bfa]
  [] bfa_fcs_lport_init+0x97/0x120 [bfa]
  [] bfa_fcs_fabric_sm_uninit+0x1cf/0x250 [bfa]
  [] bfa_fcs_fabric_modinit+0x2a/0xb0 [bfa]
  [] ? bfa_fcs_fabric_attach+0xf2/0x170 [bfa]
  [] bfa_fcs_init+0x2a/0x40 [bfa]
  [] bfad_drv_init+0x107/0x1f0 [bfa]
  [] bfad_pci_probe+0x277/0x450 [bfa]
  [] local_pci_probe+0x5c/0xd0
  [] pci_device_probe+0x111/0x120
  [] driver_probe_device+0x96/0x2f0
  [] __driver_attach+0xab/0xb0
  [] ? driver_probe_device+0x2f0/0x2f0
  [] bus_for_each_dev+0x55/0x90
  [] ? 0xffffffffa037afff
  [] driver_attach+0x1e/0x20
  [] bus_add_driver+0x1b8/0x2b0
  [] ? 0xffffffffa037afff
  [] driver_register+0x77/0x160
  [] ? 0xffffffffa037afff
  [] __pci_register_driver+0x73/0xf0
  [] ? 0xffffffffa037afff
  [] bfad_init+0x83/0x1000 [bfa]
  [] do_one_initcall+0x12a/0x180
  [] sys_init_module+0xc0/0x220
  [] system_call_fastpath+0x16/0x1b

Signed-off-by: Kyle McMartin 
Acked-by: Krishna Gudipati 
Signed-off-by: James Bottomley

[SCSI] bfa: dereferencing freed memory in bfad_im_probe()

2012-07-20T07:58:37+00:00

If bfad_thread_workq(bfad) was not BFA_STATUS_OK then we freed "im"
and then dereferenced it.

I did a little clean up because it seemed nicer to return directly
instead of doing a superfluous goto.  I looked at other functions in
this file and it seems like returning directly is standard.

Signed-off-by: Dan Carpenter 
Acked-by: Krishna Gudipati 
Signed-off-by: James Bottomley

[SCSI] bfa: off by one in bfa_ioc_mbox_isr()

2012-07-20T07:58:37+00:00

If mc == BFI_MC_MAX then we're reading past the end of the
mod->mbhdlr[] array.

Signed-off-by: Dan Carpenter 
Acked-by: Krishna Gudipati 
Signed-off-by: James Bottomley

[SCSI] bfa: Fix to set vport FC host sysfs entries

2012-05-22T10:06:29+00:00

Made changes to set the fc_host sysfs entries supported_speeds,
supported_classes etc., during the vport creation from the
FC transport template.

Signed-off-by: Krishna Gudipati 
Signed-off-by: James Bottomley

[SCSI] bfa: Fix bfa logging for Logical port state change notification

2012-04-25T09:02:03+00:00

Made changes to have the same logging level for Logical port
online and offline events, to display these events in pairs.

Signed-off-by: Krishna Gudipati 
Signed-off-by: James Bottomley

[SCSI] bfa: sysfs model description fix.

2012-04-25T08:59:59+00:00

Make changes to remove unsupported model numbers from the sysfs
model description routine.

Signed-off-by: Krishna Gudipati 
Signed-off-by: James Bottomley

[SCSI] bfa: Fix to defer vport delete handler invocation till firmware logo response.

2012-04-25T08:58:31+00:00

Made changes to avoid queuing the vport delete work to IM driver
work queue in the bfa_fcb_lport_delete() - since at this stage we
are not completely done with using the vport structure as we are
still waiting for the LOGO response from the fw in online state or
just doing some cleanup. Since queuing up the vport delete work at
this stage will result in the FC transport layer to clean up the vport
before we get the response from firmware.
Made changes to queue the port delete work to the IM driver work queue -
from the bfa_fcs_vport_free() function since at this state we are done
with using the vport data structure and the FCS state machine is completely
cleaned up.

Signed-off-by: Krishna Gudipati 
Signed-off-by: James Bottomley

[SCSI] bfa: Update the driver version to 3.0.23.0

2012-03-28T09:02:46+00:00

Signed-off-by: Krishna Gudipati 
Signed-off-by: James Bottomley

[SCSI] bfa: BSG and User interface fixes.

2012-03-28T08:57:58+00:00

Made changes to set the rport maxfrsize param to use a value that is
equal to or less than the Buffer-to-Buffer Receive Data_Field size
specified in the Common Service Parameters.
Increased the diag memtest timeout for the Brocade-1860 adapters.
Made changes to enable valid port speed configuration check for all adapters.
Made changes to increase the max hw segments in a request, in order to
support larger data transfers from user space.

Signed-off-by: Krishna Gudipati 
Signed-off-by: James Bottomley