linux-toradex.git/drivers/scsi/bnx2fc, branch v4.9.28

scsi: bnx2fc: Mark symbols static where possible

2016-09-09T11:11:07+00:00

We get a few warnings when building kernel with W=1:
drivers/scsi/bnx2fc/bnx2fc_els.c:257:6: warning: no previous prototype for 'bnx2fc_srr_compl' [-Wmissing-prototypes]
drivers/scsi/bnx2fc/bnx2fc_els.c:367:6: warning: no previous prototype for 'bnx2fc_rec_compl' [-Wmissing-prototypes]
drivers/scsi/bnx2fc/bnx2fc_fcoe.c:628:5: warning: no previous prototype for 'bnx2fc_percpu_io_thread' [-Wmissing-prototypes]
drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1413:26: warning: no previous prototype for 'bnx2fc_interface_create' [-Wmissing-prototypes]
drivers/scsi/bnx2fc/bnx2fc_hwi.c:997:21: warning: no previous prototype for 'bnx2fc_alloc_work' [-Wmissing-prototypes]
drivers/scsi/bnx2fc/bnx2fc_io.c:1082:5: warning: no previous prototype for 'bnx2fc_abts_cleanup' [-Wmissing-prototypes]
....

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.  so this
patch marks these functions with 'static'.

Signed-off-by: Baoyou Xie 
Acked-by: Arnd Bergmann 
Acked-by: Chad Dupuis 
Signed-off-by: Martin K. Petersen

scsi: bnx2fc: Simplify code

2016-09-09T11:08:30+00:00

Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to
'list_splice_init'.

This has been spotted with the following coccinelle script:
/////
@@
expression y,z;
@@

-   list_splice(y,z);
-   INIT_LIST_HEAD(y);
+   list_splice_init(y,z);

Signed-off-by: Christophe JAILLET 
Acked-by: Chad Dupuis 
Signed-off-by: Martin K. Petersen

fcoe: use enum for fip_mode

2016-07-14T02:05:28+00:00

The FIP mode is independent on the FIP state machine, so use a separate
enum for that instead of overloading it with state machine values.

Signed-off-by: Hannes Reinecke 
Acked-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

fcoe: convert to kworker

2016-07-13T03:16:31+00:00

The driver creates its own per-CPU threads which are updated based on
CPU hotplug events. It is also possible to use kworkers and remove some
of the kthread infrastrucure.

The code checked ->thread to decide if there is an active per-CPU
thread. By using the kworker infrastructure this is no longer
possible (or required). The thread pointer is saved in `kthread' instead
of `thread' so anything trying to use thread is caught by the
compiler. Currently only the bnx2fc driver is using struct fcoe_percpu_s
and the kthread member.

After a CPU went offline, we may still enqueue items on the "offline"
CPU. This isn't much of a problem. The work will be done on a random
CPU. The allocated crc_eof_page page won't be cleaned up. It is probably
expected that the CPU comes up at some point so it should not be a
problem. The crc_eof_page memory is released of course once the module
is removed.

This patch was only compile-tested due to -ENODEV.

Cc: Vasu Dev 
Cc: "James E.J. Bottomley" 
Cc: "Martin K. Petersen" 
Cc: Christoph Hellwig 
Cc: fcoe-devel@open-fcoe.org
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior 
Tested-by: Johannes Thumshirn 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

bnx2fc: replace printk() with BNX2FC_IO_DBG()

2016-07-13T03:16:31+00:00

The "fcp_rsp_code = %d" message isn't an error, it's meant to be
informative only.  This patch prevents a flood of such messages in some
situations.

Signed-off-by: Maurizio Lombardi 
Tested-by: Laurence Oberman 
Reviewed-by: Johannes Thumshirn 
Acked-by: Chad Dupuis 
Signed-off-by: Martin K. Petersen

bnx2fc: Update version number to 2.10.3.

2016-04-15T20:53:11+00:00

Signed-off-by: Chad Dupuis 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

bnx2fc: Check sc_cmd device and host pointer before returning the command to the mid-layer.

2016-04-15T20:53:10+00:00

When we are in connection recovery and the internal command timer on a
request pops, either the scsi_cmnd->device or scsi_cmnd->device->host
back pointers may be NULL as the device that the command that the
request was submitted on may have been subsequently reaped due to the
connection recovery. This can cause one or both of the pointers above to
be NULL and cause a system crash if we try to return the command to the
midlayer.

Instead, double check the pointers before the return to the midlayer so
as to prevent the crash and let the upper layers finish the session
recovery and rediscover the device.

Signed-off-by: Chad Dupuis 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

bnx2fc: Print netdev device name when FCoE is successfully initialized.

2016-04-15T20:53:10+00:00

Signed-off-by: Chad Dupuis 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

bnx2fc: Print when we send a fip keep alive.

2016-04-15T20:53:09+00:00

Signed-off-by: Chad Dupuis 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

bnx2fc: Add driver tunables.

2016-04-15T20:53:08+00:00

Per customer request, add the following driver tunables:

o devloss_tmo
o max_luns
o queue_depth
o tm_timeout

tm_timeout is set per scsi_host in /sys/class/scsi_host/hostX/tm_timeout.

Signed-off-by: Joe Carnuccio 
Signed-off-by: Chad Dupuis 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen