linux-toradex.git/drivers/scsi/ch.c, branch v2.6.27.12

[SCSI] ch: fix ch_remove oops

2008-07-26T19:17:47+00:00

The following commit causes ch_remove oops:

commit 24b42566c3fcbb5a9011d1446783d0f5844ccd45
Author: Greg Kroah-Hartman 
Date:   Fri May 16 17:55:12 2008 -0700

    SCSI: fix race in device_create

    There is a race from when a device is created with device_create() and
    then the drvdata is set with a call to dev_set_drvdata() in which a
    sysfs file could be open, yet the drvdata will be NULL, causing all
    sorts of bad things to happen.

    This patch fixes the problem by using the new function,
    device_create_drvdata().  It fixes the problem in all of the scsi
    drivers that need it.

    Cc: Kay Sievers 
    Cc: Doug Gilbert 
    Cc: James E.J. Bottomley 
    Signed-off-by: Greg Kroah-Hartman 

The problem is ch_probe stores ch's private data at a wrong place.

We need to store it at scsi_device->sdev_gendev but the above patch
stores it at device struct that device_create_drvdata returns. So we
hit an oops when ch_remove accesses
scsi_device->sdev_gendev->driver_data, which is NULL.

Actually, there wasn't a race because ch doesn't create sysfs files
with device struct that device_create returns. This patch puts back
dev_set_drvdata() to set ch's private data properly.

Signed-off-by: FUJITA Tomonori 
Signed-off-by: James Bottomley

Merge commit 'v2.6.26' into bkl-removal

2008-07-14T21:29:34+00:00

changer: BKL pushdown

2008-06-20T20:05:52+00:00

Add lock_kernel() calls to ch_open(), though the existing locking looks
adequate.

Signed-off-by: Jonathan Corbet

SCSI: fix race in device_create

2008-05-20T20:31:56+00:00

There is a race from when a device is created with device_create() and
then the drvdata is set with a call to dev_set_drvdata() in which a
sysfs file could be open, yet the drvdata will be NULL, causing all
sorts of bad things to happen.

This patch fixes the problem by using the new function,
device_create_drvdata().  It fixes the problem in all of the scsi
drivers that need it.

Cc: Kay Sievers 
Cc: Doug Gilbert 
Cc: James E.J. Bottomley 
Signed-off-by: Greg Kroah-Hartman

SCSI: convert struct class_device to struct device

2008-04-20T02:10:33+00:00

It's big, but there doesn't seem to be a way to split it up smaller...

Signed-off-by: Tony Jones 
Signed-off-by: Kay Sievers 
Cc: Roland Dreier 
Cc: Sean Hefty 
Cc: Hal Rosenstock 
Cc: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

[SCSI] ch: fix sparse shadowed variable warnings

2008-04-07T17:19:08+00:00

Replace the global err array with ch_err.
drivers/scsi/ch.c:271:6: warning: symbol 'err' shadows an earlier one
drivers/scsi/ch.c:116:3: originally declared here

Replace the temporary cmd buffer with ch_err to avoid shadowing the cmd
function parameter.
drivers/scsi/ch.c:724:11: warning: symbol 'cmd' shadows an earlier one
drivers/scsi/ch.c:596:20: originally declared here

Signed-off-by: Harvey Harrison 
Signed-off-by: James Bottomley

[SCSI] ch: remove forward declarations

2008-01-25T15:22:12+00:00

This moves ch_template and changer_fops structs to the end of file and
removes forward declarations.

This also removes some trailing whitespace.

Signed-off-by: FUJITA Tomonori 
Signed-off-by: James Bottomley

[SCSI] ch: fix device minor number management bug

2008-01-25T15:21:55+00:00

ch_probe uses the total number of ch devices as minor.

ch_probe:
	ch->minor = ch_devcount;
...
	ch_devcount++;

Then ch_remove decreases ch_devcount:

ch_remove:
	ch_devcount--;

If you have two ch devices, sch0 and sch1, and remove sch0,
ch_devcount is 1. Then if you add another ch device, ch_probe tries to
create sch1. So you get a warning and fail to create sch1:

Jan 24 16:01:05 nice kernel: sysfs: duplicate filename 'sch1' can not be created
Jan 24 16:01:05 nice kernel: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()
Jan 24 16:01:05 nice kernel: Pid: 2571, comm: iscsid Not tainted 2.6.24-rc7-ga3d2c2e8-dirty #1
Jan 24 16:01:05 nice kernel:
Jan 24 16:01:05 nice kernel: Call Trace:
Jan 24 16:01:05 nice kernel:  [] sysfs_add_one+0x54/0xbd
Jan 24 16:01:05 nice kernel:  [] create_dir+0x4f/0x87
Jan 24 16:01:05 nice kernel:  [] sysfs_create_dir+0x35/0x4a
Jan 24 16:01:05 nice kernel:  [] kobject_get+0x12/0x17
Jan 24 16:01:05 nice kernel:  [] kobject_add+0xf3/0x1a6
Jan 24 16:01:05 nice kernel:  [] class_device_add+0xaa/0x39d
Jan 24 16:01:05 nice kernel:  [] class_device_create+0xcb/0xfa
Jan 24 16:01:05 nice kernel:  [] printk+0x4e/0x56
Jan 24 16:01:05 nice kernel:  [] sysfs_ilookup_test+0x0/0xf
Jan 24 16:01:05 nice kernel:  [] :ch:ch_probe+0xbe/0x61a

(snip)

This patch converts ch to use a standard minor number management way,
idr like sg and bsg.

Signed-off-by: FUJITA Tomonori 
Signed-off-by: James Bottomley

[SCSI] ch: handle class_device_create failure properly

2008-01-23T19:44:47+00:00

When class_device_create fails, ch_probe needs to fail too.

Signed-off-by: FUJITA Tomonori 
Signed-off-by: James Bottomley

[SCSI] ch: Convert to use unlocked_ioctl

2008-01-23T17:29:28+00:00

As of now, compat_ioctl already runs without the BKL, whereas ioctl runs
with the BKL. This patch first converts changer_fops to use a .unlocked_ioctl
member. It applies the same locking rationale than ch_ioctl_compat() uses
to ch_ioctl().

Signed-off-by: Mathieu Segaud 
Reviewed-by: Matthew Wilcox 
Signed-off-by: James Bottomley