linux-toradex.git/drivers/scsi/esas2r, branch v3.13.5 Linux kernel for Apalis and Colibri modules [SCSI] esas2r: Cleanup snprinf formatting of firmware version 2013-10-25T08:58:59+00:00 Bradley Grove bgrove@attotech.com 2013-10-01T18:26:04+00:00 0f3c7b99f33f7a9c743a752bba2414615c48e270 Signed-off-by: Bradley Grove <bgrove@attotech.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> 
Signed-off-by: Bradley Grove <bgrove@attotech.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
[SCSI] esas2r: Remove superfluous mask of pcie_cap_reg 2013-10-25T08:58:59+00:00 Bradley Grove bgrove@attotech.com 2013-10-01T18:26:03+00:00 b1cf7a2bc7c372c856cdf542c41d7fe527e4b5d6 Signed-off-by: Bradley Grove <bgrove@attotech.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> 
Signed-off-by: Bradley Grove <bgrove@attotech.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
[SCSI] esas2r: Fixes for big-endian platforms 2013-10-25T08:58:59+00:00 Bradley Grove bgrove@attotech.com 2013-10-01T18:26:02+00:00 8e65e2f07c1fdbd952570591bf78316aeed1c74a In esas2r_format_init_msg(), sgl_page_size and epoch_time params are converted to little endian and the firmware version read from the hba is converted to cpu endianess. In esas2r_rq_init_request, correct and simplify the construction of the SCSI handle. These fixes are the result of testing on a PPC64 machine. Signed-off-by: Bradley Grove <bgrove@attotech.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> 
In esas2r_format_init_msg(), sgl_page_size and epoch_time params
are converted to little endian and the firmware version read from
the hba is converted to cpu endianess.

In esas2r_rq_init_request, correct and simplify the construction
of the SCSI handle.

These fixes are the result of testing on a PPC64 machine.

Signed-off-by: Bradley Grove <bgrove@attotech.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
[SCSI] esas2r: Directly call kernel functions for atomic bit operations 2013-10-25T08:58:59+00:00 Bradley Grove bgrove@attotech.com 2013-10-01T18:26:01+00:00 9588d24e36003b53f76e43b4fadfc5b35207be04 Previously the code embedded the kernel's test_bit/clear_bit functions in wrappers that accepted u32 parameters. The wrapper cast these parameters to longs before passing them to the kernel's bit functions. This did not work properly on platforms with 64-bit longs. Signed-off-by: Bradley Grove <bgrove@attotech.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> 
Previously the code embedded the kernel's test_bit/clear_bit
functions in wrappers that accepted u32 parameters.  The
wrapper cast these parameters to longs before passing them
to the kernel's bit functions.   This did not work properly
on platforms with 64-bit longs.

Signed-off-by: Bradley Grove <bgrove@attotech.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
[SCSI] esas2r: Remove null test for stack allocated fw_coredump_buffer 2013-09-06T18:22:35+00:00 Bradley Grove bgrove@attotech.com 2013-09-05T17:08:00+00:00 4079bc8b7d22c6ca24da7825c27c4b640ae61dc7 Reported-by: Dave Jones <davej@redhat.com> Signed-off-by: Bradley Grove <bgrove@attotech.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> 
Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Bradley Grove <bgrove@attotech.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
[SCSI] esas2r: coccinelle - Replace memcpy with struct assignment 2013-09-06T18:13:54+00:00 Bradley Grove bgrove@attotech.com 2013-08-29T19:55:44+00:00 ef11851b34b3a6b91b7d09b4711a10a0ad39c316 Reported-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Bradley Grove <bgrove@attotech.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> 
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Bradley Grove <bgrove@attotech.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
[SCSI] esas2r: smatch - Remove test for impossible condition (uint8 > 255) 2013-09-06T18:13:53+00:00 Bradley Grove bgrove@attotech.com 2013-08-29T19:55:43+00:00 8d3ac484089aee9b1bd700af59017d685ae4803b Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Bradley Grove <bgrove@attotech.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> 
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bradley Grove <bgrove@attotech.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
[SCSI] esas2r: smatch - Fix overrun due to sprintf appending NULL 2013-09-06T18:13:52+00:00 Bradley Grove bgrove@attotech.com 2013-08-29T19:55:42+00:00 eaf74a06f13aa0e4e7e2024cb6db2ccedd3d32e3 Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Bradley Grove <bgrove@attotech.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> 
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bradley Grove <bgrove@attotech.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
[SCSI] esas2r: smatch - Fix dereference that occurs prior to check 2013-09-06T18:13:25+00:00 Bradley Grove bgrove@attotech.com 2013-08-29T19:55:40+00:00 64d29bd83ef36911001afc3d1f21404106739ce1 Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Bradley Grove <bgrove@attotech.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> 
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bradley Grove <bgrove@attotech.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
[SCSI] esas2r: smatch - Use biwise rather than logical AND for checking if any bit set 2013-09-06T17:37:19+00:00 Bradley Grove bgrove@attotech.com 2013-08-29T19:55:39+00:00 c88d2dddb0b84aaa1de2985627c081c9742667ae Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Bradley Grove <bgrove@attotech.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> 
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bradley Grove <bgrove@attotech.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>