linux-toradex.git/drivers/scsi/esp_scsi.h, branch v7.2-rc5

scsi: esp: Fix variable typo

2025-01-02T18:42:35+00:00

Renamed ESP_CONGIG4_TEST to ESP_CONFIG4_TEST

Signed-off-by: Siddharth Menon 
Link: https://lore.kernel.org/r/20241210040202.11112-1-simeddon@gmail.com
Signed-off-by: Martin K. Petersen

scsi: esp_scsi: Declare SCSI host template const

2023-03-24T23:19:22+00:00

Make it explicit that the SCSI host template is not modified.

Signed-off-by: Bart Van Assche 
Link: https://lore.kernel.org/r/20230322195515.1267197-35-bvanassche@acm.org
Signed-off-by: Martin K. Petersen

scsi: esp_scsi: Stop using the SCSI pointer

2022-02-23T02:11:04+00:00

Set .cmd_size in the SCSI host template instead of using the SCSI pointer
from struct scsi_cmnd. This patch prepares for removal of the SCSI pointer
from struct scsi_cmnd.

Link: https://lore.kernel.org/r/20220218195117.25689-20-bvanassche@acm.org
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Himanshu Madhani 
Signed-off-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: esp_scsi: Add support for FSC chip

2019-12-20T03:08:51+00:00

The FSC (NCR53CF9x-2 / SYM53CF9x-2) has a different family code than QLogic
or Emulex parts. This caused it to be detected as a FAS100A.

Unforunately, this meant the configuration of the CONFIG3 register was
incorrect. This causes data transfer issues with FAST-SCSI targets.

The FSC also has the CONFIG4 register. It can be used to enable a feature
called Active Negation which should always be enabled according to the data
manual.

Link: https://lore.kernel.org/r/20191119202021.28720-3-jongk@linux-m68k.org
Reviewed-by: Finn Thain 
Signed-off-by: Kars de Jong 
Signed-off-by: Martin K. Petersen

scsi: esp_scsi: Correct ordering of PCSCSI definition in esp_rev enum

2019-12-20T03:08:51+00:00

The order of the definitions in the esp_rev enum is important. The values
are used in comparisons for chip features.

Add a comment to the enum explaining this.

Also, the actual values for the enum fields are irrelevant, so remove the
explicit values (suggested by Geert Uytterhoeven). This makes adding a new
field in the middle of the enum easier.

Finally, move the PCSCSI definition to the right place in the enum. In its
previous location, at the end of the enum, the wrong values are written to
the CONFIG3 register when used with FAST-SCSI targets.

Link: https://lore.kernel.org/r/20191119202021.28720-2-jongk@linux-m68k.org
Signed-off-by: Kars de Jong 
Signed-off-by: Martin K. Petersen

scsi: esp: use sg helper to iterate over scatterlist

2019-06-20T19:21:33+00:00

Unlike the legacy I/O path, scsi-mq preallocates a large array to hold
the scatterlist for each request. This static allocation can consume
substantial amounts of memory on modern controllers which support a
large number of concurrently outstanding requests.

To facilitate a switch to a smaller static allocation combined with a
dynamic allocation for requests that need it, we need to make sure all
SCSI drivers handle chained scatterlists correctly.

Convert remaining drivers that directly dereference the scatterlist
array to using the iterator functions.

[mkp: clarified commit message]

Cc: Christoph Hellwig 
Cc: Bart Van Assche 
Cc: Ewan D. Milne 
Cc: Hannes Reinecke 
Cc: Finn Thain 
Cc: Guenter Roeck 
Reported-by: Guenter Roeck 
Tested-by: Guenter Roeck 
Reviewed-by: Finn Thain 
Signed-off-by: Ming Lei 
Signed-off-by: Martin K. Petersen

scsi: esp_scsi: De-duplicate PIO routines

2018-10-18T01:38:20+00:00

As a temporary measure, the code to implement PIO transfers was
duplicated in zorro_esp and mac_esp. Now that it has stabilized move the
common code into the core driver but don't build it unless needed.

This replaces the inline assembler with more portable writesb() calls.
Optimizing the m68k writesb() implementation is a separate patch.

[mkp: applied by hand]

Signed-off-by: Finn Thain 
Tested-by: Stan Johnson 
Tested-by: Michael Schmitz 
Signed-off-by: Martin K. Petersen

scsi: esp_scsi: Eliminate ESP_FLAG_DOING_SLOWCMD

2018-10-18T01:37:31+00:00

The concept of a 'slow command' as it appears in esp_scsi is confusing
because it could refer to an ESP command or a SCSI command. It turns out
that it refers to a particular ESP select command which the driver also
tracks as 'ESP_SELECT_MSGOUT'. For readability, it is better to use the
terminology from the datasheets.

The global ESP_FLAG_DOING_SLOWCMD flag is redundant anyway, as it can be
inferred from esp->select_state. Remove the ESP_FLAG_DOING_SLOWCMD cruft
and just use a boolean local variable.

Tested-by: Stan Johnson 
Signed-off-by: Finn Thain 
Tested-by: Michael Schmitz 
Signed-off-by: Martin K. Petersen

scsi: esp_scsi: Track residual for PIO transfers

2018-10-18T01:34:20+00:00

If a target disconnects during a PIO data transfer the command may fail
when the target reconnects:

scsi host1: DMA length is zero!
scsi host1: cur adr[04380000] len[00000000]

The scsi bus is then reset. This happens because the residual reached
zero before the transfer was completed.

The usual residual calculation relies on the Transfer Count registers.
That works for DMA transfers but not for PIO transfers. Fix the problem
by storing the PIO transfer residual and using that to correctly
calculate bytes_sent.

Fixes: 6fe07aaffbf0 ("[SCSI] m68k: new mac_esp scsi driver")
Tested-by: Stan Johnson 
Signed-off-by: Finn Thain 
Tested-by: Michael Schmitz 
Signed-off-by: Martin K. Petersen

scsi: esp_scsi: remove union in esp_cmd_priv

2018-10-16T03:00:39+00:00

The dma_addr_t member is unused ever since we switched the SCSI
layer to send down single-segement command using a scatterlist
as well many years ago.

Signed-off-by: Christoph Hellwig 
Tested-by: Finn Thain 
Signed-off-by: Martin K. Petersen