linux-toradex.git/drivers/scsi/fnic, branch v4.1.12

fnic: Use the local variable instead of I/O flag to acquire io_req_lock in fnic_queuecommand() to avoid deadloack

2015-09-13T16:07:51+00:00

commit db196935d9562abec4510f48d887bc1f1e054fcf upstream.

We added changes in fnic driver patch 1.6.0.16 to acquire
io_req_lock in fnic_queuecommand() before issuing I/O so that io completion
is serialized. But when releasing the lock we check for the I/O flag and
this could be modified if IO abort occurs before I/O completion. In this case
we wont release the lock and causes deadlock in some scenerios. Using the
local variable to check the IO lock status will resolve the problem.

Fixes: 41df7b02db82cf6c14f094757bac3830d10a827f
Signed-off-by: Hiral Shah 
Signed-off-by: Sesidhar Baddela 
Signed-off-by: Anil Chintalapati 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

fnic: IOMMU Fault occurs when IO and abort IO is out of order

2014-12-30T12:31:45+00:00

When I/O is aborted by mid-layer, fnic FW will complete the I/O before
completing the abort task. In some cases abort request is completed before
the I/O, which could lead to inconsistent driver and firmware states.
In this case firmware reset would clear the inconsistent state.

Signed-off-by: Anil Chintalapati 
Signed-off-by: Sesidhar Baddela 
Signed-off-by: Hiral Shah 
Signed-off-by: Christoph Hellwig

scsi: remove ->change_queue_type method

2014-12-04T08:55:45+00:00

Since we got rid of ordered tag support in 2010 the prime use case of
switching on and off ordered tags has been obsolete.  The other function
of enabling/disabling tagging entirely has only been correctly implemented
by the 53c700 driver and isn't generally useful.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Bart Van Assche 
Reviewed-by: Martin K. Petersen

scsi: drop reason argument from ->change_queue_depth

2014-11-24T13:45:27+00:00

Drop the now unused reason argument from the ->change_queue_depth method.
Also add a return value to scsi_adjust_queue_depth, and rename it to
scsi_change_queue_depth now that it can be used as the default
->change_queue_depth implementation.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Mike Christie 
Reviewed-by: Hannes Reinecke

scsi: avoid ->change_queue_depth indirection for queue full tracking

2014-11-24T13:45:12+00:00

All drivers use the implementation for ramping the queue up and down, so
instead of overloading the change_queue_depth method call the
implementation diretly if the driver opts into it by setting the
track_queue_depth flag in the host template.

Note that a few drivers validated the new queue depth in their
change_queue_depth method, but as we never go over the queue depth
set during slave_configure or the sysfs file this isn't nessecary
and can safely be removed.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Mike Christie 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Venkatesh Srinivas

Fnic: Fnic Driver crashed with NULL pointer reference

2014-11-20T08:11:00+00:00

When issuing I/O request, if the I/O completes before returning from
fnic_queuecommand(), we may be referencing scsi_cmnd structure that may
be freed by interrupt handler. Acquring IO lock would synchronize
fnic_queuecommand and interrupt handler.

- Increment fnic version from 1.6.0.15 to 1.6.0.16

Signed-off-by: Hiral Shah 
Signed-off-by: Sesidhar Baddela 
Signed-off-by: Anil Chintalapati 
Signed-off-by: Christoph Hellwig

Fnic: For Standalone C series, "sending VLAN request" message seen even if the link is down

2014-11-20T08:10:51+00:00

When physical link between standalone C series and switch is down,
the fip timer is not turned off and timer expiration will keep sending
vlan request.

It can be fixed by stopping the fip_timer and
it will be restarted automatically when Link is up.

- Increment fnic version from 1.6.0.14 to 1.6.0.15

Signed-off-by: Hiral Shah 
Signed-off-by: Sesidhar Baddela 
Signed-off-by: Anil Chintalapati 
Signed-off-by: Christoph Hellwig

Fnic: Improper resue of exchange Ids

2014-11-20T08:10:39+00:00

IOs belonging to an rport are aborted with Internal terminate option
when rport goes offline. Any new IO issued to the rport during this
time can reuse the terminated exchange which will cause inconsistent
state of the exchange between local port and remote port.

fc_rport_priv is set to RPORT_ST_DELETE before exchanges are aborted by
libfc. Not issuing amy more I/O requests when RPORT_ST_DELETE is set,
will avoid inconsistent state of the exchange between local port and
remote port.

- Increment fnic version from 1.6.0.13 to 1.6.0.14

Signed-off-by: Hiral Shah 
Signed-off-by: Sesidhar Baddela 
Signed-off-by: Anil Chintalapati 
Signed-off-by: Christoph Hellwig

Fnic: Memcopy only mimumum of data or trace buffer

2014-11-20T08:10:23+00:00

In case of receive path, we do not have eth header or fcoe header available
when we take a trace so we fill the fc trace buffer with 0xff for both
values. We copy only mimimum of received data or trace buffer size -
fc header - eth and fcoe header

- Increment fnic version from 1.6.0.12 to 1.6.0.13

Signed-off-by: Hiral Shah 
Signed-off-by: Sesidhar Baddela 
Signed-off-by: Anil Chintalapati 
Signed-off-by: Christoph Hellwig

Fnic: Not probing all the vNICS via fnic_probe on boot

2014-11-20T08:10:08+00:00

In fnic_dev_wait, Wait for finish to complete at least three times in two
seconds while loop before returning -ETIMEDOUT as sometime
schedule_timeout_uninterruptible takes more than two seconds to wake up.

- Increment fnic version from 1.6.0.11 to 1.6.0.12

Signed-off-by: Hiral Shah 
Signed-off-by: Sesidhar Baddela 
Signed-off-by: Anil Chintalapati 
Signed-off-by: Christoph Hellwig