linux-toradex.git/drivers/scsi/fnic, branch v5.10-rc6

scsi: fnic: Simplify the return expression of vnic_wq_copy_alloc()

2020-10-08T03:50:03+00:00

Simplify the return expression.

Link: https://lore.kernel.org/r/20200921082452.2592085-1-liushixin2@huawei.com
Signed-off-by: Liu Shixin 
Signed-off-by: Martin K. Petersen

scsi: fnic: Fix inconsistent format argument type in fnic_debugfs.c

2020-10-03T01:16:21+00:00

Fix the following warnings:

[drivers/scsi/fnic/fnic_debugfs.c:123]: (warning) %u in format string (no. 1)
	requires 'unsigned int' but the argument type is 'int'.
[drivers/scsi/fnic/fnic_debugfs.c:125]: (warning) %u in format string (no. 1)
	requires 'unsigned int' but the argument type is 'int'.
[drivers/scsi/fnic/fnic_debugfs.c:127]: (warning) %u in format string (no. 1)
	requires 'unsigned int' but the argument type is 'int'.

Link: https://lore.kernel.org/r/20200930021919.2832860-2-yebin10@huawei.com
Reported-by: Hulk Robot 
Acked-by: Karan Tilak Kumar 
Signed-off-by: Ye Bin 
Signed-off-by: Martin K. Petersen

scsi: fnic: Do not call 'scsi_done()' for unhandled commands

2020-10-03T01:09:26+00:00

The fnic drivers assigns an ioreq structure to each command and severs this
assignment once scsi_done() has been called and the command has been
completed.

When traversing commands to terminate outstanding I/O we should not call
scsi_done() on commands which do not have a corresponding ioreq structure;
these commands have either never entered the driver or have already been
completed.

[mkp: fixed unused label warning]

Link: https://lore.kernel.org/r/20200515112647.49260-1-hare@suse.de
Reported-by: kbuild test robot 
Reviewed-by: Laurence Oberman 
Acked-by: Satish Kharat 
Acked-by: Karan Tilak Kumar 
Signed-off-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: fnic: Remove unneeded semicolon

2020-09-15T21:35:00+00:00

This addresses the following coccinelle warning:

drivers/scsi/fnic/fnic_main.c:446:2-3: Unneeded semicolon

Link: https://lore.kernel.org/r/20200911091057.2938685-1-yanaijie@huawei.com
Reported-by: Hulk Robot 
Signed-off-by: Jason Yan 
Signed-off-by: Martin K. Petersen

scsi: fnic: Remove set but not used 'eth_hdrs_stripped'

2020-09-03T02:49:07+00:00

This addresses the following gcc warning with "make W=1":

drivers/scsi/fnic/fnic_fcs.c: In function ‘fnic_rq_cmpl_frame_recv’:
drivers/scsi/fnic/fnic_fcs.c:840:15: warning: variable
‘eth_hdrs_stripped’ set but not used [-Wunused-but-set-variable]
  840 |  unsigned int eth_hdrs_stripped;
      |               ^~~~~~~~~~~~~~~~~

Link: https://lore.kernel.org/r/20200831081126.3251288-5-yanaijie@huawei.com
Reported-by: Hulk Robot 
Signed-off-by: Jason Yan 
Signed-off-by: Martin K. Petersen

scsi: fnic: Remove set but not used 'fr_len'

2020-09-03T02:49:07+00:00

This addresses the following gcc warning with "make W=1":

drivers/scsi/fnic/fnic_fcs.c: In function ‘fnic_fcoe_send_vlan_req’:
drivers/scsi/fnic/fnic_fcs.c:379:6: warning: variable ‘fr_len’ set but
not used [-Wunused-but-set-variable]
  379 |  int fr_len;
      |      ^~~~~~

Link: https://lore.kernel.org/r/20200831081126.3251288-4-yanaijie@huawei.com
Reported-by: Hulk Robot 
Signed-off-by: Jason Yan 
Signed-off-by: Martin K. Petersen

scsi: fnic: Remove set but not used variable in is_fnic_fip_flogi_reject()

2020-09-03T02:49:07+00:00

This addresses the following gcc warning with "make W=1":

drivers/scsi/fnic/fnic_fcs.c: In function ‘is_fnic_fip_flogi_reject’:
drivers/scsi/fnic/fnic_fcs.c:317:9: warning: variable ‘els_len’ set but
not used [-Wunused-but-set-variable]
  317 |  size_t els_len = 0;
      |         ^~~~~~~
drivers/scsi/fnic/fnic_fcs.c:312:21: warning: variable ‘els_dtype’ set
but not used [-Wunused-but-set-variable]
  312 |  enum fip_desc_type els_dtype = 0;
      |                     ^~~~~~~~~

Link: https://lore.kernel.org/r/20200831081126.3251288-3-yanaijie@huawei.com
Reported-by: Hulk Robot 
Signed-off-by: Jason Yan 
Signed-off-by: Martin K. Petersen

scsi: fnic: Remove set but not used 'old_vlan'

2020-09-03T02:49:07+00:00

This addresses the following gcc warning with "make W=1":

drivers/scsi/fnic/fnic_main.c: In function ‘fnic_set_vlan’:
drivers/scsi/fnic/fnic_main.c:555:6: warning: variable ‘old_vlan’ set
but not used [-Wunused-but-set-variable]
  555 |  u16 old_vlan;
      |      ^~~~~~~~

Link: https://lore.kernel.org/r/20200831081126.3251288-2-yanaijie@huawei.com
Reported-by: Hulk Robot 
Signed-off-by: Jason Yan 
Signed-off-by: Martin K. Petersen

scsi: fnic: Use eth_broadcast_addr() to assign broadcast address

2020-07-25T02:09:56+00:00

Use eth_broadcast_addr() to assign broadcast address insetad of memset().

Link: https://lore.kernel.org/r/1595233498-13628-1-git-send-email-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin 
Signed-off-by: Martin K. Petersen

scsi: fnic: Use true, false for fnic->internal_reset_inprogress

2020-05-08T02:03:07+00:00

Fix the following coccicheck warning:

drivers/scsi/fnic/fnic_scsi.c:2627:5-36: WARNING: Comparison of 0/1 to
bool variable

Link: https://lore.kernel.org/r/20200430121718.14970-1-yanaijie@huawei.com
Signed-off-by: Jason Yan 
Signed-off-by: Martin K. Petersen