linux-toradex.git/drivers/scsi/hisi_sas, branch v4.9.57

scsi: hisi_sas: send three identify before phy up

2016-09-14T16:54:18+00:00

When the v2 hw is attached with many disks through an expander, there
may be OOB reset resulting in a PHY going down after the speed is
negotiated (very low probability).

This issue is resolved by modifying the link control registers to send
three identify frames before the PHY is ready (according to 6.10.3.3.2
in SAS 3.0 spec) and close ready when the PHY is down.

Signed-off-by: NengLong Zhao 
Signed-off-by: John Garry 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: hisi_sas: add missing SATA pending device type to v2 hw

2016-09-14T16:54:18+00:00

In setup_itct_v2_hw(), SATA device type SAS_SATA_PENDING is missing, so
add it.

Note: The HiSi SAS controller does not support SATA PM, so do not handle
SAS_SATA_PM_PORT or SAS_SATA_PM.

Signed-off-by: John Garry 
Signed-off-by: Xiang Chen 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: hisi_sas: remove init_id_frame_v1_hw()

2016-09-14T16:54:18+00:00

Function config_id_frame_v1_hw() is called twice for each PHY during
initialisation, which is unneeded.

So remove init_id_frame_v1_hw(), which only calls
config_id_frame_v1_hw().

We will keep the call to config_id_frame_v1_hw() in start_phy_v1_hw()
since it will be used for PHY reset functions.

Signed-off-by: John Garry 
Signed-off-by: Xiang Chen 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: hisi_sas: remove init_id_frame_v2_hw()

2016-09-14T16:54:18+00:00

Function config_id_frame_v2_hw() is called twice for each PHY during
initialisation, which is unneeded.

So remove init_id_frame_v2_hw(), which only calls
config_id_frame_v2_hw().

We will keep the call to config_id_frame_v2_hw() in start_phy_v2_hw()
since it will be used for PHY reset functions.

Signed-off-by: John Garry 
Signed-off-by: Xiang Chen 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: hisi_sas: fix HBA SAS addr endianness for v1 hw

2016-09-14T16:54:18+00:00

The endianness for the SAS address in the TX_ID_DWORD registers is set
incorrectly.  We see errors like this in the boot log for v2 hw (which
would have the same issue as v1 hw):

[    7.583284] sas: target proto 0x0 at 50000d1108e7923f:0x1f not handled

This is due to the host SAS addr not matching the PHY SAS addr in the
expander host-attached phy discovery responses.

To fix, we byte swap the SAS addr from BE to LE (which is the endianness
of the SAS controller).

Signed-off-by: John Garry 
Signed-off-by: Xiang Chen 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: hisi_sas: fix HBA SAS addr endianness for v2 hw

2016-09-14T16:54:18+00:00

The endianness for the SAS address in the TX_ID_DWORD registers is set
incorrectly.  We see errors like this in the boot log:

[    7.583284] sas: target proto 0x0 at 50000d1108e7923f:0x1f not handled

This is due to the host SAS addr not matching the PHY SAS addr in the
expander host-attached phy discovery responses.

To fix, we byte swap the SAS addr from BE to LE (which is the endianness
of the SAS controller).

Signed-off-by: John Garry 
Signed-off-by: Xiang Chen 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: hisi_sas: set dma mask before allocate DMA memory

2016-09-14T16:54:18+00:00

The device DMA mask was being set after the bulk of the DMA allocations
in the driver init, so potentially DMA allocates fail.  To resolve,
relocate before allocating the DMA memory when initialising the driver.

Signed-off-by: Xiang Chen 
Signed-off-by: John Garry 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: hisi_sas: fix a potential warning for sata disk ejection

2016-09-14T16:54:17+00:00

If hisi_sas_task_prep() fails for a SATA device due to PHY down, we
return a failure to libata and also call task_done(), which will cause
ata_qc_complete() to be called twice: - first call from
hisi_sas_task_prep(), which will clear flag ATA_QCFLAG_ACTIVE -
ata_qc_complete() called from libata The warning call trace is as
follows:

[  117.070206] [] __ata_qc_complete+0xf4/0x11c
[  117.070208] [] ata_qc_complete+0x180/0x200
[  117.070210] [] ata_qc_issue+0x110/0x354
[  117.070212] [] ata_exec_internal_sg+0x240/0x4d0
[  117.070214] [] ata_exec_internal+0x60/0xa0
[  117.070217] [] ata_read_log_page+0x188/0x1b4
[  117.070218] [] ata_eh_analyze_ncq_error+0xa8/0x274
[  117.070220] [] ata_eh_link_autopsy+0x94/0x8c8
[  117.070222] [] ata_eh_autopsy+0x34/0xe8
[  117.070223] [] ata_do_eh+0x28/0xc0
[  117.070225] [] ata_std_error_handler+0x3c/0x84
[  117.070227] [] ata_scsi_port_error_handler+0x480/0x674
[  117.070230] [] async_sas_ata_eh+0x44/0x78
[  117.070231] [] async_run_entry_fn+0x40/0x104
[  117.070234] [] process_one_work+0x128/0x2f0
[  117.070235] [] worker_thread+0x58/0x434
[  117.070237] [] kthread+0xd4/0xe8
[  117.070240] [] ret_from_fork+0x10/0x40

The issue is resolved by simply returning a failure status code to the
upper layer.

Signed-off-by: Xiang Chen 
Signed-off-by: John Garry 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: hisi_sas: fix phy8 linkrate calculation in phy_up_v2_hw()

2016-09-14T16:54:17+00:00

In function phy_up_v2_hw(), we needlessly recalculate the phy linkrate
for all phys, and the calculation is incorrect for phy8, so remove this
code.

Signed-off-by: John Garry 
Signed-off-by: Xiang Chen 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: hisi_sas: disable dlvry queues once at reset for v2 hw

2016-09-14T16:54:17+00:00

The Delivery queue enable register should only be written to once at
reset for v2 hw.

Signed-off-by: John Garry 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen