linux-toradex.git/drivers/scsi/hpsa.c, branch colibri_vf

hpsa: Disable ASPM

2011-11-26T17:09:52+00:00

commit e5a44df85e8d78e5c2d3d2e4f59b460905691e2f upstream.

The Windows driver .inf disables ASPM on hpsa devices. Do the same because the
selection of a non default ASPM policy can cause the device to hang.

Signed-off-by: Matthew Garrett 
Acked-by: Mike Miller 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

hpsa: add small delay when using PCI Power Management to reset for kump

2011-11-11T17:37:08+00:00

commit c4853efec665134b2e6fc9c13447323240980351 upstream.

The P600 requires a small delay when changing states. Otherwise we may think
the board did not reset and we bail. This for kdump only and is particular
to the P600.

Signed-off-by: Mike Miller 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

hpsa: fix physical device lun and target numbering problem

2011-10-03T18:40:24+00:00

commit 01350d05539d1c95ef3568d062d864ab76ae7670 upstream.

If a physical device exposed to the OS by hpsa
is replaced (e.g. one hot plug tape drive is replaced
by another, or a tape drive is placed into "OBDR" mode
in which it acts like a CD-ROM device) and a rescan is
initiated, the replaced device will be added to the
SCSI midlayer with target and lun numbers set to -1.
After that, a panic is likely to ensue.  When a physical
device is replaced, the lun and target number should be
preserved.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

hpsa: fix problem that OBDR devices are not detected

2011-10-03T18:40:23+00:00

commit 0b0e1d6cbcc8627970e0399df8f06edd690ec7d9 upstream.

The test to detect OBDR ("One Button Disaster Recovery")
cd-rom devices was comparing against uninitialized data.

Fixed by moving the test for the device to where the
inquiry data is collected, and uninitialized variable
altogether as it wasn't really being used.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

[SCSI] hpsa: fix potential overrun while memcpy'ing sense data

2011-06-29T17:09:56+00:00

This memcpy:

   memcpy(cmd->sense_buffer, ei->SenseInfo,
	   ei->SenseLen > SCSI_SENSE_BUFFERSIZE ?
		   SCSI_SENSE_BUFFERSIZE :
		   ei->SenseLen);

The ei->SenseLen field is filled in by the Smart Array.  For requests to
logical drives, it will not exceed 32 bytes, so should be ok, but for physical
requests it depends on the target device, not the Smart Array.  It's conceivable
that this could exceed the 32 byte size of ei->SenseInfo.  In that case, the memcpy
would read past the end of ei->SenseInfo, copying data from the next command,
as if it were sense data, or, if it happened to be the very last command in the
block of allocated commands, could fall off the end of the allocated area and
crash.  I'm not aware of anyone ever encountering this behavior, but it could
conceivably happen.  This bug was found by Coverity.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: James Bottomley

[SCSI] hpsa: fix dma unmap error in hpsa_passthru_ioctl

2011-06-29T17:09:53+00:00

Signed-off-by: Stephen M. Cameron 
Signed-off-by: James Bottomley

[SCSI] hpsa: Change memset using sizeof(ptr) to sizeof(*ptr)

2011-05-17T07:19:27+00:00

Not at all sure this is correct or appropriate to change,
but this seems odd.

Found via coccinelle script

@@
type T;
T* ptr;
expression E1;
@@

* memset(E1, 0, sizeof(ptr));

Signed-off-by: Joe Perches 
Acked-by: Stephen M. Cameron 
Signed-off-by: James Bottomley 
Signed-off-by: James Bottomley

[SCSI] hpsa: add P2000 to list of shared SAS devices

2011-05-17T07:09:41+00:00

Signed-off-by: Scott Teel 
Signed-off-by: James Bottomley 
Signed-off-by: James Bottomley

[SCSI] hpsa: do not attempt PCI power management reset method if we know it won't work.

2011-05-17T07:08:09+00:00

Just go straight to the soft-reset method instead.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: James Bottomley 
Signed-off-by: James Bottomley

[SCSI] hpsa: remove superfluous sleeps around reset code

2011-05-17T07:07:50+00:00

Signed-off-by: Stephen M. Cameron 
Signed-off-by: James Bottomley 
Signed-off-by: James Bottomley