linux-toradex.git/drivers/scsi/hpsa.c, branch v3.14.33

hpsa: fix bad -ENOMEM return value in hpsa_big_passthru_ioctl

2014-09-05T23:34:16+00:00

commit 0758f4f732b08b6ef07f2e5f735655cf69fea477 upstream.

When copy_from_user fails, return -EFAULT, not -ENOMEM

Signed-off-by: Stephen M. Cameron 
Reported-by: Robert Elliott 
Reviewed-by: Joe Handzik 
Reviewed-by: Scott Teel 
Reviewed by: Mike MIller 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Greg Kroah-Hartman

hpsa: fix non-x86 builds

2014-09-05T23:34:16+00:00

commit 0b9e7b741f2bf8103b15bb14d5b4a6f5ee91c59a upstream.

commit 28e134464734 "[SCSI] hpsa: enable unit attention reporting"
turns on unit attention notifications, but got the change wrong for
all architectures other than x86, which now store an uninitialized
value into the device register.

Gcc helpfully warns about this:

../drivers/scsi/hpsa.c: In function 'hpsa_set_driver_support_bits':
../drivers/scsi/hpsa.c:6373:17: warning: 'driver_support' is used uninitialized in this function [-Wuninitialized]
  driver_support |= ENABLE_UNIT_ATTN;
                 ^

This moves the #ifdef so only the prefetch-enable is conditional
on x86, not also reading the initial register contents.

Signed-off-by: Arnd Bergmann 
Fixes: 28e134464734 "[SCSI] hpsa: enable unit attention reporting"
Acked-by: Stephen M. Cameron 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Greg Kroah-Hartman

[SCSI] hpsa: allow SCSI mid layer to handle unit attention

2013-12-20T04:56:30+00:00

We were clobbering the SCSI status and setting
cmd->result = DID_SOFT_ERROR << 16; to get a retry,
but better to let the mid layer handle the unit
attention.

Signed-off-by: Matt Gates 
Acked-by: Stephen M. Cameron 
Signed-off-by: James Bottomley

[SCSI] hpsa: do not require board "not ready" status after hard reset

2013-12-20T04:56:30+00:00

Immediately following a hard board reset, There are some
mandatory delays during which we must not access the board
and during which we might miss the "not ready" status,
therefore it is a mistake to look for and expect to see
the "not ready" status.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: James Bottomley

[SCSI] hpsa: enable unit attention reporting

2013-12-20T04:56:30+00:00

This used to be the default, but at some point the firmware guys
changed the default and I failed to notice.  Now to get unit
attention notifications, you must twiddle a bit indicating you
want them.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: James Bottomley

[SCSI] hpsa: rename scsi prefetch field

2013-12-20T04:56:29+00:00

The field contains more bits than just the one
to indicate whether scsi prefetch should be turned on.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: James Bottomley

[SCSI] hpsa: use workqueue instead of kernel thread for lockup detection

2013-12-20T04:56:29+00:00

Much simpler and avoids races starting/stopping the thread.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: James Bottomley

[SCSI] hpsa: remove P822se PCI ID

2013-12-19T15:39:04+00:00

Remove PCI ID for the never shipped P822se.

Signed-off-by: Mike Miller 
Signed-off-by: James Bottomley

[SCSI] hpsa: prevent stalled i/o

2013-12-19T15:38:56+00:00

If a fifo full condition is encountered, i/o requests will stack
up in the h->reqQ queue.  The only thing which empties this queue
is start_io, which only gets called when new i/o requests come in.
If none are forthcoming, i/o in h->reqQ will be stalled.

To fix this, whenever fifo full condition is encountered, this
is recorded, and the interrupt handler examines this to see
if a fifo full condition was recently encountered when a
command completes and will call start_io to prevent i/o's in
h->reqQ from getting stuck.

I've only ever seen this problem occur when running specialized
test programs that pound on the the CCISS_PASSTHRU ioctl.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: James Bottomley

[SCSI] hpsa: cap CCISS_PASSTHRU at 20 concurrent commands.

2013-12-19T15:38:56+00:00

Cap CCISS_BIG_PASSTHRU as well.  If an attempt is made
to exceed this, ioctl() will return -1 with errno == EAGAIN.

This is to prevent a userland program from exhausting all of
pci_alloc_consistent memory.  I've only seen this problem when
running a special test program designed to provoke it.  20
concurrent commands via the passthru ioctls (not counting SG_IO)
should be more than enough.

Signed-off-by: Stephen M. Cameron 
Signed-off-by: James Bottomley