linux-toradex.git/drivers/scsi/hpsa.c, branch v4.1.12

Fix weird uses of num_online_cpus().

2015-03-10T03:24:42+00:00

This may be OK in archs with contiguous CPU numbers and without
hotplug CPUs, but it sets a terrible example.

And open-coding it like drivers/scsi/hpsa.c is just weird.

BTRFS has a weird comparison with num_online_cpus() too, but since
BTRFS just screwed up my test machines' root partition, I'm not
touching it :)

Signed-off-by: Rusty Russell 
Reported-by: Oleg Drokin

hpsa: correct compiler warnings introduced by hpsa-add-local-workqueue patch

2015-02-15T18:33:32+00:00

Correct compiler warning introduced by hpsa-add-local-workqueue patch
6636e7f455b33b957c5ee016daa6de46148026ab hpsa: Use local workqueues
instead of system workqueues

Suggested-by: Kees Cook 
Reviewed-by: Scott Teel 
Reviewed-by: Webb Scales 
Signed-off-by: Don Brace 
Signed-off-by: James Bottomley

hpsa: Use local workqueues instead of system workqueues

2015-02-02T17:57:44+00:00

Suggested-by: Tomas Henzl 
Reviewed-by: Webb Scales 
Reviewed-by: Kevin Barnett 
Signed-off-by: Don Brace 
Signed-off-by: Christoph Hellwig

hpsa: add in P840ar controller model name

2015-02-02T17:57:44+00:00

Add in P840ar model name for gen9

Reviewed-by: Scott Teel 
Signed-off-by: Don Brace 
Signed-off-by: Christoph Hellwig

hpsa: add in gen9 controller model names

2015-02-02T17:57:44+00:00

Add in gen9 controller model names

Reviewed-by: Scott Teel 
Signed-off-by: Don Brace 
Signed-off-by: Christoph Hellwig

hpsa: detect and report failures changing controller transport modes

2015-02-02T17:57:44+00:00

Detect failues when attempting to change controller to use simple
or performant transport modes (mode change ack) rather than just
proceeding ahead after timeouts.

Return values are added to:
	hpsa_put_ctlr_into_performant_mode
	hpsa_wait_for_mode_change_ack
and all their callers check/propagate the result.

More consistency in printing errors and whether
dev_err is used.

Reviewed-by: Scott Teel 
Signed-off-by: Robert Elliott 
Signed-off-by: Don Brace 
Signed-off-by: Christoph Hellwig

hpsa: shorten the wait for the CISS doorbell mode change ack

2015-02-02T17:57:44+00:00

Shorten the wait for the CISS configuration table doorbell mode
change acknowledgment from 300-600 s to 20 s, which is the value
specified in the CISS specification that should be honored by
all controllers.

Wait using interruptible msleep() rather than uninterruptible
usleep_range(), which triggers rt_sched timeout errors if the
wait is long.

Reviewed-by: Scott Teel 
Signed-off-by: Robert Elliott 
Signed-off-by: Don Brace 
Signed-off-by: Christoph Hellwig

hpsa: refactor duplicated scan completion code into a new routine

2015-02-02T17:57:43+00:00

Hoist the conditional out of do_not_scan_if_controller_locked_up() and
place it in the caller (this improves the code structure, making it
more consistent with other uses and enabling tail-call optimization);
rename the function to hpsa_scan_complete(), and use it at the end of
hpsa_scan_start() as well.

Reviewed-by: Scott Teel 
Signed-off-by: Webb Scales 
Signed-off-by: Don Brace 
Signed-off-by: Christoph Hellwig

hpsa: move SG descriptor set-up out of hpsa_scatter_gather()

2015-02-02T17:57:43+00:00

Move the code which sets up the SG descriptor out of hpsa_scatter_gather()
and into a subroutine where it can be reused (in the next patch).  The Ext
field is now assigned unconditionally: this makes the refactor much simpler,
but more importantly it removes a conditional operation from inside the
loop.  The case for which the conditional formerly tested is now executed
(unconditionally) after the loop is exited.

Reviewed-by: Scott Teel 
Signed-off-by: Webb Scales 
Signed-off-by: Don Brace 
Signed-off-by: Christoph Hellwig

hpsa: do not use function pointers in fast path command submission

2015-02-02T17:57:43+00:00

Performance tweak, avoid unnecessary function calls.

Reviewed-by: Scott Teel 
Signed-off-by: Don Brace 
Signed-off-by: Christoph Hellwig