linux-toradex.git/drivers/scsi/hpsa_cmd.h, branch v4.1.26

hpsa: do not use a void pointer for scsi_cmd field of struct CommandList

2015-02-02T17:57:43+00:00

There's no reason for it to be a void *, it should be a struct scsi_cmnd *

Reviewed-by: Scott Teel 
Signed-off-by: Don Brace 
Signed-off-by: Christoph Hellwig

hpsa: fix race between abort handler and main i/o path

2015-02-02T17:57:40+00:00

This means changing the allocator to reference count commands.
The reference count is now the authoritative indicator of whether a
command is allocated or not.  The h->cmd_pool_bits bitmap is now
only a heuristic hint to speed up the allocation process, it is no
longer the authoritative record of allocated commands.

Since we changed the command allocator to use reference counting
as the authoritative indicator of whether a command is allocated,
fail_all_outstanding_cmds needs to use the reference count not
h->cmd_pool_bits for this purpose.

Fix hpsa_drain_accel_commands to use the reference count as the
authoritative indicator of whether a command is allocated instead of
the h->cmd_pool_bits bitmap.

Reviewed-by: Scott Teel 
Signed-off-by: Don Brace 
Signed-off-by: Christoph Hellwig

hpsa: honor queue depth of physical devices

2015-02-02T17:57:40+00:00

When using the ioaccel submission methods, requests destined for RAID volumes
are sometimes diverted to physical devices.  The OS has no or limited
knowledge of these physical devices, so it is up to the driver to avoid
pushing the device too hard.  It is better to honor the physical device queue
limit rather than making the device spew zillions of TASK SET FULL responses.

This is so that hpsa based devices support /sys/block/sdNN/device/queue_type
of simple, which lets the SCSI midlayer automatically adjust the queue_depth
based on TASK SET FULL and GOOD status.

Adjust the queue depth for a new device after it is created based on the
maximum queue depths of the physical devices that constitute the
device. This drops the maximum queue depth from .can_queue of 1024 to
something like 174 for single-drive RAID-0, 348 for two-drive RAID-1, etc.
It also adjusts for the ratio of data to parity drives.

Reviewed-by: Scott Teel 
Signed-off-by: Webb Scales 
Signed-off-by: Don Brace 
Signed-off-by: Christoph Hellwig

hpsa: use workqueue to resubmit failed ioaccel commands

2015-02-02T17:57:40+00:00

Instead of kicking the commands all the way back to the mid
layer, use a work queue.  This enables having a mechanism for
the driver to be able to resubmit the commands down the "normal"
raid path without turning off the ioaccel feature entirely
whenever an error is encountered on the ioaccel path, and
prevent excessive rescanning of devices.

Reviewed-by: Scott Teel 
Signed-off-by: Don Brace 
Signed-off-by: Christoph Hellwig

hpsa: do not queue commands internally in driver

2015-02-02T17:57:39+00:00

By not doing maintaining a list of queued commands, we can eliminate some spin
locking in the main i/o path and gain significant improvement in IOPS.  Remove
the queuing code and the code that calls it; remove now-unused interrupt code;
remove DIRECT_LOOKUP_BIT.

Now that the passthru commands share the same command pool as
the main i/o path, and the total size of the pool is less than
or equal to the number of commands that will fit in the hardware
fifo, there is no need to check to see if we are exceeding the
hardware fifo's depth.

Reviewed-by: Scott Teel 
Reviewed-by: Robert Elliott 
Signed-off-by: Don Brace 
Signed-off-by: Christoph Hellwig

hpsa: correct endian sparse warnings

2015-02-02T17:57:35+00:00

Correct endiness issues reported by sparse. SA controllers are
little endian. This patch ensures endiness correctness.

Signed-off-by: Don Brace 
Reviewed-by: Scott Teel 
Reviewed-by: Webb Scales 
Signed-off-by: Christoph Hellwig

hpsa: get rid of type/attribute/direction bit field where possible

2014-11-20T08:11:25+00:00

Using bit fields for hardware command fields isn't portable and
relies on assumptions about how the compiler lays out the bits.
We can fix this in the driver's internal command structure, but the
ioctl interface we can't change because it is part of the
userland ABI.

Signed-off-by: Don Brace 
Reviewed-by: Webb Scales 
Signed-off-by: Christoph Hellwig

hpsa: fix endianness issue with scatter gather elements

2014-11-20T08:11:24+00:00

The hardware needs little endian scatter gather addresses and
lengths but we were not bothering to convert from cpu byte
order as we should have been.  On Intel, this is all just
a bunch of no-ops macros, but it makes the code endian-clean(er).

Signed-off-by: Don Brace 
Signed-off-by: Robert Elliott 
Reviewed-by: Webb Scales 
Signed-off-by: Christoph Hellwig

hpsa: fix allocation sizes for CISS_REPORT_LUNs commands

2014-11-20T08:11:24+00:00

We were allocating roughly double the amount of memory
we should be due to ReportLUNdata and ExtendedReportLUNdata
containing a non-zero sized array but adding extra memory
to allocate as if the array were zero sized.

Track the logical and physical sizes separately.
Allocate the memory based on the specific data
structure sizes.

Signed-off-by: Don Brace 
Reviewed-by: Webb Scales 
Signed-off-by: Christoph Hellwig

hpsa: fix handling of hpsa_volume_offline return value

2014-06-02T07:55:02+00:00

Make return value an int instead of an unsigned char so that
we do not lose negative error return values.

Signed-off-by: Stephen M. Cameron 
Reviewed-by: Webb Scales 
Reported-by: Dan Carpenter 
Signed-off-by: Christoph Hellwig