linux-toradex.git/drivers/scsi/hpsa_cmd.h, branch v4.4.48

hpsa: add in sas transport class

2015-11-09T17:39:28+00:00

Reviewed-by: Scott Teel 
Reviewed-by: Justin Lindley 
Reviewed-by: Kevin Barnett 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Tomas Henzl 
Reviewed-by: Matthew R. Ochs 
Signed-off-by: Don Brace 
Signed-off-by: Martin K. Petersen

hpsa: disable report lun data caching

2015-11-09T17:39:27+00:00

When external target arrays are present, disable the firmware's
normal behavior of returning a cached copy of the report lun data,
and force it to collect new data each time we request a report luns.

This is necessary for external arrays, since there may be no
reliable signal from the external array to the smart array when
lun configuration changes, and thus when driver requests
report luns, it may be stale data.

Use diag options to turn off RPL data caching.

Reviewed-by: Scott Teel 
Reviewed-by: Justin Lindley 
Reviewed-by: Kevin Barnett 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Matthew R. Ochs 
Signed-off-by: Don Brace 
Signed-off-by: Martin K. Petersen

hpsa: generalize external arrays

2015-11-09T17:39:26+00:00

External array LUNs must use target and lun numbers assigned by the
external array. So the driver must treat these differently from
local LUNs when assigning lun/target.

LUN's 'model' field has been used to detect Lun types that need
special treatment, but the desire is to eliminate the need to reference
specific array models, and support any external array.

Pass-through RAID (PTRAID) luns are not luns of the local controller,
so they are not reported in LUN count of command 'ID controller'.
However, they ARE reported in "Report logical Luns" command.
Local luns are listed first, then PTRAID LUNs.

The number of luns from "Report LUNs" in excess of those reported by
'ID controller' are therefore the PTRAID LUNS.

We can now remove function is_ext_target, and the 'white list'
array of supported model names.

Reviewed-by: Scott Teel 
Reviewed-by: Justin Lindley 
Reviewed-by: Kevin Barnett 
Signed-off-by: Don Brace 
Reviewed-by: Matthew R. Ochs 
Signed-off-by: Martin K. Petersen

hpsa: correct check for non-disk devices

2015-11-09T17:34:20+00:00

The driver is using two MACROs which seemingly are looking in
the wrong location for the device_flags returned from
CISS_REPORT_PHYS. Both MACROs, NON_DISK_PHYS_DEV and
PHYS_IOACCEL, are using the pointer returned from figure_lunaddrbytes
which is the address of the LUN.lunid element in
the extended CISS_REPORT_PHYS.  But the MACROS are using offsets
beyond the range of the element (offset 17 of an 8 byte element).

These MACROs actually are looking at the correct location but
they fail static checker analysis. It also will not work
if any new elements are added to the extended LUN structure.

Change the code to use the structure elements directly
since this MACRO is only used in one location.

Reported-by: Dan Carpenter 
Reviewed-by: Scott Teel 
Reviewed-by: Justin Lindley 
Reviewed-by: Kevin Barnett 
Reviewed-by: Tomas Henzl 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Don Brace 
Signed-off-by: Martin K. Petersen

hpsa: add in new offline mode

2015-08-26T23:28:48+00:00

prevent adding volumes that are not available.

Reviewed-by: Kevin Barnett 
Reviewed-by: Scott Teel 
Reviewed-by: Justin Lindley 
Reviewed-by: Tomas Henzl 
Signed-off-by: Don Brace 
Signed-off-by: James Bottomley

hpsa: add PMC to copyright

2015-08-26T23:23:40+00:00

need to add PMC to copyright notice and update the Hewlett-Packard
copyright notification.

Reviewed-by: Scott Teel 
Reviewed-by: Kevin Barnett 
Reviewed-by: Justin Lindley 
Signed-off-by: Don Brace 
Signed-off-by: James Bottomley

hpsa: cleanup reset

2015-06-01T00:47:31+00:00

Synchronize completion the reset with completion of outstanding commands

Extending the newly-added synchronous abort functionality,
now also synchronize resets with the completion of outstanding commands.
Rename the wait queue to reflect the fact that it's being used for both
types of waits.  Also, don't complete commands which are terminated
due to a reset operation.

fix for controller lockup during reset

Reviewed-by: Scott Teel 
Reviewed-by: Kevin Barnett 
Reviewed-by: Tomas Henzl 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Webb Scales 
Signed-off-by: Don Brace 
Reviewed-by: Christoph Hellwig 
Signed-off-by: James Bottomley

hpsa: don't return abort request until target is complete

2015-05-31T18:37:48+00:00

Don't return from the abort request until the target command is complete.
Mark outstanding commands which have a pending abort, and do not send them
to the host if we can avoid it.

If the current command has been aborted, do not call the SCSI command
completion routine from the I/O path: when the abort returns successfully,
the SCSI mid-layer will handle the completion implicitly.

The following race was possible in theory.

1. LLD is requested to abort a scsi command
2. scsi command completes
3. The struct CommandList associated with 2 is made available.
4. new io request to LLD to another LUN re-uses struct CommandList
5. abort handler follows scsi_cmnd->host_scribble and
   finds struct CommandList and tries to aborts it.

Now we have aborted the wrong command.

Fix by resetting the scsi_cmd field of struct CommandList
upon completion and making the abort handler check that
the scsi_cmd pointer in the CommadList struct matches the
scsi_cmnd that it has been asked to abort.

Reviewed-by: Scott Teel 
Reviewed-by: Kevin Barnett 
Reviewed-by: Tomas Henzl 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Webb Scales 
Signed-off-by: Don Brace 
Reviewed-by: Christoph Hellwig 
Signed-off-by: James Bottomley

hpsa: add support sending aborts to physical devices via the ioaccel2 path

2015-05-31T18:36:51+00:00

add support for tmf when in ioaccel2 mode

Reviewed-by: Scott Teel 
Reviewed-by: Kevin Barnett 
Reviewed-by: Tomas Henzl 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Joe Handzik 
Signed-off-by: Don Brace 
Reviewed-by: Christoph Hellwig 
Signed-off-by: James Bottomley

hpsa: add more ioaccel2 error handling, including underrun statuses.

2015-05-31T18:33:17+00:00

improve ioaccel2 error handling, including better handling of
underrun statuses

Reviewed-by: Scott Teel 
Reviewed-by: Kevin Barnett 
Signed-off-by: Joe Handzik 
Signed-off-by: Don Brace 
Reviewed-by: Christoph Hellwig 
Signed-off-by: James Bottomley