linux-toradex.git/drivers/scsi/ipr.c, branch v3.2.17

[SCSI] ipr: add definitions for additional adapter

2011-10-31T09:12:50+00:00

Add the appropriate definition and table entry for an additional adapter.

Signed-off-by: Wayne Boyer 
Acked-by: Brian King 
Signed-off-by: James Bottomley

[SCSI] ipr: Fix BUG on adapter dump timeout

2011-10-20T15:19:55+00:00

If an adapter dump times out, the ipr driver will abort the
dump and proceed to reset and recover the adapter. When an
adapter dump completes, the work thread which is reading the
adapter dump will initiate an adapter reset to recover the
adapter. However, when the adapter dump gets aborted, the
work thread should not initiate an adapter reset, since an
adapter reset is already in progress. This fixes a case of
calling pci_block_user_cfg_access overlapped, which results
in a BUG.

Signed-off-by: Brian King 
Signed-off-by: James Bottomley

[SCSI] ipr: Add support to flash FPGA and flash back DRAM images

2011-10-16T15:56:27+00:00

The write buffer command is used to download and burn new IOA FW images.
The same interface can now be used to flash FPGA and flash back DRAM images.
To download and flash the new images takes more than 15 minutes, so increase
the write buffer command timeout to 30 minutes.

The FPGA and flash back DRAM images don't have the same card_type as the IOA FW
image. So, remove the sanity checking from the driver.  The adapter has sanity
checking and will only accept a valid image.

Signed-off-by: Wayne Boyer 
Acked-by: Brian King 
Signed-off-by: James Bottomley

[SCSI] ipr: Stop reading adapter dump prematurely

2011-09-22T11:30:28+00:00

When the ipr driver decides to dump the adapter, it changes the
sdt_state to GET_DUMP, then prepares the adapter so that the dump
can be read. However, if the ipr worker thread wakes up for some
reason before the driver has put the adapter in a state where it
can succesfully dump the adapter, the driver will start dumping
the adapter too early, which can potentially trigger a BUG check
in the pci config blocking API. Fix this by adding a new
sdt_state to differentiate between the ipr driver wanting to dump
the adapter in the near future and wanting to dump the adapter now.

Signed-off-by: Brian King 
Signed-off-by: James Bottomley

[SCSI] ipr: Always initiate hard reset in kdump kernel

2011-08-27T14:35:55+00:00

During kdump testing I noticed timeouts when initialising each IPR
adapter. While the driver has logic to detect an adapter in an
indeterminate state, it wasn't triggering and each adapter went
through a 5 minute timeout before finally going operational.

Some analysis showed the needs_hard_reset flag wasn't getting set.
We can check the reset_devices kernel parameter which is set by
kdump and force a full reset. This fixes the problem.

Signed-off-by: Anton Blanchard 
Cc: 
Acked-by: Brian King 
Signed-off-by: James Bottomley

[SCSI] ipr: reorder error handling code to include iounmap

2011-07-27T13:45:08+00:00

The out_msi_disable label should be before cleanup_nomem to additionally
benefit from the call to iounmap.  Subsequent gotos are adjusted to go to
out_msi_disable instead of cleanup_nomem, which now follows it.  This is
safe because pci_disable_msi does nothing if pci_enable_msi was not called.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// 
@r@
expression e1,e2;
statement S;
@@

e1 = pci_ioremap_bar(...);
... when != e1 = e2
    when != iounmap(e1)
    when any
(
 if (<+...e1...+>) S
|
 if(...) { ... return 0; }
|
 if (...) { ... when != iounmap(e1)
                when != if (...) { ... iounmap(e1) ... }
* return ...;
 } else S
)
// 

Signed-off-by: Julia Lawall 
Acked-by: Brian King 
Signed-off-by: Andrew Morton 
Signed-off-by: James Bottomley

[SCSI] ipr: fix possible false positive detection of stuck interrupt

2011-05-24T16:37:50+00:00

If the driver is getting flooded with interrupts, there's a possibility
that the interrupt service routine could falsely detect a stuck interrupt
condition and reset the adapter.

This patch changes the logic such that the routine will loop back into
the command processing code one more time after detecting the stuck
interrupt signature.  If there are no commands to process after that pass,
and the interrupt is still not cleared, then the driver will print the
"Error clearing HRRQ" message and reset the adapter.

Signed-off-by: Wayne Boyer 
Acked-by: Brian King 
Signed-off-by: James Bottomley

[SCSI] ipr: Rate limit DMA mapping errors

2011-05-17T07:17:07+00:00

I noticed a stream of errors from the IPR driver while doing
IOMMU fault injection. Rate limit the errors so we don't clog
up the console and logfiles.

Signed-off-by: Anton Blanchard 
Acked-by: Brian King 
Signed-off-by: James Bottomley 
Signed-off-by: James Bottomley

[SCSI] ipr: increase the dump size for 64 bit adapters

2011-05-01T17:09:20+00:00

Currently the size of the dump generated by the driver is limited
in 4MB, which is insufficient to gather much useful data from the
new 64 bit adapters.

This patch makes the needed changes to increase the dump limit
for the 64 bit adapters to 32MB, or even to a bigger value in the
future, but keeping the current limitations for the legacy 32 bit
adapters.

Signed-off-by: Kleber Sacilotto de Souza 
Acked-by: Brian King 
Signed-off-by: James Bottomley

[SCSI] ipr: improve interrupt service routine performance

2011-05-01T15:48:53+00:00

During performance testing on P7 machines it was observed that the interrupt
service routine was doing unnecessary MMIO operations.

This patch rearranges the logic of the routine and moves some of the code out
of the main routine.  The result is that there are now fewer MMIO operations in
the performance path of the code.

As a result of the above change, an existing condition was exposed where the
driver could get an "unexpected" hrrq interrupt.  The original code would flag
the interrupt as unexpected and then reset the adapter.  After further analysis
it was confirmed that this condition can occasionally occur and that the
interrupt can safely be ignored.  Additional code in this patch detects this
condition, clears the interrupt and allows the driver to continue without
resetting the adapter.

Signed-off-by: Wayne Boyer 
Acked-by: Brian King 
Signed-off-by: James Bottomley