linux-toradex.git/drivers/scsi/libfc/fc_exch.c, branch v3.11

libfc: Differentiate echange timer cancellation debug statements

2013-07-09T18:18:41+00:00

There are two debug statements with the same output string regarding
echange timer cancellation. This patch simply changes the output of
one string so that they can be differentiated.

Signed-off-by: Robert Love 
Tested-by: Jack Morgan 
Acked-by: Neil Horman

libfc: Remove extra space in fc_exch_timer_cancel definition

2013-07-09T18:18:33+00:00

Simply remove an extra space that violates coding style.

Signed-off-by: Robert Love 
Tested-by: Jack Morgan 
Acked-by: Neil Horman

libfc: extend ex_lock to protect all of fc_seq_send

2013-05-10T17:19:23+00:00

This warning was reported recently:

WARNING: at drivers/scsi/libfc/fc_exch.c:478 fc_seq_send+0x14f/0x160 [libfc]()
(Not tainted)
Hardware name: ProLiant DL120 G7
Modules linked in: tcm_fc target_core_iblock target_core_file target_core_pscsi
target_core_mod configfs dm_round_robin dm_multipath 8021q garp stp llc bnx2fc
cnic uio fcoe libfcoe libfc scsi_transport_fc scsi_tgt autofs4 sunrpc
pcc_cpufreq ipv6 hpilo hpwdt e1000e microcode iTCO_wdt iTCO_vendor_support
serio_raw shpchp ixgbe dca mdio sg ext4 mbcache jbd2 sd_mod crc_t10dif pata_acpi
ata_generic ata_piix hpsa dm_mirror dm_region_hash dm_log dm_mod [last unloaded:
scsi_wait_scan]
Pid: 5464, comm: target_completi Not tainted 2.6.32-272.el6.x86_64 #1
Call Trace:
 [] ? warn_slowpath_common+0x87/0xc0
 [] ? warn_slowpath_null+0x1a/0x20
 [] ? fc_seq_send+0x14f/0x160 [libfc]
 [] ? ft_queue_status+0x16e/0x210 [tcm_fc]
 [] ? target_complete_ok_work+0x0/0x4b0 [target_core_mod]
 [] ? target_complete_ok_work+0x106/0x4b0 [target_core_mod]
 [] ? target_complete_ok_work+0x0/0x4b0 [target_core_mod]
 [] ? worker_thread+0x170/0x2a0
 [] ? autoremove_wake_function+0x0/0x40
 [] ? worker_thread+0x0/0x2a0
 [] ? kthread+0x96/0xa0
 [] ? child_rip+0xa/0x20
 [] ? kthread+0x0/0xa0
 [] ? child_rip+0x0/0x20

It occurs because fc_seq_send can have multiple contexts executing within it at
the same time, and fc_seq_send doesn't consistently use the ep->ex_lock that
protects this structure.  Because of that, its possible for one context to clear
the INIT bit in the ep->esb_state field while another checks it, leading to the
above stack trace generated by the WARN_ON in the function.

We should probably undertake the effort to convert access to the fc_exch
structures to use rcu, but that a larger work item.  To just fix this specific
issue, we can just extend the ex_lock protection through the entire fc_seq_send
path

Signed-off-by: Neil Horman 
Reported-by: Gris Ge 
CC: Robert Love 
Signed-off-by: Robert Love

[SCSI] libfc: add exch timer debug info

2012-07-20T07:58:55+00:00

Add exch timeout info to have debug log with exch timeout
value to match with retries, also add debug info
on exch timer cancel.

Added common fc_exch_timer_cancel() func and grouped this
along with fc_exch_timer_set() function, so that
added debug code is not repeated.

Signed-off-by: Vasu Dev 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: update fcp and exch stats

2012-07-20T07:31:48+00:00

Updates newly added stats from fc_get_host_stats,
added new function fc_exch_update_stats to
update exches related stats from fc_exch.c
by going thru internal ema_list elements.

Signed-off-by: Vasu Dev 
Acked-by : Robert Love 
Tested-by: Ross Brattain 
Signed-off-by: James Bottomley

[SCSI] libfc, fcoe, bnx2fc: cleanup fcoe_dev_stats

2012-07-20T07:31:47+00:00

The libfc is used by fcoe but fcoe agnostic,
and therefore should not have any fcoe references.

So renaming fcoe_dev_stats from libfc as its for fc_stats.
After that libfc is fcoe string free except some strings for
Open-FCoE.org.

Signed-off-by: Vasu Dev 
Acked-by : Robert Love 
Tested-by: Ross Brattain 
Acked-by: Bhanu Prakash Gollapudi 
Signed-off-by: James Bottomley

[SCSI] libfc: fcoe_transport_create fails in single-CPU environment

2012-03-28T08:33:04+00:00

Starting fcoe fails at fcoe_transport_create when attempting to allocate a
pool of 4K exchanges on a 64-bit single-CPU environment because the call to
__alloc_percpu() is greater than the max of 32K.  This patch reduces the
number of exchanges to fit within the maximum allowed space.

[ Whitespace problems fixed by Robert Love to satisfy chechpatch.pl ]

Signed-off-by: Steven Clark 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: Fix panic in fc_exch_recv

2012-02-19T15:26:07+00:00

Adding and removing the host into the zone causes this panic.

BUG: unable to handle kernel NULL pointer dereference at 00000000000000a0
IP: [] fc_exch_recv+0xc57/0xe70 [libfc]
Call Trace:
[] bnx2fc_l2_rcv_thread+0x37b/0x430 [bnx2fc]
[] ? bnx2fc_l2_rcv_thread+0x0/0x430 [bnx2fc]
[] kthread+0x96/0xa0
[] child_rip+0xa/0x20
[] ? kthread+0x0/0xa0
[] ? child_rip+0x0/0x20

During fc_exch_reset, the active exchanges are aborted and the exch is deleted.
As part of processing ABTS response, due to 'ep' being NULL, any access to ep in
fc_exch_recv_bls() causes this panic. Fixed to access 'ep' only if non-NULL.

Reviewed-by: Neerav Parikh 
Signed-off-by: Bhanu Prakash Gollapudi 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: Declare local functions static

2012-01-16T08:45:48+00:00

Avoid that sparse complains about missing declarations for local
functions by declaring these static or by adding an #include directive.
Add the __percpu annotation where it is missing.

Signed-off-by: Bart Van Assche 
Reviewed-by: Yi Zou 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux

2011-11-07T03:44:47+00:00

* 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux: (230 commits)
  Revert "tracing: Include module.h in define_trace.h"
  irq: don't put module.h into irq.h for tracking irqgen modules.
  bluetooth: macroize two small inlines to avoid module.h
  ip_vs.h: fix implicit use of module_get/module_put from module.h
  nf_conntrack.h: fix up fallout from implicit moduleparam.h presence
  include: replace linux/module.h with "struct module" wherever possible
  include: convert various register fcns to macros to avoid include chaining
  crypto.h: remove unused crypto_tfm_alg_modname() inline
  uwb.h: fix implicit use of asm/page.h for PAGE_SIZE
  pm_runtime.h: explicitly requires notifier.h
  linux/dmaengine.h: fix implicit use of bitmap.h and asm/page.h
  miscdevice.h: fix up implicit use of lists and types
  stop_machine.h: fix implicit use of smp.h for smp_processor_id
  of: fix implicit use of errno.h in include/linux/of.h
  of_platform.h: delete needless include 
  acpi: remove module.h include from platform/aclinux.h
  miscdevice.h: delete unnecessary inclusion of module.h
  device_cgroup.h: delete needless include 
  net: sch_generic remove redundant use of 
  net: inet_timewait_sock doesnt need 
  ...

Fix up trivial conflicts (other header files, and  removal of the ab3550 mfd driver) in
 - drivers/media/dvb/frontends/dibx000_common.c
 - drivers/media/video/{mt9m111.c,ov6650.c}
 - drivers/mfd/ab3550-core.c
 - include/linux/dmaengine.h