linux-toradex.git/drivers/scsi/libfc/fc_fcp.c, branch v5.0

scsi: libfc: remove set but not used variable 'rpriv'

2018-09-12T00:59:11+00:00

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/scsi/libfc/fc_fcp.c: In function 'fc_queuecommand':
drivers/scsi/libfc/fc_fcp.c:1875:30: warning:
 variable 'rpriv' set but not used [-Wunused-but-set-variable]

Signed-off-by: YueHaibing 
Acked-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: libfc: remove unnecessary condition check

2018-08-30T11:36:48+00:00

kmem_cache_destroy() can handle NULL pointer correctly, so there is no
need to check NULL pointer before calling kmem_cache_destroy()

Signed-off-by: Chengguang Xu 
Acked-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE casts

2017-11-22T00:35:54+00:00

With all callbacks converted, and the timer callback prototype
switched over, the TIMER_FUNC_TYPE cast is no longer needed,
so remove it. Conversion was done with the following scripts:

    perl -pi -e 's|\(TIMER_FUNC_TYPE\)||g' \
        $(git grep TIMER_FUNC_TYPE | cut -d: -f1 | sort -u)

    perl -pi -e 's|\(TIMER_DATA_TYPE\)||g' \
        $(git grep TIMER_DATA_TYPE | cut -d: -f1 | sort -u)

The now unused macros are also dropped from include/linux/timer.h.

Signed-off-by: Kees Cook

scsi: libfc: Convert timers to use timer_setup()

2017-10-27T09:22:00+00:00

In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly. This removes several redundant setup
calls in favor of just changing the timer function directly.

Cc: Johannes Thumshirn 
Cc: "James E.J. Bottomley" 
Cc: "Martin K. Petersen" 
Cc: fcoe-devel@open-fcoe.org
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook 
Reviewed-by: Martin K. Petersen 
Acked-by: Johannes Thumshirn

scsi: fc_fcp: do not call fc_block_scsi_eh() from host reset

2017-08-25T21:21:10+00:00

When calling host reset we're resetting all ports anyway, so there is no
point in waiting for the ports to become unblocked.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: libfc: do not flood console with messages 'libfc: queue full ...'

2017-05-09T01:24:28+00:00

When the FCoE sending side becomes congested libfc tries to reduce the
queue depth on the host; however due to the built-in lag before
attempting to ramp down the queue depth _again_ the message log is
flooded with the following message:

	libfc: queue full, reducing can_queue to 512

With this patch the message is printed only once (ie when it's
actually changed).

Signed-off-by: Hannes Reinecke 
Reviewed-by: Bart Van Assche 
Acked-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: libfc: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

2017-03-15T22:44:02+00:00

refcount_t type and corresponding API should be used instead of atomic_t
when the variable is used as a reference counter. This allows to avoid
accidental refcounter overflows that might lead to use-after-free
situations.

Signed-off-by: Elena Reshetova 
Signed-off-by: Hans Liljestrand 
Signed-off-by: Kees Cook 
Signed-off-by: David Windsor 
Acked-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: libfc: Replace ->seq_start_next callback with function call

2016-11-08T22:29:56+00:00

The ->seq_start_next callback only ever had one implementation,
so call the function directly and drop the callback.

Signed-off-by: Hannes Reinecke 
Acked-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: libfc: Replace ->exch_done callback with function call

2016-11-08T22:29:56+00:00

The ->exch_done callback only ever had one implementation,
so we can as well call it directly and drop the callback.

Signed-off-by: Hannes Reinecke 
Acked-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: libfc: Replace ->seq_exch_abort callback with function call

2016-11-08T22:29:56+00:00

The ->seq_exch_abort callback only ever had one implementation,
so we can as well call it directly and drop the callback.

Signed-off-by: Hannes Reinecke 
Acked-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen