linux-toradex.git/drivers/scsi/libfc, branch v2.6.35-rc2

[SCSI] libfc: Move the port_id into lport

2010-05-17T02:22:34+00:00

This patch creates a port_id member in struct fc_lport.
This allows libfc to just deal with fc_lport instances
instead of calling into the fc_host to get the port_id.

This change helps in only using symbols necessary for
operation from the libfc structures. libfc still needs
to change the fc_host_port_id() if the port_id changes
so the presentation layer (scsi_transport_fc) can provide
the user with the correct value, but libfc shouldn't
rely on the presentation layer for operational values.

Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: Remove unused fc_get_host_port_type

2010-05-17T02:22:29+00:00

Remove this unused routine.

Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: set seq_id for incoming sequence

2010-05-17T02:22:25+00:00

After the recent patch "fixes unnecessary seq id jump"
the SCST module fcst stopped working because multi-sequence
write data wasn't finding the sequence after the first frame.

Add back the setting of the seq_id when the first frame arrives.
Also fix indentation on two lines.

Signed-off-by: Joe Eykholt 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc, fcoe: normalize format specifies for world wide names

2010-04-11T19:02:42+00:00

Print all world wide node names (node, port and fabric) with the same
format specifier of "%16.16llx".  That makes sure they all print as a
16 character hex string, with lower case letters, no 0x prefix, and
without stripping off any leading 0s.

Signed-off-by: Chris Leech 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: set both precision and field with when printing FC IDs

2010-04-11T19:02:41+00:00

Most of the prints of fabric IDs were specified as %6x, which will not
print any leading 0s.  It's nice to see leading 0s for identifiers
like this, which are a fixed length.  This patch sets the precision
modifier as well, making the specifier %6.6x, which forces the
printing of leading 0s.

Signed-off-by: Chris Leech 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: bug in erroring out upon FCP_RSP_LEN_VAL in fc_fcp_resp

2010-04-11T19:02:40+00:00

fc_fcp_resp is assuming when FCP_SNS_LEN_VAL is set, the FCP_RSP_LEN_VAL
is not, which is not true. This leads to not copying the sense data and
error out a valid FCP_RSP.

Signed-off-by: Yi Zou 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: remove unneeded variables in fc_exch_recv_req()

2010-04-11T19:02:33+00:00

fc_exch_recv_req has variables eof, sof, and f_ctl,
which are set but never used.  Delete them.

Signed-off-by: Joe Eykholt 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc, libfcoe, fcoe: use smp_processor_id() only when preempt disabled

2010-04-11T14:23:44+00:00

When the kernel is configured for preemption, using smp_processor_id()
when preemption is enabled causes a warning backtrace and is wrong
since we could move off of that CPU as soon as we get the ID,
and we would be referencing the wrong CPU, and possibly an invalid one
if it could be hotswapped out.

Remove the fc_lport_get_stats() function and explicitly use per_cpu_ptr()
to get the statistics.  Where preemption has been disabled by holding
a _bh lock continue to use smp_processor_id(), but otherwise use
get_cpu()/put_cpu().

In fcoe_recv_frame() also changed the cases where we return in the
middle to do a goto to the code which bumps ErrorFrames and does
a put_cpu().  Two of these cases didn't bump ErrorFrames before, but
doing so is harmless because they "can't happen", due to prior length
checks.

Also rearranged code in fcoe_recv_frame() to have only one call to
fc_exch_recv().  It's just as efficient and saves a call to put_cpu().

In fc_fcp.c, adjusted a FIXME comment for code which doesn't need fixing.

Signed-off-by: Joe Eykholt 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: Add debug statements when fc_fcp returns DID_ERROR to scsi-ml

2010-04-11T14:23:44+00:00

DID_ERROR cases can be ambigouos. Debugging FCP error cases
will be much easier if we have debug statements when we hit
these error conditions.

This patch simply adds debug messages using the FC_FCP_DBG
macro when we return DID_ERROR to SCSI. This way if a DID_ERROR
is reproducible turning on debug_logging will give a clue
to developers as to what the problem might be.

Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: fix fcp pkt recovery in fc_fcp_recv_data

2010-04-11T14:23:42+00:00

Currently fc_fcp_recv_data calls fc_fcp_retry_cmd to
retry failed IO but in this case tgt is still sending
data frames, therefore exchange needs to be aborted
first before initiating retry. So this patch fixes
this by aborting exchange first then have retry.

Renames fc_timeout_error to fc_fcp_recovery since
fc_timeout_error is already called from several other
places beside from fcp timeout handler and then
used fc_fcp_recovery for abort & retry from
fc_fcp_recv_data, this rename also required renaming
FC_CMD_TIME_OUT status to FC_CMD_RECOVERY to be
consistent with new fc_fcp_recovery.

Data frames are not expected for an DDPed exchange and
potentially it could be tampered data frame, so does
recovery in this case by calling fc_fcp_recovery.

Signed-off-by: Vasu Dev 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley