linux-toradex.git/drivers/scsi/libsas, branch v3.6.1

[SCSI] async: introduce 'async_domain' type

2012-07-20T08:05:54+00:00

This is in preparation for teaching async_synchronize_full() to sync all
pending async work, and not just on the async_running domain.  This
conversion is functionally equivalent, just embedding the existing list
in a new async_domain type.

The .registered attribute is used in a later patch to distinguish
between domains that want to be flushed by async_synchronize_full()
versus those that only expect async_synchronize_{full|cookie}_domain to
be used for flushing.

[jejb: add async.h to scsi_priv.h for struct async_domain]
Signed-off-by: Dan Williams 
Acked-by: Arjan van de Ven 
Acked-by: Mark Brown 
Tested-by: Eldad Zack 
Signed-off-by: James Bottomley

[SCSI] libsas: trim sas_task of slow path infrastructure

2012-07-20T07:58:54+00:00

The timer and the completion are only used for slow path tasks (smp, and
lldd tmfs), yet we incur the allocation space and cpu setup time for
every fast path task.

Cc: Xiangliang Yu 
Acked-by: Jack Wang 
Signed-off-by: Dan Williams 
Signed-off-by: James Bottomley

[SCSI] libsas: drop sata port multiplier infrastructure

2012-07-20T07:58:53+00:00

On the way to add a new sata_device field, noticed that libsas is
carrying port multiplier infrastructure that is explicitly disabled by
sas_discover_sata().  The aic94xx touches the unused port_no, so leave
that field in case there was some use for it.

Signed-off-by: Dan Williams 
Signed-off-by: James Bottomley

[SCSI] libsas: fix sas_discover_devices return code handling

2012-07-20T07:58:53+00:00

commit 198439e4 [SCSI] libsas: do not set res = 0 in sas_ex_discover_dev()
commit 19252de6 [SCSI] libsas: fix wide port hotplug issues

The above commits seem to have confused the return value of
sas_ex_discover_dev which is non-zero on failure and
sas_ex_join_wide_port which just indicates short circuiting discovery on
already established ports.  The result is random discovery failures
depending on configuration.

Calls to sas_ex_join_wide_port are the source of the trouble as its
return value is errantly assigned to 'res'.  Convert it to bool and stop
returning its result up the stack.

Cc: 
Tested-by: Dan Melnic 
Reported-by: Dan Melnic 
Signed-off-by: Dan Williams 
Reviewed-by: Jack Wang 
Signed-off-by: James Bottomley

[SCSI] libsas: continue revalidation

2012-07-20T07:58:52+00:00

Continue running revalidation until no more broadcast devices are
discovered.  Fixes cases where re-discovery completes too early in a
domain with multiple expanders with pending re-discovery events.
Servicing BCNs can get backed up behind error recovery.

Cc: 
Signed-off-by: Dan Williams 
Signed-off-by: James Bottomley

[SCSI] libsas: sas_rediscover_dev did not look at the SMP exec status.

2012-07-20T07:58:52+00:00

The discovery function "sas_rediscover_dev" had two bugs: 1) it did
not pay attention to the return status from the SMP task execution;
2) the stack variable used for the returned SAS address was compared
against 0 without being initialized.

Signed-off-by: Jeff Skirvin 
Signed-off-by: Dan Williams 
Signed-off-by: James Bottomley

[SCSI] libsas: use ->lldd_I_T_nexus_reset for ->eh_bus_reset_handler

2012-07-20T07:58:51+00:00

sas_eh_bus_reset_handler() amounts to sas_phy_reset() without
notification of the reset to the lldd.  If this is triggered from
eh-cmnd recovery there may be sas_tasks for the lldd to terminate, so
->lldd_I_T_nexus_reset is warranted.

Cc: Xiangliang Yu 
Cc: Luben Tuikov 
Cc: Jack Wang 
Reviewed-by: Jacek Danecki 
[jacek: modify pm8001_I_T_nexus_reset to return -ENODEV]
Signed-off-by: Dan Williams 
Signed-off-by: James Bottomley

[SCSI] libsas: add sas_eh_abort_handler

2012-07-20T07:58:50+00:00

When recovering failed eh-cmnds let the lldd attempt an abort via
scsi_abort_eh_cmnd before escalating.

Reviewed-by: Jacek Danecki 
Signed-off-by: Dan Williams 
Signed-off-by: James Bottomley

[SCSI] libsas: enforce eh strategy handlers only in eh context

2012-07-20T07:58:50+00:00

The strategy handlers may be called in places that are problematic for
libsas (i.e. sata resets outside of domain revalidation filtering /
libata link recovery), or problematic for userspace (non-blocking ioctl
to sleeping reset functions).  However, these routines are also called
for eh escalations and recovery of scsi_eh_prep_cmnd(), so permit them
as long as we are running in the host's error handler, otherwise arrange
for them to be triggered in eh_context.

Signed-off-by: Dan Williams 
Signed-off-by: James Bottomley

[SCSI] libsas: cleanup spurious calls to scsi_schedule_eh

2012-07-20T07:58:47+00:00

eh is woken up automatically by the presence of failed commands,
scsi_schedule_eh is reserved for cases where there are no failed
commands.  This guarantees that host_eh_sceduled is only incremented
when an explicit eh request is made.

Reviewed-by: Jacek Danecki 
Signed-off-by: Maciej Trela 
[fixed spurious delete of sas_ata_task_abort]
Signed-off-by: Artur Wojcik 
Signed-off-by: Dan Williams 
Signed-off-by: James Bottomley