linux-toradex.git/drivers/scsi/pm8001, branch v4.9.97

scsi: pm8001: Mark symbols static where possible

2016-09-27T01:10:45+00:00

We get 2 warnings when building kernel with W=1:
drivers/scsi/pm8001/pm8001_sas.c:530:23: warning: no previous prototype for 'pm8001_alloc_dev' [-Wmissing-prototypes]
drivers/scsi/pm8001/pm8001_hwi.c:4495:5: warning: no previous prototype for 'pm8001_chip_phy_stop_req' [-Wmissing-prototypes]

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.  So this
patch marks these functions with 'static'.

Signed-off-by: Baoyou Xie 
Acked-by: Lindar Liu 
Signed-off-by: Martin K. Petersen

pm8001: fix typo

2016-07-13T03:16:31+00:00

firmare -> firmware

Signed-off-by: Julia Lawall 
Acked-by: Jack Wang 
Signed-off-by: Martin K. Petersen

libata/libsas: Define ATA_CMD_NCQ_NON_DATA

2016-05-09T16:36:44+00:00

Define the NCQ NON DATA command and update libsas to handle it
correctly.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Tejun Heo

libsas: enable FPDMA SEND/RECEIVE

2016-05-09T16:36:44+00:00

Update libsas and dependent drivers to handle FPDMA
SEND/RECEIVE correctly.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Tejun Heo

pm80xx: Remove bogus address masking in pm8001_ioremap()

2016-04-15T20:53:18+00:00

It is unclear what the original intent of the masking was, but it is
clearly incorrect to truncate a physical address before calling
ioremap().  On systems where there are valid physical address bits above
bit-31 (arm64 for example) the result is an eventual OOPs when
initializing the driver.

Remove the bogus code to fix it.

Signed-off-by: David Daney 
Acked-by: Jack Wang 
Signed-off-by: Martin K. Petersen

Merge tag '4.4-scsi-mkp' into misc

2015-11-12T12:06:18+00:00

SCSI queue for 4.4.

Signed-off-by: Martin K. Petersen

scsi: use host wide tags by default

2015-11-10T01:11:57+00:00

This patch changes the !blk-mq path to the same defaults as the blk-mq
I/O path by always enabling block tagging, and always using host wide
tags.  We've had blk-mq available for a few releases so bugs with
this mode should have been ironed out, and this ensures we get better
coverage of over tagging setup over different configs.

Signed-off-by: Christoph Hellwig 
Acked-by: Jens Axboe 
Reviewed-by: Hannes Reinecke 
Signed-off-by: James Bottomley

pm80xx: remove the SCSI host before detaching from SAS transport

2015-11-10T00:41:31+00:00

Previously, when this module was unloaded via 'rmmod' with at least one
drive attached, the SCSI error handler thread would become stuck in an
infinite recovery loop and lockup the system, necessitating a reboot.

Once the SAS layer is detached, the driver will fail any subsequent
commands since the target devices are removed.  However, removing the
SCSI host generates a SYNCHRONIZE CACHE (10) command, which was failed
and left the error handler no method of recovery.

This patch simply removes the SCSI host first so that no more commands
can come down, prior to cleaning up the SAS layer.  Note that the stack
is built up with the SCSI host first, and then the SAS layer.  Perhaps
it should be reversed for symmetry, so that commands cannot be sent to
the pm80xx driver prior to attaching the SAS layer?

What was really strange about this bug was that it was introduced at
commit cff549e4860f ("[SCSI]: proper state checking and module refcount
handling in scsi_device_get").  This commit appears to tinker with how
the reference counting is performed for SCSI device objects.  My theory
is that prior to this commit, the refcount for a device object was
blindly incremented at some point during the teardown process which
coincidentially made the device stick around during the procedure, which
also coincidentially made any commands sent to the driver not fail
(since the device was technically still "there").  After this commit was
applied, my theory is the refcount for the device object is not being
incremented at a specific point anymore, which makes the device go away,
and thus made the pm80xx driver fail any subsequent commands.

You may also want to see the following for more details:

[1] http://www.spinics.net/lists/linux-scsi/msg37208.html
[2] http://marc.info/?l=linux-scsi&m=144416476406993&w=2

Signed-off-by: Benjamin Rood 
Acked-by: Jack Wang 
Signed-off-by: Martin K. Petersen

pm80xx: avoid a panic if MSI(X) interrupts are disabled

2015-11-03T04:41:13+00:00

If MSI(X) interrupts are disabled via the kernel command line
(pci=nomsi), the pm8001 driver will kernel panic because it does not
detect that MSI interrupts are disabled and will soldier on and attempt to
configure MSI interrupts anyways.  This leads to a kernel panic, most
likely because a required data structure is not available down the
line.  Using the pci_msi_enabled() function in order to detect if MSI
interrupts are enabled before configuring them resolves this issue and
avoids a kernel panic when the module is loaded.  Additionally, the
irq_vector structure must be initialized when legacy interrupts are
being used otherwise legacy interrupts will simply not function and
result in another panic.

Signed-off-by: Benjamin Rood 
Reviewed-by: Jack Wang 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

pm80xx: wait a minimum of 500ms before issuing commands to SPCv

2015-11-03T04:40:35+00:00

The documentation for the 8070 and 8072 SPCv chip explicitly states that
a minimum of 500ms must elapse before issuing commands, otherwise the
SPCv may not process them and the firmware may get into an unrecoverable
state requiring a reboot.  While the Linux guys will probably think this
is 'racy', it is called out in the chip documentation and inserting this
delay makes power management function properly.

Signed-off-by: Benjamin Rood 
Reviewed-by: Jack Wang 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen