linux-toradex.git/drivers/scsi/scsi.c, branch colibri_vf

SCSI host lock push-down

2010-11-16T21:33:23+00:00

Move the mid-layer's ->queuecommand() invocation from being locked
with the host lock to being unlocked to facilitate speeding up the
critical path for drivers who don't need this lock taken anyway.

The patch below presents a simple SCSI host lock push-down as an
equivalent transformation.  No locking or other behavior should change
with this patch.  All existing bugs and locking orders are preserved.

Additionally, add one parameter to queuecommand,
	struct Scsi_Host *
and remove one parameter from queuecommand,
	void (*done)(struct scsi_cmnd *)

Scsi_Host* is a convenient pointer that most host drivers need anyway,
and 'done' is redundant to struct scsi_cmnd->scsi_done.

Minimal code disturbance was attempted with this change.  Most drivers
needed only two one-line modifications for their host lock push-down.

Signed-off-by: Jeff Garzik 
Acked-by: James Bottomley 
Signed-off-by: Linus Torvalds

[SCSI] Fix VPD inquiry page wrapper

2010-09-16T15:48:48+00:00

Fix two bugs in the VPD page wrapper:

    - Don't return failure if the user asked for page 0

    - The end of buffer check failed to account for the page header size
      and consequently didn't work

Signed-off-by: Martin K. Petersen 
Cc: Stable Tree 
Signed-off-by: James Bottomley

[SCSI] add scsi trace core functions and put trace points

2010-04-30T17:51:10+00:00

Signed-off-by: Xiao Guangrong 
Signed-off-by: Tomohiro Kusumi 
Signed-off-by: Kei Tokunaga 
Signed-off-by: James Bottomley

scsi.c: add missing kernel-doc notation for new VPD parameters

2010-03-01T16:11:54+00:00

Add missing kernel-doc notation for new function parameters:

Warning(drivers/scsi/scsi.c:1031): No description found for parameter 'buf'
Warning(drivers/scsi/scsi.c:1031): No description found for parameter 'buf_len'

Signed-off-by: Randy Dunlap 
Cc: James Bottomley 
Signed-off-by: Linus Torvalds

[SCSI] eliminate potential kmalloc failure in scsi_get_vpd_page()

2010-01-18T16:48:05+00:00

The best way to fix this is to eliminate the intenal kmalloc() and
make the caller allocate the required amount of storage.

Signed-off-by: James Bottomley

[SCSI] add queue_depth ramp up code

2009-12-04T18:00:44+00:00

Current FC HBA queue_depth ramp up code depends on last queue
full time. The sdev already  has last_queue_full_time field to
track last queue full time but stored value is truncated by
last four bits.

So this patch updates last_queue_full_time without truncating
last 4 bits to store full value and then updates its only
current usages in scsi_track_queue_full to ignore last four bits
to keep current usages same while also use this field
in added ramp up code.

Adds scsi_handle_queue_ramp_up to ramp up queue_depth on
successful completion of IO. The scsi_handle_queue_ramp_up will
do ramp up on all luns of a target, just same as ramp down done
on all luns on a target.

The ramp up is skipped in case the change_queue_depth is not
supported by LLD or already reached to added max_queue_depth.

Updates added max_queue_depth on every new update to default
queue_depth value.

The ramp up is also skipped if lapsed time since either last
queue ramp up or down is less than LLD specified
queue_ramp_up_period.

Adds queue_ramp_up_period to sysfs but only if change_queue_depth
is supported since ramp up and queue_ramp_up_period is needed only
in case change_queue_depth is supported first.

Initializes queue_ramp_up_period to 120HZ jiffies as initial
default value, it is same as used in existing lpfc and qla2xxx.

-v2
 Combined all ramp code into this single patch.

-v3
 Moves max_queue_depth initialization after slave_configure is
called from after slave_alloc calling done. Also adjusted
max_queue_depth check to skip ramp up if current queue_depth
is >= max_queue_depth.

-v4
 Changes sdev->queue_ramp_up_period unit to ms when using sysfs i/f
to store or show its value.

Signed-off-by: Vasu Dev 
Tested-by: Christof Schmitt 
Tested-by: Giridhar Malavali 
Signed-off-by: James Bottomley

[SCSI] Fix protection scsi_data_buffer leak

2009-10-02T14:46:52+00:00

We would leak a scsi_data_buffer if the free_list command was of the
protected variety.

Reported-by: Boaz Harrosh 
Signed-off-by: Martin K. Petersen 
Cc: Stable Tree 
Signed-off-by: James Bottomley

[SCSI] fix bugs in scsi_vpd_inquiry()

2009-08-22T22:52:23+00:00

Universally, SCSI functions assume the lengths fed in are those of the buffer
to DMA data to, not the lengths of the data minus the header.
scsi_vpd_inquiry() assumed the latter and got it wrong, so fix up all the
functions to use the correct assumption (and fix a bug where INQUIRY in SCSI-2
dcannot go over 255).


[jejb: Matthew posted an identical version of this at the same time I did]
Signed-off-by: Matthew Wilcox 
Signed-off-by: James Bottomley

[SCSI] fix documentation for two functions

2009-06-08T17:23:35+00:00

Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: James Bottomley

[SCSI] use kmem_cache_zalloc instead of kmem_cache_alloc/memset

2009-04-03T15:16:31+00:00

Signed-off-by: Wei Yongjun 
Signed-off-by: Andrew Morton 
Signed-off-by: James Bottomley