linux-toradex.git/drivers/scsi/scsi.c, branch v4.18-rc4

scsi: core: fix two wrong indentation cases

2018-02-28T03:26:12+00:00

No functional changes. Just fix two wrong indentation cases in
scsi_finish_command and scsi_decide_disposition.

Signed-off-by: Jianchao Wang 
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

Merge branch 'fixes' into misc

2017-09-07T19:12:43+00:00

scsi: Rework handling of scsi_device.vpd_pg8[03]

2017-08-30T01:51:42+00:00

Introduce struct scsi_vpd for the VPD page length, data and the RCU head
that will be used to free the VPD data. Use kfree_rcu() instead of
kfree() to free VPD data. Move the VPD buffer pointer check inside the
RCU read lock in the sysfs code. Only annotate pointers that are shared
across threads with __rcu. Use rcu_dereference() when dereferencing an
RCU pointer. This patch suppresses about twenty sparse complaints about
the vpd_pg8[03] pointers. This patch also fixes a race condition, namely
that updating of the VPD pointers and length variables in struct
scsi_device was not atomic with reference to the code reading these
variables. See also "Does the update code tolerate concurrent accesses?"
in Documentation/RCU/checklist.txt.

Fixes: commit 09e2b0b14690 ("scsi: rescan VPD attributes")
Signed-off-by: Bart Van Assche 
Acked-by: Hannes Reinecke 
Reviewed-by: Shane Seymour 
Cc: Christoph Hellwig 
Cc: Johannes Thumshirn 
Cc: Shane Seymour 
Signed-off-by: Martin K. Petersen

scsi: Rework the code for caching Vital Product Data (VPD)

2017-08-30T01:51:42+00:00

Introduce the scsi_get_vpd_buf() and scsi_update_vpd_page()
functions. The only functional change in this patch is that if updating
page 0x80 fails that it is attempted to update page 0x83.

Signed-off-by: Bart Van Assche 
Acked-by: Hannes Reinecke 
Reviewed-by: Shane Seymour 
Cc: Christoph Hellwig 
Cc: Johannes Thumshirn 
Cc: Shane M Seymour 
Signed-off-by: Martin K. Petersen

Revert "scsi: default to scsi-mq"

2017-08-17T00:01:32+00:00

Defaulting to scsi-mq in 4.13-rc has shown various regressions
on setups that we didn't previously consider.  Fixes for them are
in progress, but too invasive to make it in this cycle.  So for
now revert the commit that defaults to blk-mq for SCSI.  For 4.14
we'll plan to try again with these fixes.

This reverts commit 5c279bd9e40624f4ab6e688671026d6005b066fa.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: default to scsi-mq

2017-06-28T01:31:12+00:00

Remove the SCSI_MQ_DEFAULT config option and default to the blk-mq I/O
path now that we had plenty of testing, and have I/O schedulers for
blk-mq.  The module option to disable the blk-mq path is kept around for
now.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: Only add commands to the device command list if required by the LLD

2017-06-13T00:55:59+00:00

Just like for the scsi-mq code path, in the single queue SCSI code path
only add commands to the per-device command list if required by the SCSI
LLD. This patch will make it easier to merge the single-queue and
multiqueue command initialization code.

Signed-off-by: Bart Van Assche 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Cc: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: Skip deleted devices in __scsi_device_lookup

2017-05-09T01:36:06+00:00

When a device is unplugged from a SCSI controller, if the scsi_device is
still in use by application layer, it won't get released until users
close it.

In this case, scsi_device_remove just set the scsi_device's state to be
SDEV_DEL. But if you plug the disk just before the old scsi_device is
released, then there will be two scsi_device structures in
scsi_host->__devices. When the next unplug event happens, some low-level
drivers will check whether the scsi_device has been added to host (for
example the MegaRAID SAS series controller) by calling
scsi_device_lookup(call __scsi_device_lookup) in function
megasas_aen_polling. __scsi_device_lookup will return the first
scsi_device. Because its state is SDEV_DEL, the scsi_device_lookup will
return NULL, making the low-level driver assume that the scsi_device has
been removed, and won't call scsi_device_remove which will lead to hot
swap failure.

Signed-off-by: Zhou Zhengping 
Tested-by: Zeng Rujia 
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=195607
Reviewed-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

block: introduce blk_rq_is_passthrough

2017-01-31T21:00:34+00:00

This can be used to check for fs vs non-fs requests and basically
removes all knowledge of BLOCK_PC specific from the block layer,
as well as preparing for removing the cmd_type field in struct request.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

scsi: allocate scsi_cmnd structures as part of struct request

2017-01-27T22:08:35+00:00

Rely on the new block layer functionality to allocate additional driver
specific data behind struct request instead of implementing it in SCSI
itѕelf.

Signed-off-by: Christoph Hellwig 
Acked-by: Martin K. Petersen 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Jens Axboe