linux-toradex.git/drivers/scsi/scsi_debug.c, branch v4.3

scsi_debug: resp_request: remove unused variable

2015-09-06T18:03:14+00:00

Fixes the following warning

In function ‘resp_requests’:
drivers/scsi//scsi_debug.c:1432:15: warning: variable ‘want_dsense’ set
but not used [-Wunused-but-set-variable]
  bool dsense, want_dsense;

Signed-off-by: Tomas Winkler 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

scsi_debug: fix REPORT LUNS Well Known LU

2015-09-06T18:02:41+00:00

The use case to report 'REPORT LUNS WLUN' described
in scsi_debug documentation didn't work because:
scsi_scan_host_selected() checks for:
	 lun < shost->max_lun

To fix this we set:
	max_lun = SCSI_W_LUN_REPORT_LUNS + 1;

Signed-off-by: Tomas Winkler 
Acked-by: Douglas Gilbert 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

scsi_debug: schedule_resp fix input variable check

2015-09-06T18:02:04+00:00

The function should never be called with cmnd NULL so
put a fat WARN there.
Fix also smatch wraning:
schedule_resp() warn: variable dereferenced before check 'cmnd'

Signed-off-by: Tomas Winkler 
Acked-by: Douglas Gilbert 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

scsi_debug: make dump_sector static

2015-09-06T18:01:18+00:00

fixes warning:
warning: no previous prototype for ‘dump_sector’

Signed-off-by: Tomas Winkler 
Acked-by: Douglas Gilbert 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

scsi_debug: vfree is null safe so drop the check

2015-09-06T18:00:16+00:00

Signed-off-by: Tomas Winkler 
Acked-by: Douglas Gilbert 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

scsi_debug: use SCSI_W_LUN_REPORT_LUNS instead of SAM2_WLUN_REPORT_LUNS;

2015-09-06T17:59:23+00:00

use SCSI_W_LUN_REPORT_LUNS from scsi.h instead of localy defined
SAM2_WLUN_REPORT_LUNS

Signed-off-by: Tomas Winkler 
Acked-by: Douglas Gilbert 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

scsi_debug: define pr_fmt() for consistent logging

2015-09-06T17:58:38+00:00

Use pr_fmt with both module name and __func__
Also drop few bare printk leftovers

The log format should stay pretty much intact

Signed-off-by: Tomas Winkler 
Acked-by: Douglas Gilbert 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

drivers/scsi/scsi_debug.c: resolve sg buffer const-ness issue

2015-07-01T02:44:59+00:00

do_device_access() takes a separate parameter to indicate the direction of
data transfer, which it used to use to select the appropriate function out
of sg_pcopy_{to,from}_buffer().  However these two functions now have

So this patch makes it bypass these wrappers and call the underlying
function sg_copy_buffer() directly; this has the same calling style as
do_device_access() i.e.  a separate direction-of-transfer parameter and no
pointers-to-const, so skipping the wrappers not only eliminates the
warning, it also make the code simpler :)

[akpm@linux-foundation.org: fix very broken build]
Signed-off-by: Dave Gordon 
Acked-by: Arnd Bergmann 
Cc: James Bottomley 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

scsi: use %*pb[l] to print bitmaps including cpumasks and nodemasks

2015-02-14T05:21:38+00:00

printk and friends can now format bitmaps using '%*pb[l]'.  cpumask
and nodemask also provide cpumask_pr_args() and nodemask_pr_args()
respectively which can be used to generate the two printf arguments
necessary to format the specified cpu/nodemask.

* map_show()'s return value is too high by one and the function could
  modify beyond the end of the buffer when the formatted text is long
  enough.

Signed-off-by: Tejun Heo 
Cc: "James E.J. Bottomley" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi

2015-02-11T18:28:45+00:00

Pull first round of SCSI updates from James Bottomley:
 "This is the usual grab bag of driver updates (hpsa, storvsc, mp2sas,
  megaraid_sas, ses) plus an assortment of minor updates.

  There's also an update to ufs which adds new phy drivers and finally a
  new logging infrastructure for SCSI"

* tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi: (114 commits)
  scsi_logging: return void for dev_printk() functions
  scsi: print single-character strings with seq_putc
  scsi: merge consecutive seq_puts calls
  scsi: replace seq_printf with seq_puts
  aha152x: replace seq_printf with seq_puts
  advansys: replace seq_printf with seq_puts
  scsi: remove SPRINTF macro
  sg: remove an unused variable
  hpsa: Use local workqueues instead of system workqueues
  hpsa: add in P840ar controller model name
  hpsa: add in gen9 controller model names
  hpsa: detect and report failures changing controller transport modes
  hpsa: shorten the wait for the CISS doorbell mode change ack
  hpsa: refactor duplicated scan completion code into a new routine
  hpsa: move SG descriptor set-up out of hpsa_scatter_gather()
  hpsa: do not use function pointers in fast path command submission
  hpsa: print CDBs instead of kernel virtual addresses for uncommon errors
  hpsa: do not use a void pointer for scsi_cmd field of struct CommandList
  hpsa: return failed from device reset/abort handlers
  hpsa: check for ctlr lockup after command allocation in main io path
  ...