linux-toradex.git/drivers/scsi/scsi_debug.c, branch v4.5

Merge branch 'jejb-scsi' into misc

2016-01-07T23:51:13+00:00

scsi_debug: Increase the reported optimal transfer length

2015-12-22T03:14:47+00:00

The OPTIMAL TRANSFER LENGTH reported by scsi_debug is 64 blocks which
translates to 32KB with the default logical block size. That's much
lower than what real storage devices typically report (256KB to 1MB).

Bump the optimal transfer length to 1024 blocks.

Acked-by: Douglas Gilbert 
Reviewed-by: Ewan Milne 
Signed-off-by: Martin K. Petersen

scsi_debug: check for bigger value first

2015-11-30T17:12:19+00:00

Even for signed types we have to check for bigger positive value first.
Otherwise it will be never happened.

Signed-off-by: Andy Shevchenko 
Acked-by: Douglas Gilbert 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Ewan Milne 
Signed-off-by: Martin K. Petersen

scsi: use sector_div instead of do_div

2015-11-26T03:17:02+00:00

do_div is the wrong way to divide a sector_t, as it is less efficient
when sector_t is 32-bit wide. With the upcoming do_div optimizations,
the kernel starts warning about this:

drivers/scsi/scsi_debug.c: In function 'dif_store':
include/asm-generic/div64.h:207:28: warning: comparison of distinct pointer types lacks a cast

This changes the code to use sector_div instead, which always produces
optimal code.

Signed-off-by: Arnd Bergmann 
Reviewed-by: Hannes Reinicke 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi_debug: fix prevent_allow+verify regressions

2015-11-26T02:38:53+00:00

Ruediger Meier observed a regression with the PREVENT ALLOW MEDIUM
REMOVAL command in lk 3.19:

	http://www.spinics.net/lists/util-linux-ng/msg11448.html

Inspection indicated the same regression with VERIFY(10).

The patch is against lk 3.19.3 and also works with lk 4.3.0 .  With this
patch both commands are accepted and do nothing.

ChangeLog:

 - fix the lk 3.19 regression so that the PREVENT ALLOW MEDIUM REMOVAL
   command is supported once again

 - same fix for VERIFY(10)

Signed-off-by: Douglas Gilbert 
Reviewed-by: Hannes Reinicke 
Reviewed-by: Ewan Milne 
Signed-off-by: Martin K. Petersen

scsi_debug: resp_request: remove unused variable

2015-09-06T18:03:14+00:00

Fixes the following warning

In function ‘resp_requests’:
drivers/scsi//scsi_debug.c:1432:15: warning: variable ‘want_dsense’ set
but not used [-Wunused-but-set-variable]
  bool dsense, want_dsense;

Signed-off-by: Tomas Winkler 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

scsi_debug: fix REPORT LUNS Well Known LU

2015-09-06T18:02:41+00:00

The use case to report 'REPORT LUNS WLUN' described
in scsi_debug documentation didn't work because:
scsi_scan_host_selected() checks for:
	 lun < shost->max_lun

To fix this we set:
	max_lun = SCSI_W_LUN_REPORT_LUNS + 1;

Signed-off-by: Tomas Winkler 
Acked-by: Douglas Gilbert 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

scsi_debug: schedule_resp fix input variable check

2015-09-06T18:02:04+00:00

The function should never be called with cmnd NULL so
put a fat WARN there.
Fix also smatch wraning:
schedule_resp() warn: variable dereferenced before check 'cmnd'

Signed-off-by: Tomas Winkler 
Acked-by: Douglas Gilbert 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

scsi_debug: make dump_sector static

2015-09-06T18:01:18+00:00

fixes warning:
warning: no previous prototype for ‘dump_sector’

Signed-off-by: Tomas Winkler 
Acked-by: Douglas Gilbert 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley

scsi_debug: vfree is null safe so drop the check

2015-09-06T18:00:16+00:00

Signed-off-by: Tomas Winkler 
Acked-by: Douglas Gilbert 
Reviewed-by: Martin K. Petersen 
Signed-off-by: James Bottomley