linux-toradex.git/drivers/scsi/scsi_lib.c, branch v4.9.57

scsi: use 'scsi_device_from_queue()' for scsi_dh

2017-03-12T05:41:45+00:00

commit 857de6e00778738dc3d61f75acbac35bdc48e533 upstream.

The device handler needs to check if a given queue belongs to a scsi
device; only then does it make sense to attach a device handler.

[mkp: dropped flags]

Signed-off-by: Hannes Reinecke 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen 
Signed-off-by: Greg Kroah-Hartman

scsi: don't BUG_ON() empty DMA transfers

2017-02-23T16:44:35+00:00

commit fd3fc0b4d7305fa7246622dcc0dec69c42443f45 upstream.

Don't crash the machine just because of an empty transfer. Use WARN_ON()
combined with returning an error.

Found by Dmitry Vyukov and syzkaller.

[ Changed to "WARN_ON_ONCE()". Al has a patch that should fix the root
  cause, but a BUG_ON() is not acceptable in any case, and a WARN_ON()
  might still be a cause of excessive log spamming.

  NOTE! If this warning ever triggers, we may end up leaking resources,
  since this doesn't bother to try to clean the command up. So this
  WARN_ON_ONCE() triggering does imply real problems. But BUG_ON() is
  much worse.

  People really need to stop using BUG_ON() for "this shouldn't ever
  happen". It makes pretty much any bug worse.     - Linus ]

Signed-off-by: Johannes Thumshirn 
Reported-by: Dmitry Vyukov 
Cc: James Bottomley 
Cc: Al Viro 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

blk-mq: remove ->map_queue

2016-09-15T14:42:03+00:00

All drivers use the default, so provide an inline version of it.  If we
ever need other queue mapping we can add an optional method back,
although supporting will also require major changes to the queue setup
code.

This provides better code generation, and better debugability as well.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Keith Busch 
Signed-off-by: Jens Axboe

scsi_lib: correctly retry failed zero length REQ_TYPE_FS commands

2016-05-22T18:52:45+00:00

When SCSI was written, all commands coming from the filesystem
(REQ_TYPE_FS commands) had data.  This meant that our signal for needing
to complete the command was the number of bytes completed being equal to
the number of bytes in the request.  Unfortunately, with the advent of
flush barriers, we can now get zero length REQ_TYPE_FS commands, which
confuse this logic because they satisfy the condition every time.  This
means they never get retried even for retryable conditions, like UNIT
ATTENTION because we complete them early assuming they're done.  Fix
this by special casing the early completion condition to recognise zero
length commands with errors and let them drop through to the retry code.

Cc: stable@vger.kernel.org
Reported-by: Sebastian Parschauer 
Signed-off-by: James E.J. Bottomley 
Tested-by: Jack Wang 
Signed-off-by: Martin K. Petersen

scsi_lib: Decode T10 vendor IDs

2016-05-11T01:34:16+00:00

Some arrays / HBAs will only present T10 vendor IDs, so we should be
decoding them, too.

[mkp: Fixed T10 spelling]

Suggested-by: Paul Mackerras 
Signed-off-by: Hannes Reinecke 
Tested-by: Paul Mackerras 
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c

2016-04-15T20:53:14+00:00

Now it's ready to move the mempool based SG chained allocator code from
SCSI driver to lib/sg_pool.c, which will be compiled only based on a Kconfig
symbol CONFIG_SG_POOL.

SCSI selects CONFIG_SG_POOL.

Reviewed-by: Christoph Hellwig 
Signed-off-by: Ming Lin 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Martin K. Petersen

scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS

2016-04-15T20:53:14+00:00

Rename SCSI_MAX_SG_SEGMENTS to SG_CHUNK_SIZE, which means the amount
we fit into a single scatterlist chunk.

Rename SCSI_MAX_SG_CHAIN_SEGMENTS to SG_MAX_SEGMENTS.

Will move these 2 generic definitions to scatterlist.h later.

Reviewed-by: Christoph Hellwig 
Acked-by: Bart Van Assche  (for ib_srp changes)
Signed-off-by: Ming Lin 
Acked-by: Tejun Heo 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Martin K. Petersen

scsi: rename SG related struct and functions

2016-04-15T20:53:13+00:00

Rename SCSI specific struct and functions to more genenic names.

Reviewed-by: Christoph Hellwig 
Signed-off-by: Ming Lin 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Martin K. Petersen

scsi: replace "mq" with "first_chunk" in SG functions

2016-04-15T20:53:13+00:00

Parameter "bool mq" is block driver specific.
Change it to "first_chunk" to make it more generic.

Reviewed-by: Christoph Hellwig 
Signed-off-by: Ming Lin 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Martin K. Petersen

scsi: replace "scsi_data_buffer" with "sg_table" in SG functions

2016-04-15T20:53:12+00:00

Replace parameter "struct scsi_data_buffer" with "struct sg_table" in
SG alloc/free functions to make them generic.

Reviewed-by: Christoph Hellwig 
Signed-off-by: Ming Lin 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Martin K. Petersen