linux-toradex.git/drivers/scsi/scsi_logging.c, branch v7.0-rc2

scsi: core: Do not declare scsi_cmnd pointers const

2025-10-22T01:11:35+00:00

This change allows removing multiple casts and hence improves type
checking by the compiler.

Cc: Hannes Reinecke 
Suggested-by: John Garry 
Signed-off-by: Bart Van Assche 
Reviewed-by: John Garry 
Link: https://patch.msgid.link/20251014220426.3690007-1-bvanassche@acm.org
Signed-off-by: Martin K. Petersen

scsi: core: scsi_logging: Fix a BUG

2022-03-30T03:29:19+00:00

The request_queue may be NULL in a request, for example when it comes from
scsi_ioctl_reset(). Check it before use.

Fixes: f3fa33acca9f ("block: remove the ->rq_disk field in struct request")
Link: https://lore.kernel.org/r/20220324134603.28463-1-thenzl@redhat.com
Reported-by: Changhui Zhong 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Tomas Henzl 
Signed-off-by: Martin K. Petersen

scsi: core: Remove the cmd field from struct scsi_request

2022-03-02T03:21:49+00:00

Now that each scsi_request is backed by a scsi_cmnd, there is no need to
indirect the CDB storage.  Change all submitters of SCSI passthrough
requests to store the CDB information directly in the scsi_cmnd, and while
doing so allocate the full 32 bytes that cover all Linux supported SCSI
hosts instead of requiring dynamic allocation for > 16 byte CDBs.  On
64-bit systems this does not change the size of the scsi_cmnd at all, while
on 32-bit systems it slightly increases it for now, but that increase will
be made up by the removal of the remaining scsi_request fields.

Link: https://lore.kernel.org/r/20220224175552.988286-4-hch@lst.de
Reviewed-by: Bart Van Assche 
Reviewed-by: John Garry 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

block: remove the ->rq_disk field in struct request

2021-11-29T13:41:29+00:00

Just use the disk attached to the request_queue instead.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Chaitanya Kulkarni 
Reviewed-by: Martin K. Petersen 
Link: https://lore.kernel.org/r/20211126121802.2090656-4-hch@lst.de
Signed-off-by: Jens Axboe

scsi: core: Use scsi_cmd_to_rq() instead of scsi_cmnd.request

2021-08-12T02:25:37+00:00

Prepare for removal of the request pointer by using scsi_cmd_to_rq()
instead. Cast away constness where necessary when passing a SCSI command
pointer to scsi_cmd_to_rq(). This patch does not change any functionality.

Link: https://lore.kernel.org/r/20210809230355.8186-3-bvanassche@acm.org
Cc: Christoph Hellwig 
Cc: Hannes Reinecke 
Cc: Ming Lei 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: core: Drop the now obsolete driver_byte definitions

2021-06-01T02:48:22+00:00

The driver_byte field in the result is now unused, so we can drop the
definitions.

Link: https://lore.kernel.org/r/20210427083046.31620-15-hare@suse.de
Reviewed-by: Bart Van Assche 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen

scsi: core: Delete unnecessary buffer allocation for every loop iteration

2020-07-25T02:09:57+00:00

No need to allocate buffer every loop iteration. Allocate buffer once and
reuse it.

Link: https://lore.kernel.org/r/20200717090921.29243-2-yebin10@huawei.com
Signed-off-by: Ye Bin 
Signed-off-by: Martin K. Petersen

scsi: core: Log SCSI command age with errors

2019-10-01T03:07:16+00:00

Couple of users had requested to print the SCSI command age along with
command failure errors. This is a small change, but allows users to get
more important information about the command that was failed, it would help
the users in debugging the command failures:

Link: https://lore.kernel.org/r/20190926052501.GA8352@machine1
Signed-off-by: Milan P. Gandhi 
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: core: Reduce memory required for SCSI logging

2019-08-08T01:47:29+00:00

The data structure used for log messages is so large that it can cause a
boot failure. Since allocations from that data structure can fail anyway,
use kmalloc() / kfree() instead of that data structure.

See also https://bugzilla.kernel.org/show_bug.cgi?id=204119.
See also commit ded85c193a39 ("scsi: Implement per-cpu logging buffer") # v4.0.

Reported-by: Jan Palus 
Cc: Christoph Hellwig 
Cc: Hannes Reinecke 
Cc: Johannes Thumshirn 
Cc: Ming Lei 
Cc: Jan Palus 
Signed-off-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428

2019-06-05T15:37:16+00:00

Based on 1 normalized pattern(s):

  this file is released under the gplv2

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 68 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Armijn Hemel 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190531190114.292346262@linutronix.de
Signed-off-by: Greg Kroah-Hartman