linux-toradex.git/drivers/scsi/scsi_sysfs.c, branch v2.6.26.8

[SCSI] fix intermittent oops in scsi_bus_uevent

2008-05-23T21:17:06+00:00

Reported-by: Sitsofe Wheeler 
> BUG: unable to handle kernel paging request at e6f17fac
> IP: [] scsi_bus_uevent+0x1/0x17
> *pde = 2714b163 *pte = 26f17160
> Oops: 0000 [#1] DEBUG_PAGEALLOC
> last sysfs file:
>
> Pid:  1, comm: swapper Not tainted (2.6.26-rc2-next-20080516skw #30)
> EIP: 0060:[] EFLAGS: 00010282 CPU: 0
> EIP is at scsi_bus_uevent+0x1/0x17
> EAX: e6f18014 EBX: e6f18014 ECX: c02604d5 EDX: e7173000
> ESI: e7173000 EDI: e7173000 EBP: e7851ca0 ESP: e7851c90
>  DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068

The problem is caused by:

commit b0ed43360fdca227048d88a08290365cb681c1a8
Author: Hannes Reinecke 
Date:   Tue Mar 18 14:32:28 2008 +0100

    [SCSI] add scsi_host and scsi_target to scsi_bus

which added scsi_bus_type to the struct scsi_target device.  This
causes both the scsi_device and scsi_target to fire scsi_bus_uevents.
However, the actualy scsi_bus_uevent() call assumes blindly that it's
a struct scsi_device.  Check for this and return immediately if it
isn't.

Signed-off-by: James Bottomley

[SCSI] bsg: add release callback support

2008-04-22T20:16:32+00:00

This patch adds release callback support, which is called when a bsg
device goes away. bsg_register_queue() takes a pointer to a callback
function. This feature is useful for stuff like sas_host that can't
use the release callback in struct device.

If a caller doesn't need bsg's release callback, it can call
bsg_register_queue() with NULL pointer (e.g. scsi devices can use
release callback in struct device so they don't need bsg's callback).

With this patch, bsg uses kref for refcounts on bsg devices instead of
get/put_device in fops->open/release. bsg calls put_device and the
caller's release callback (if it was registered) in kref_put's
release.

Signed-off-by: FUJITA Tomonori 
Signed-off-by: James Bottomley

[SCSI] rework scsi_target allocation

2008-04-22T20:16:31+00:00

The current target allocation code registeres each possible target
with sysfs; it will be deleted again if no useable LUN on this target
was found. This results in a string of 'target add/target remove' uevents.

Based on a patch by Hannes Reinecke  this patch reworks
the target allocation code so that only uevents for existing targets
are sent. The sysfs registration is split off from the existing
scsi_target_alloc() into a in a new scsi_add_target() function, which
should be called whenever an existing target is found. Only then a
uevent is sent, so we'll be generating events for existing targets
only.

Signed-off-by: James Bottomley

[SCSI] use default attributes for scsi_host

2008-04-22T20:16:31+00:00

This patch removes the unused sysfs attibute overwriting logic for
the scsi host attibutes, and plugs them into the driver core default
attribute creation.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Kay Sievers 
Signed-off-by: James Bottomley

[SCSI] add scsi_host and scsi_target to scsi_bus

2008-04-22T20:16:29+00:00

This patch implements scsi_host and scsi_target device types
and adds both to the scsi_bus.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Kay Sievers 
Signed-off-by: James Bottomley

SCSI: convert struct class_device to struct device

2008-04-20T02:10:33+00:00

It's big, but there doesn't seem to be a way to split it up smaller...

Signed-off-by: Tony Jones 
Signed-off-by: Kay Sievers 
Cc: Roland Dreier 
Cc: Sean Hefty 
Cc: Hal Rosenstock 
Cc: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

Revert "[SCSI] fix bsg queue oops with iscsi logout"

2008-03-26T16:09:19+00:00

This reverts commit 4b6f5b3a993cbe34b4280f252bccc76967c185c8.

bsg takes a reference to the underlying generic device, so it's
impossible to unregister bsg in the device release routine.

Acked-by: FUJITA Tomonori 
Signed-off-by: James Bottomley

[SCSI] fix bsg queue oops with iscsi logout

2008-03-13T21:47:05+00:00

Delay bsg unregistration, because we want to wait until all the request/cmds
have released their reference.

Signed-off-by: Mike Christie 
Acked-by: FUJITA Tomonori 
Signed-off-by: James Bottomley

[SCSI] add missing transport configure points for target and host

2008-01-23T17:29:17+00:00

While trying to convert the SPI transport class to attribute groups, I
discovered that we don't actually have any transport configure points
for either the target or the host.  This patch adds these missing
transport class triggers.  The host one is simply done after the add,
the target one tries to be more clever and add it after devices may have
been placed on the target (so the device configure will have set up the
target parameters).

Signed-off-by: James Bottomley

[SCSI] scsi_sysfs: restore prep_fn when ULD is removed

2008-01-02T19:08:00+00:00

A recent bug report:

http://bugzilla.kernel.org/show_bug.cgi?id=9674

Was caused because the ULDs now set their own prep functions, but
don't necessarily reset the prep function back to the SCSI default
when they are removed.  This leads to panics if commands are sent to
the device after the module is removed because the prep_fn is still
pointing to the old module code.  The fix for this is to implement a
bus remove method that resets the prep_fn pointer correctly before
calling the ULD specific driver remove method.

Signed-off-by: James Bottomley