linux-toradex.git/drivers/scsi/sd.h, branch v4.9.123

scsi: sd: Move DIF protection types to t10-pi.h

2016-09-15T13:51:14+00:00

These should go together with the rest of the T10 protection information
defintions.

[mkp: s/T10_DIF/T10_PI/]

Signed-off-by: Christoph Hellwig 
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: scsi_debug: Use struct t10_pi_tuple instead of struct sd_dif_tuple

2016-09-15T13:41:09+00:00

And remove the declaration of the latter in sd.h as scsi_debug was the
only user.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

sd: Fix rw_max for devices that report an optimal xfer size

2016-06-02T02:07:47+00:00

For historic reasons, io_opt is in bytes and max_sectors in block layer
sectors. This interface inconsistency is error prone and should be
fixed. But for 4.4--4.7 let's make the unit difference explicit via a
wrapper function.

Fixes: d0eb20a863ba ("sd: Optimal I/O size is in bytes, not sectors")
Cc: stable@vger.kernel.org # 4.4+
Reported-by: Fam Zheng 
Reviewed-by: Bart Van Assche 
Reviewed-by: Christoph Hellwig 
Tested-by: Andrew Patterson 
Signed-off-by: Martin K. Petersen

sd: Fix excessive capacity printing on devices with blocks bigger than 512 bytes

2016-04-01T00:59:08+00:00

During revalidate we check whether device capacity has changed before we
decide whether to output disk information or not.

The check for old capacity failed to take into account that we scaled
sdkp->capacity based on the reported logical block size. And therefore
the capacity test would always fail for devices with sectors bigger than
512 bytes and we would print several copies of the same discovery
information.

Avoid scaling sdkp->capacity and instead adjust the value on the fly
when setting the block device capacity and generating fake C/H/S
geometry.

Signed-off-by: Martin K. Petersen 
Cc: 
Reported-by: Hannes Reinecke 
Reviewed-by: Hannes Reinicke 
Reviewed-by: Ewan Milne 
Signed-off-by: Martin K. Petersen

block/sd: Fix device-imposed transfer length limits

2015-11-26T02:38:58+00:00

Commit 4f258a46346c ("sd: Fix maximum I/O size for BLOCK_PC requests")
had the unfortunate side-effect of removing an implicit clamp to
BLK_DEF_MAX_SECTORS for REQ_TYPE_FS requests in the block layer
code. This caused problems for some SMR drives.

Debugging this issue revealed a few problems with the existing
infrastructure since the block layer didn't know how to deal with
device-imposed limits, only limits set by the I/O controller.

 - Introduce a new queue limit, max_dev_sectors, which is used by the
   ULD to signal the maximum sectors for a REQ_TYPE_FS request.

 - Ensure that max_dev_sectors is correctly stacked and taken into
   account when overriding max_sectors through sysfs.

 - Rework sd_read_block_limits() so it saves the max_xfer and opt_xfer
   values for later processing.

 - In sd_revalidate() set the queue's max_dev_sectors based on the
   MAXIMUM TRANSFER LENGTH value in the Block Limits VPD. If this value
   is not reported, fall back to a cap based on the CDB TRANSFER LENGTH
   field size.

 - In sd_revalidate(), use OPTIMAL TRANSFER LENGTH from the Block Limits
   VPD--if reported and sane--to signal the preferred device transfer
   size for FS requests. Otherwise use BLK_DEF_MAX_SECTORS.

 - blk_limits_max_hw_sectors() is no longer used and can be removed.

Signed-off-by: Martin K. Petersen 
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=93581
Reviewed-by: Christoph Hellwig 
Tested-by: sweeneygj@gmx.com
Tested-by: Arzeets 
Tested-by: David Eisner 
Tested-by: Mario Kicherer 
Signed-off-by: Martin K. Petersen

scsi: introduce sdev_prefix_printk()

2014-11-12T10:15:57+00:00

Like scmd_printk(), but the device name is passed in as
a string. Can be used by eg ULDs which do not have access
to the scsi_cmnd structure.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

sd: Honor block layer integrity handling flags

2014-09-30T21:17:35+00:00

A set of flags introduced in the block layer enable better control over
how protection information is handled. These flags are useful for both
error injection and data recovery purposes. Checking can be enabled and
disabled for controller and disk, and the guard tag format is now a
per-I/O property.

Update sd_protect_op to communicate the relevant information to the
low-level device driver via a set of flags in scsi_cmnd.

Signed-off-by: Martin K. Petersen 
Reviewed-by: Sagi Grimberg 
Acked-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

sd: Limit transfer length

2014-07-17T20:07:33+00:00

Until now the per-command transfer length has exclusively been gated by
the max_sectors parameter in the scsi_host template. Given that the size
of this parameter has been bumped to an unsigned int we have to be
careful not to exceed the target device's capabilities.

If the if the device specifies a Maximum Transfer Length in the Block
Limits VPD we'll use that value. Otherwise we'll use 0xffffffff for
devices that have use_16_for_rw set and 0xffff for the rest. We then
combine the chosen disk limit with max_sectors in the host template. The
smaller of the two will be used to set the max_hw_sectors queue limit.

Signed-off-by: Martin K. Petersen 
Reviewed-by: Ewan D. Milne 
Signed-off-by: Christoph Hellwig

[SCSI] sd: Quiesce mode sense error messages

2014-03-27T15:26:33+00:00

Messages about discovered disk properties are only printed once unless
they are found to have changed. Errors encountered during mode sense,
however, are printed every time we revalidate.

Quiesce mode sense errors so they are only printed during the first
scan.

[jejb: checkpatch fixes]
Bugzilla: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733565
Signed-off-by: Martin K. Petersen 
Signed-off-by: James Bottomley

[SCSI] Derive the FLUSH_TIMEOUT from the basic I/O timeout

2013-10-25T08:58:16+00:00

Rather than having a separate constant for specifying the timeout on FLUSH
operations, use the basic I/O timeout value that is already configurable
on a per target basis to derive the FLUSH timeout. Looking at the current
definitions of these timeout values, the FLUSH operation is supposed to have
a value that is twice the normal timeout value. This patch preserves this
relationship while leveraging the flexibility of specifying the I/O timeout.

Based on a prior patch by KY Srinivasan 

Reviewed-by: KY Srinivasan 
Signed-off-by: James Bottomley