linux-toradex.git/drivers/scsi/sg.c, branch v2.6.26-rc5

SCSI: fix race in device_create

2008-05-20T20:31:56+00:00

There is a race from when a device is created with device_create() and
then the drvdata is set with a call to dev_set_drvdata() in which a
sysfs file could be open, yet the drvdata will be NULL, causing all
sorts of bad things to happen.

This patch fixes the problem by using the new function,
device_create_drvdata().  It fixes the problem in all of the scsi
drivers that need it.

Cc: Kay Sievers 
Cc: Doug Gilbert 
Cc: James E.J. Bottomley 
Signed-off-by: Greg Kroah-Hartman

scsi: use non-racy method for proc entries creation

2008-04-29T15:06:21+00:00

Use proc_create() to make sure that ->proc_fops be setup before gluing PDE to
main tree.

Add correct ->owner to proc_fops to fix reading/module unloading race.

Signed-off-by: Denis V. Lunev 
Cc: Greg Kroah-Hartman 
Cc: Alexey Dobriyan 
Cc: "Eric W. Biederman" 
Cc: James Bottomley 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

SCSI: convert struct class_device to struct device

2008-04-20T02:10:33+00:00

It's big, but there doesn't seem to be a way to split it up smaller...

Signed-off-by: Tony Jones 
Signed-off-by: Kay Sievers 
Cc: Roland Dreier 
Cc: Sean Hefty 
Cc: Hal Rosenstock 
Cc: James Bottomley 
Signed-off-by: Greg Kroah-Hartman

Convert SG from nopage to fault.

2008-02-08T03:09:22+00:00

Signed-off-by: Nick Piggin 
Cc: Douglas Gilbert 
Cc: James Bottomley 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

blktrace: Add blktrace ioctls to SCSI generic devices

2008-01-28T09:04:46+00:00

Since the SCSI layer uses the request queues from the block layer, blktrace can
also be used to trace the requests to all SCSI devices (like SCSI tape drives),
not only disks. The only missing part is the ioctl interface to start and stop
tracing.

This patch adds the SETUP, START, STOP and TEARDOWN ioctls from blktrace to the
sg device files. With this change, blktrace can be used for SCSI devices like
for disks, e.g.: blktrace -d /dev/sg1 -o - | blkparse -i -

Signed-off-by: Christof Schmitt 
Signed-off-by: Jens Axboe

[SCSI] sg: fix /proc/scsi/sg/devices when no SCSI devices

2008-01-23T19:40:55+00:00

The patch "[SCSI] sg: use idr to replace static arrays" in 2.6.24-rc1
causes a bogus line to appear in /proc/scsi/sg/devices containing
"-1 -1 -1 -1 -1 -1 -1 -1 -1" when there are no SCSI devices in the
system.  In 2.6.23, /proc/scsi/sg/devices is empty when there are no
SCSI devices in the system.  A similar problem exists with
/proc/scsi/sg/device_strs.  The following patch restores the behavior
of 2.6.23.

Signed-off-by: Tony Battersby 
Acked-by: Douglas Gilbert 
Signed-off-by: James Bottomley

[SCSI] sg: handle class_device_create failure properly

2008-01-23T17:29:28+00:00

Signed-off-by: FUJITA Tomonori 
Acked-by: Douglas Gilbert 
Signed-off-by: James Bottomley

[SCSI] sg: set class_data after success

2008-01-23T17:29:28+00:00

If cdev_add fails in sg_add, sg_remove crashes since class_data is
bogus.

Signed-off-by: FUJITA Tomonori 
Acked-by: Douglas Gilbert 
Signed-off-by: James Bottomley

[SCSI] sg: Only print SCSI data direction warning once for a command

2008-01-23T17:29:27+00:00

When I use cdparanoia my logs get spammed a lot by

printk: 464 messages suppressed.
sg_write: data in/out 30576/30576 bytes for SCSI command 0xbe--guessing data in;
   program cdparanoia not setting count and/or reply_len properly
printk: 1078 messages suppressed.

and many more of those. With this patch the message is only printed once
for a command in a row.

v1->v2: Prevent rate limit messages too (pointed out by jejb)

Signed-off-by: Andi Kleen 
Acked-by: Douglas Gilbert 
Signed-off-by: James Bottomley

Initialise scatter/gather list in sg driver

2007-10-29T08:18:03+00:00

After turning on DEBUG_SG I hit a fail:

kernel BUG at include/linux/scatterlist.h:50!

	sg_build_indirect
	sg_build_reserve
	sg_open
	chrdev_open
	__dentry_open
	do_filp_open
	do_sys_open

We should initialise the sg list when we allocate it in sg_build_sgat.

Signed-off-by: Anton Blanchard 
Signed-off-by: Jens Axboe