linux-toradex.git/drivers/scsi/sg.c, branch v3.6.1

[SCSI] sg: constify sg_proc_leaf_arr

2012-05-17T09:08:57+00:00

Signed-off-by: Joern Engel 
Acked-by: Douglas Gilbert 
Signed-off-by: James Bottomley

[SCSI] sg: remove sg_mutex

2012-05-17T09:08:57+00:00

With the exception of the detached field, sg_mutex no longer adds any
locking.  detached handling has been broken before and is still broken
and this patch does not seem to make things worse than they were to
begin with.

However, I have observed cases of tasks being blocked for >200s waiting
for sg_mutex.  So the removal clearly adds value for very little cost.

Signed-off-by: Joern Engel 
Acked-by: Douglas Gilbert 
Signed-off-by: James Bottomley

[SCSI] sg: completely protect sfds

2012-05-17T09:08:56+00:00

sfds is protected by sg_index_lock - except for sg_open(), where it
isn't.  Change that and add some documentation.

Signed-off-by: Joern Engel 
Acked-by: Douglas Gilbert 
Signed-off-by: James Bottomley

[SCSI] sg: protect sdp->exclude

2012-05-17T09:08:55+00:00

Changes since v1: set_exclude now returns the new value, which gets
rid of the comma expression and the operator precedence bug.  Thanks
to Douglas for spotting it.

sdp->exclude was previously protected by the BKL.  The sg_mutex, which
replaced the BKL, only semi-protected it, as it was missing from
sg_release() and sg_proc_seq_show_debug().  Take an explicit spinlock
for it.

Signed-off-by: Joern Engel 
Acked-by: Douglas Gilbert 
Signed-off-by: James Bottomley

[SCSI] sg: prevent unwoken sleep

2012-05-17T09:08:54+00:00

srp->done is protected by sfp->rq_list_lock everywhere, except for this
one case.  Result can be that the wake-up happens before the cacheline
with the changed srp->done has arrived, so the waiter can go back to
sleep and never be woken up again.

The wait_event_interruptible() means that anyone trying to debug this
unlikely race will likely notice everything working fine again, as the
next signal will unwedge things.  Evil.

Signed-off-by: Joern Engel 
Acked-by: Douglas Gilbert 
Signed-off-by: James Bottomley

[SCSI] sg: remove closed flag

2012-05-17T09:08:53+00:00

After sg_release() has been called, noone should be able to actually use
that filedescriptor anymore.  So if closed ever made a difference in the
past five years or so, it would have meant a bug.  Remove it.

Signed-off-by: Joern Engel 
Acked-by: Douglas Gilbert 
[jejb: fix up checkpatch warnings]
Signed-off-by: James Bottomley

[SCSI] sg: use wait_event_interruptible()

2012-05-17T09:08:53+00:00

Afaics the use of __wait_event_interruptible() as opposed to
wait_event_interruptible() is purely historic.  So let's follow the rest
of the kernel and check the condition before prepare_to_wait() - and
also make the code a bit nicer.

Signed-off-by: Joern Engel 
Acked-by: Douglas Gilbert 
Signed-off-by: James Bottomley

[SCSI] sg: remove while (1) non-loop

2012-05-17T09:08:52+00:00

The while (1) construct isn't actually a loop at all.  So let's not
pretent and obfuscate the code.

Signed-off-by: Joern Engel 
Acked-by: Douglas Gilbert 
Signed-off-by: James Bottomley

[SCSI] sg: remove unnecessary indentation

2012-05-17T08:45:29+00:00

blocking is de-facto a constant and the now-removed comment wasn't all
that useful either.  Without them and the resulting indentation the code
is a bit nicer to read.

Signed-off-by: Joern Engel 
Acked-by: Douglas Gilbert 
Signed-off-by: James Bottomley

[SCSI] sg: convert to kstrtoul_from_user()

2012-01-16T08:17:29+00:00

Instead of open coding this function use kstrtoul_from_user() directly.

Signed-off-by: Stephen Boyd 
Acked-by: Douglas Gilbert 
Signed-off-by: Andrew Morton 
Signed-off-by: James Bottomley