linux-toradex.git/drivers/scsi/sun3_scsi.c, branch v4.4.35

ncr5380: Drop owner assignment from platform_drivers

2015-03-09T11:18:14+00:00

This platform_driver does not need to set an owner, it will be populated by
the driver core.

Signed-off-by: Wolfram Sang 
Signed-off-by: Finn Thain 
Signed-off-by: James Bottomley

atari_NCR5380: Remove RESET_RUN_DONE macro

2014-11-20T08:11:20+00:00

There's no need to run the cmd->done callback for aborted commands. Remove
the old EH code and the RESET_RUN_DONE macro.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

atari_NCR5380: Introduce FLAG_TAGGED_QUEUING

2014-11-20T08:11:19+00:00

The static variable setup_use_tagged_queuing is declared in mac_scsi.c,
sun3_scsi.c and atari_scsi.c and doesn't belong in the core driver.
None of the other NCR5380 drivers suffer from this layering issue which
makes merging the core drivers more difficult and will likely hinder plans
for future use of platform data to configure the driver.

Replace the static variable with a host flag. This way it can be reported
along with the other flags.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

sun3_scsi: Adopt atari_NCR5380 core driver and remove sun3_NCR5380.c

2014-11-20T08:11:18+00:00

Given the preceding changes to atari_NCR5380.c, this patch should not change
behaviour of the sun3_scsi and sun3_scsi_vme modules.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

ncr5380: Remove ENABLE_IRQ/DISABLE_IRQ macros

2014-11-20T08:11:16+00:00

atari_NCR5380.c enables its IRQ when it is already enabled. Sun3 doesn't
use the ENABLE_IRQ/DISABLE_IRQ cruft. Remove it.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

sun3_scsi: Move macro definitions

2014-11-20T08:11:15+00:00

The #defines in sun3_scsi.h are intended to influence subsequent #includes
in sun3_scsi.c. IMHO, that's too convoluted.

Move sun3_scsi.h macro definitions to sun3_scsi.c, consistent with other
NCR5380 drivers.

Omit the unused NCR5380_local_declare() and NCR5380_setup() macros.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

sun3_scsi: Convert to platform device

2014-11-20T08:11:15+00:00

Convert sun3_scsi to platform device and eliminate scsi_register().

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Acked-by: Geert Uytterhoeven 
Signed-off-by: Christoph Hellwig

ncr5380: Drop legacy scsi.h include

2014-11-20T08:11:10+00:00

Convert Scsi_Cmnd to struct scsi_cmnd and drop the #include "scsi.h".
The sun3_NCR5380.c core driver already uses struct scsi_cmnd so converting
the other core drivers reduces the diff which makes them easier to unify.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

ncr5380: Remove *_RELEASE macros

2014-11-20T08:11:10+00:00

The *_RELEASE macros don't tell me anything. In some cases the version in
the macro contradicts the version in the comments. Anyway, the Linux kernel
version is sufficient information. Remove these macros to improve readability.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

ncr5380: Remove pointless compiler command line override macros

2014-11-20T08:11:09+00:00

Compile-time override of scsi host defaults is pointless for drivers that
provide module parameters and __setup options for that. Too many macros make
the code hard to read so remove them.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig