linux-toradex.git/drivers/scsi/sun3_scsi.h, branch v4.4.38

sun3_scsi: Move macro definitions

2014-11-20T08:11:15+00:00

The #defines in sun3_scsi.h are intended to influence subsequent #includes
in sun3_scsi.c. IMHO, that's too convoluted.

Move sun3_scsi.h macro definitions to sun3_scsi.c, consistent with other
NCR5380 drivers.

Omit the unused NCR5380_local_declare() and NCR5380_setup() macros.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

sun3_scsi: Convert to platform device

2014-11-20T08:11:15+00:00

Convert sun3_scsi to platform device and eliminate scsi_register().

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Acked-by: Geert Uytterhoeven 
Signed-off-by: Christoph Hellwig

ncr5380: Remove *_RELEASE macros

2014-11-20T08:11:10+00:00

The *_RELEASE macros don't tell me anything. In some cases the version in
the macro contradicts the version in the comments. Anyway, the Linux kernel
version is sufficient information. Remove these macros to improve readability.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

ncr5380: Remove pointless compiler command line override macros

2014-11-20T08:11:09+00:00

Compile-time override of scsi host defaults is pointless for drivers that
provide module parameters and __setup options for that. Too many macros make
the code hard to read so remove them.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

ncr5380: Cleanup host info() methods

2014-11-20T08:11:08+00:00

If the host->info() method is not set, then host->name is used by default.
For atari_scsi, that is exactly the same text. So remove the redundant
info() method. Keep sun3_scsi.c in line with atari_scsi.

Some NCR5380 drivers return an empty string from the info() method
(arm/cumana_1.c arm/oak.c mac_scsi.c) while other drivers use the default
(dmx3191d dtc.c g_NCR5380.c pas16.c t128.c).

Implement a common info() method to replace a lot of duplicated code which
the various drivers use to announce the same information.

This replaces most of the (deprecated) show_info() output and all of the
NCR5380_print_info() output. This also eliminates a bunch of code in
g_NCR5380 which just duplicates functionality in the core driver.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

ncr5380: Remove duplicate comments

2014-11-20T08:11:06+00:00

The LIMIT_TRANSFERSIZE, PSEUDO_DMA, PARITY and UNSAFE options are all
documented in the core drivers where they are used. The same goes for the
chip databook reference. Remove the duplicate comments.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

ncr5380: Remove useless prototypes

2014-11-20T08:11:04+00:00

Add missing static qualifiers and remove the now pointless prototypes. The
NCR5380_* prototypes are all declared in NCR5380.h and renamed using macros.
Further declarations are redundant (some are completely unused). Remove
them.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

ncr5380: Remove unused macros

2014-11-20T08:11:04+00:00

Some macros are never evaluated (i.e. FOO, USLEEP, SCSI2 and USE_WRAPPER;
and in some drivers, NCR5380_intr and NCR5380_proc_info). DRIVER_SETUP
serves no purpose anymore. Remove these macro definitions.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Tested-by: Michael Schmitz 
Signed-off-by: Christoph Hellwig

ncr5380: Remove unused hostdata fields

2014-11-20T08:11:03+00:00

Remove unused fields from hostdata structs declared with the
NCR5380_implementation_fields macro.

Signed-off-by: Finn Thain 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

scsi/NCR5380: reduce depth of sun3_scsi nested includes

2014-05-28T10:11:33+00:00

Move the #include "NCR5380.h" out of the sun3_scsi.h header file and into
the driver .c files, like all the other NCR5380 drivers in the tree.

This improves uniformity and reduces the depth of nested includes. The
sequence of #include's, #define's and #if's no longer does my head in.

Signed-off-by: Finn Thain 
Acked-by: Sam Creasey 
Signed-off-by: Christoph Hellwig