linux-toradex.git/drivers/scsi/vmw_pvscsi.c, branch v4.2.3

vmw_pscsi: simplify ->change_queue_depth

2014-11-24T13:45:28+00:00

Remove overly verbose debugging output that pokes into mid-layer internal
structures that looks like copy & paste from the mpt2/3 drivers.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Mike Christie 
Reviewed-by: Hannes Reinecke

scsi: drop reason argument from ->change_queue_depth

2014-11-24T13:45:27+00:00

Drop the now unused reason argument from the ->change_queue_depth method.
Also add a return value to scsi_adjust_queue_depth, and rename it to
scsi_change_queue_depth now that it can be used as the default
->change_queue_depth implementation.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Mike Christie 
Reviewed-by: Hannes Reinecke

scsi: don't allow setting of queue_depth bigger than can_queue

2014-11-24T13:45:26+00:00

We won't ever queue more commands than the host allows.  Instead of
letting drivers either reject or ignore this case handle it in
common code.  Note that various driver use internal constant or
variables that are assigned to both shost->can_queue and checked
in ->change_queue_depth - I did remove those checks as well.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Mike Christie 
Reviewed-by: Hannes Reinecke

vmw_pvscsi: fixup tagging

2014-11-12T10:31:59+00:00

The request (and SCSI command) tag is the tag number assigned
by the generic block-tagging code, not the SCSI-II tag messages.
Those are represented by the device flags 'tagged_supported',
'simple_tags', and 'ordered_tags'.
(The SCSI midlayer doesn't use HEAD_OF_QUEUE tags).
So fixup vmw_pvscsi to assign the correct tag type.

[hch: fixed up to never set MSG_ORDERED_TAG]
Signed-off-by: Hannes Reinecke 
Acked-by: Arvind Kumar 
Signed-off-by: Christoph Hellwig

scsi: don't set tagging state from scsi_adjust_queue_depth

2014-11-12T10:19:43+00:00

Remove the tagged argument from scsi_adjust_queue_depth, and just let it
handle the queue depth.  For most drivers those two are fairly separate,
given that most modern drivers don't care about the SCSI "tagged" status
of a command at all, and many old drivers allow queuing of multiple
untagged commands in the driver.

Instead we start out with the ->simple_tags flag set before calling
->slave_configure, which is how all drivers actually looking at
->simple_tags except for one worke anyway.  The one other case looks
broken, but I've kept the behavior as-is for now.

Except for that we only change ->simple_tags from the ->change_queue_type,
and when rejecting a tag message in a single driver, so keeping this
churn out of scsi_adjust_queue_depth is a clear win.

Now that the usage of scsi_adjust_queue_depth is more obvious we can
also remove all the trivial instances in ->slave_alloc or ->slave_configure
that just set it to the cmd_per_lun default.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Mike Christie 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Martin K. Petersen

scsi: remove ordered_tags scsi_device field

2014-11-12T10:19:40+00:00

Remove the ordered_tags field, we haven't been issuing ordered tags based
on it since the big barrier rework in 2010.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Mike Christie 
Reviewed-by: Bart Van Assche 
Reviewed-by: Martin K. Petersen

vmw_pvscsi: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-29T12:38:53+00:00

As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range()  or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.

Signed-off-by: Alexander Gordeev 
Acked-by: Arvind Kumar 
Signed-off-by: Christoph Hellwig

[SCSI] vmw_pvscsi: Some improvements in pvscsi driver.

2014-03-19T22:04:46+00:00

This change is about the following:
(1) If the number of targets is 16+ then default ring_pages to 32.
(2) Change default queue depth (per device) to 254.
(3) Implement change_queue_depth function so that queue_depth per device can
    be changed at run time. Honors the request only if coming from sysfs.
(4) Clean up the info returned by modinfo.

Signed-off-by: Arvind Kumar 
Signed-off-by: James Bottomley

[SCSI] vmw_pvscsi: Add support for I/O requests coalescing.

2014-03-19T22:04:45+00:00

This change allows pvscsi driver to coalesce I/O requests
before issuing them. The number of I/O's coalesced can be
dynamically configured based on the workload.

Signed-off-by: Rishi Mehta 
Signed-off-by: Arvind Kumar 
Signed-off-by: James Bottomley

[SCSI] vmw_pvscsi: Fix pvscsi_abort() function.

2014-03-19T22:04:45+00:00

This change ensures that pvscsi_abort() function returns SUCCESS
only when the command in question was actually completed, otherwise
returns FAILURE. The code before change, was causing a bug where
driver tries to complete a command to the mid-layer while the mid-layer
has already requested the driver to abort that command, in response
to which the driver has responded with SUCCESS causing mid-layer
to free the command struct.

Signed-off-by: Arvind Kumar 
Tested-by: Ewan Milne 
Signed-off-by: James Bottomley