linux-toradex.git/drivers/scsi, branch v4.19-rc8

scsi: qedi: Initialize the stats mutex lock

2018-09-28T06:28:05+00:00

Fix kernel NULL pointer dereference,

Call Trace:
  [] __mutex_lock_slowpath+0xa6/0x1d0
  [] mutex_lock+0x1f/0x2f
  [] qedi_get_protocol_tlv_data+0x61/0x450 [qedi]
  [] ? map_vm_area+0x2e/0x40
  [] ? __vmalloc_node_range+0x170/0x280
  [] ? qed_mfw_process_tlv_req+0x27d/0xbd0 [qed]
  [] qed_mfw_fill_tlv_data+0x4b/0xb0 [qed]
  [] qed_mfw_process_tlv_req+0x299/0xbd0 [qed]
  [] ? __switch_to+0xce/0x580
  [] qed_slowpath_task+0x5b/0x80 [qed]

Signed-off-by: Nilesh Javali 
Signed-off-by: Martin K. Petersen

scsi: sd: don't crash the host on invalid commands

2018-09-21T16:42:57+00:00

When sd_init_command() get's a command with a unknown req_op() it crashes the
system via BUG().

This makes debugging the actual reason for the broken request cmd_flags pretty
hard as the system is down before it's able to write out debugging data on the
serial console or the trace buffer.

Change the BUG() to a WARN_ON() and return BLKPREP_KILL to fail gracefully and
return an I/O error to the producer of the request.

Signed-off-by: Johannes Thumshirn 
Cc: Hannes Reinecke 
Cc: Bart Van Assche 
Cc: Christoph Hellwig 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: ipr: System hung while dlpar adding primary ipr adapter back

2018-09-21T16:35:39+00:00

While dlpar adding primary ipr adapter back, driver goes through adapter
initialization then schedule ipr_worker_thread to start te disk scan by
dropping the host lock, calling scsi_add_device.  Then get the adapter reset
request again, so driver does scsi_block_requests, this will cause the
scsi_add_device get hung until we unblock. But we can't run ipr_worker_thread
to do the unblock because its stuck in scsi_add_device.

This patch fixes the issue.

[mkp: typo and whitespace fixes]

Signed-off-by: Wen Xiong 
Acked-by: Brian King 
Signed-off-by: Martin K. Petersen

scsi: lpfc: Synchronize access to remoteport via rport

2018-09-21T02:02:36+00:00

The driver currently uses the ndlp to get the local rport which is then used
to get the nvme transport remoteport pointer. There can be cases where a stale
remoteport pointer is obtained as synchronization isn't done through the
different dereferences.

Correct by using locks to synchronize the dereferences.

Signed-off-by: Dick Kennedy 
Signed-off-by: James Smart 
Signed-off-by: Martin K. Petersen

scsi: ufs: Disable blk-mq for now

2018-09-21T01:58:42+00:00

blk-mq does not support runtime pm, so disable blk-mq support for now.

Fixes: d5038a13eca7 ("scsi: core: switch to scsi-mq by default")
Signed-off-by: Adrian Hunter 
Acked-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: sd: Contribute to randomness when running rotational device

2018-09-17T06:57:10+00:00

Currently a scsi device won't contribute to kernel randomness when it uses
blk-mq. Since we commonly use scsi on rotational device with blk-mq, it make
sense to keep contributing to kernel randomness in these cases. This is
especially important for virtual machines.

commit b5b6e8c8d3b4 ("scsi: virtio_scsi: fix IO hang caused by automatic irq
vector affinity") made all virtio-scsi device to use blk-mq, which does not
contribute to randomness today. So for a virtual machine only having
virtio-scsi disk (which is common), it will simple stop getting randomness
from its disks in today's implementation.

With this patch, if the above VM has rotational virtio-scsi device, then it
can still benefit from the entropy generated from the disk.

Reported-by: Xuewei Zhang 
Signed-off-by: Xuewei Zhang 
Reviewed-by: Ming Lei 
Reviewed-by: Maciej Żenczykowski 
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: ibmvscsis: Ensure partition name is properly NUL terminated

2018-09-17T06:50:37+00:00

While reviewing another part of the code, Kees noticed that the strncpy of the
partition name might not always be NUL terminated. Switch to using strscpy
which does this safely.

Reported-by: Kees Cook 
Signed-off-by: Laura Abbott 
Reviewed-by: Kees Cook 
Signed-off-by: Martin K. Petersen

scsi: ibmvscsis: Fix a stringop-overflow warning

2018-09-17T06:49:55+00:00

There's currently a warning about string overflow with strncat:

drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe':
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3479:2: error: 'strncat' specified
bound 64 equals destination size [-Werror=stringop-overflow=]
  strncat(vscsi->eye, vdev->name, MAX_EYE);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Switch to a single snprintf instead of a strcpy + strcat to handle this
cleanly.

Signed-off-by: Laura Abbott 
Suggested-by: Kees Cook 
Signed-off-by: Martin K. Petersen

scsi: qla2xxx: Fix an endian bug in fcpcmd_is_corrupted()

2018-09-12T01:08:27+00:00

We should first do the le16_to_cpu endian conversion and then apply the
FCP_CMD_LENGTH_MASK mask.

Fixes: 5f35509db179 ("qla2xxx: Terminate exchange if corrupted")
Signed-off-by: Dan Carpenter 
Acked-by: Quinn Tran 
Acked-by: Himanshu Madhani 
Signed-off-by: Martin K. Petersen

scsi: qedi: Add the CRC size within iSCSI NVM image

2018-08-30T11:15:22+00:00

The QED driver commit, 1ac4329a1cff ("qed: Add configuration information
to register dump and debug data"), removes the CRC length validation
causing nvm_get_image failure while loading qedi driver:

[qed_mcp_get_nvm_image:2700(host_10-0)]Image [0] is too big - 00006008 bytes
where only 00006004 are available
[qedi_get_boot_info:2253]:10: Could not get NVM image. ret = -12

Hence add and adjust the CRC size to iSCSI NVM image to read boot info at
qedi load time.

Signed-off-by: Nilesh Javali 
Signed-off-by: Martin K. Petersen