linux-toradex.git/drivers/scsi, branch v6.16-rc4

scsi: fnic: Fix missing DMA mapping error in fnic_send_frame()

2025-06-20T03:07:57+00:00

dma_map_XXX() can fail and should be tested for errors with
dma_mapping_error().

Fixes: a63e78eb2b0f ("scsi: fnic: Add support for fabric based solicited requests and responses")
Signed-off-by: Thomas Fourier 
Link: https://lore.kernel.org/r/20250618065715.14740-2-fourier.thomas@gmail.com
Reviewed-by: Karan Tilak Kumar 
Reviewed-by: John Menghini 
Signed-off-by: Martin K. Petersen

scsi: fnic: Set appropriate logging level for log message

2025-06-20T03:06:28+00:00

Replace KERN_INFO with KERN_DEBUG for a log message.

Reviewed-by: Sesidhar Baddela 
Reviewed-by: Arulprabhu Ponnusamy 
Reviewed-by: Gian Carlo Boffa 
Reviewed-by: Arun Easi 
Signed-off-by: Karan Tilak Kumar 
Link: https://lore.kernel.org/stable/20250612002212.4144-1-kartilak%40cisco.com
Link: https://lore.kernel.org/r/20250618003431.6314-4-kartilak@cisco.com
Reviewed-by: John Meneghini 
Signed-off-by: Martin K. Petersen

scsi: fnic: Add and improve logs in FDMI and FDMI ABTS paths

2025-06-20T03:06:28+00:00

Add logs in FDMI and FDMI ABTS paths.

Modify log text in these paths.

Reviewed-by: Sesidhar Baddela 
Reviewed-by: Arulprabhu Ponnusamy 
Reviewed-by: Gian Carlo Boffa 
Reviewed-by: Arun Easi 
Reviewed-by: John Meneghini 
Signed-off-by: Karan Tilak Kumar 
Link: https://lore.kernel.org/r/20250618003431.6314-3-kartilak@cisco.com
Signed-off-by: Martin K. Petersen

scsi: fnic: Turn off FDMI ACTIVE flags on link down

2025-06-20T03:06:27+00:00

When the link goes down and comes up, FDMI requests are not sent out
anymore.

Fix bug by turning off FNIC_FDMI_ACTIVE when the link goes down.

Fixes: 09c1e6ab4ab2 ("scsi: fnic: Add and integrate support for FDMI")
Reviewed-by: Sesidhar Baddela 
Reviewed-by: Arulprabhu Ponnusamy 
Reviewed-by: Gian Carlo Boffa 
Reviewed-by: Arun Easi 
Tested-by: Karan Tilak Kumar 
Cc: stable@vger.kernel.org
Signed-off-by: Karan Tilak Kumar 
Link: https://lore.kernel.org/r/20250618003431.6314-2-kartilak@cisco.com
Reviewed-by: John Meneghini 
Signed-off-by: Martin K. Petersen

scsi: fnic: Fix crash in fnic_wq_cmpl_handler when FDMI times out

2025-06-20T03:06:27+00:00

When both the RHBA and RPA FDMI requests time out, fnic reuses a frame to
send ABTS for each of them. On send completion, this causes an attempt to
free the same frame twice that leads to a crash.

Fix crash by allocating separate frames for RHBA and RPA, and modify ABTS
logic accordingly.

Tested by checking MDS for FDMI information.

Tested by using instrumented driver to:

 - Drop PLOGI response
 - Drop RHBA response
 - Drop RPA response
 - Drop RHBA and RPA response
 - Drop PLOGI response + ABTS response
 - Drop RHBA response + ABTS response
 - Drop RPA response + ABTS response
 - Drop RHBA and RPA response + ABTS response for both of them

Fixes: 09c1e6ab4ab2 ("scsi: fnic: Add and integrate support for FDMI")
Reviewed-by: Sesidhar Baddela 
Reviewed-by: Arulprabhu Ponnusamy 
Reviewed-by: Gian Carlo Boffa 
Tested-by: Arun Easi 
Co-developed-by: Arun Easi 
Signed-off-by: Arun Easi 
Tested-by: Karan Tilak Kumar 
Cc: stable@vger.kernel.org
Signed-off-by: Karan Tilak Kumar 
Link: https://lore.kernel.org/r/20250618003431.6314-1-kartilak@cisco.com
Reviewed-by: John Meneghini 
Signed-off-by: Martin K. Petersen

scsi: megaraid_sas: Fix invalid node index

2025-06-20T02:47:46+00:00

On a system with DRAM interleave enabled, out-of-bound access is
detected:

megaraid_sas 0000:3f:00.0: requested/available msix 128/128 poll_queue 0
------------[ cut here ]------------
UBSAN: array-index-out-of-bounds in ./arch/x86/include/asm/topology.h:72:28
index -1 is out of range for type 'cpumask *[1024]'
dump_stack_lvl+0x5d/0x80
ubsan_epilogue+0x5/0x2b
__ubsan_handle_out_of_bounds.cold+0x46/0x4b
megasas_alloc_irq_vectors+0x149/0x190 [megaraid_sas]
megasas_probe_one.cold+0xa4d/0x189c [megaraid_sas]
local_pci_probe+0x42/0x90
pci_device_probe+0xdc/0x290
really_probe+0xdb/0x340
__driver_probe_device+0x78/0x110
driver_probe_device+0x1f/0xa0
__driver_attach+0xba/0x1c0
bus_for_each_dev+0x8b/0xe0
bus_add_driver+0x142/0x220
driver_register+0x72/0xd0
megasas_init+0xdf/0xff0 [megaraid_sas]
do_one_initcall+0x57/0x310
do_init_module+0x90/0x250
init_module_from_file+0x85/0xc0
idempotent_init_module+0x114/0x310
__x64_sys_finit_module+0x65/0xc0
do_syscall_64+0x82/0x170
entry_SYSCALL_64_after_hwframe+0x76/0x7e

Fix it accordingly.

Signed-off-by: Chen Yu 
Link: https://lore.kernel.org/r/20250604042556.3731059-1-yu.c.chen@intel.com
Fixes: 8049da6f3943 ("scsi: megaraid_sas: Use irq_set_affinity_and_hint()")
Cc: stable@vger.kernel.org
Signed-off-by: Martin K. Petersen

scsi: elx: efct: Fix memory leak in efct_hw_parse_filter()

2025-06-16T21:52:05+00:00

strsep() modifies the address of the pointer passed to it so that it no
longer points to the original address. This means kfree() gets the wrong
pointer.

Fix this by passing unmodified pointer returned from kstrdup() to
kfree().

Found by Linux Verification Center (linuxtesting.org) with Svace.

Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines")
Signed-off-by: Vitaliy Shevtsov 
Link: https://lore.kernel.org/r/20250612163616.24298-1-v.shevtsov@mt-integration.ru
Reviewed-by: Daniel Wagner 
Signed-off-by: Martin K. Petersen

scsi: error: alua: I/O errors for ALUA state transitions

2025-06-10T02:02:13+00:00

When a host is configured with a few LUNs and I/O is running, injecting
FC faults repeatedly leads to path recovery problems.  The LUNs have 4
paths each and 3 of them come back active after say an FC fault which
makes 2 of the paths go down, instead of all 4. This happens after
several iterations of continuous FC faults.

Reason here is that we're returning an I/O error whenever we're
encountering sense code 06/04/0a (LOGICAL UNIT NOT ACCESSIBLE, ASYMMETRIC
ACCESS STATE TRANSITION) instead of retrying.

Signed-off-by: Rajashekhar M A 
Signed-off-by: Hannes Reinecke 
Link: https://lore.kernel.org/r/20250606135924.27397-1-hare@kernel.org
Reviewed-by: Lee Duncan 
Signed-off-by: Martin K. Petersen

scsi: storvsc: Increase the timeouts to storvsc_timeout

2025-06-10T01:50:26+00:00

Currently storvsc_timeout is only used in storvsc_sdev_configure(), and
5s and 10s are used elsewhere. It turns out that rarely the 5s is not
enough on Azure, so let's use storvsc_timeout everywhere.

In case a timeout happens and storvsc_channel_init() returns an error,
close the VMBus channel so that any host-to-guest messages in the
channel's ringbuffer, which might come late, can be safely ignored.

Add a "const" to storvsc_timeout.

Cc: stable@kernel.org
Signed-off-by: Dexuan Cui 
Link: https://lore.kernel.org/r/1749243459-10419-1-git-send-email-decui@microsoft.com
Reviewed-by: Long Li 
Signed-off-by: Martin K. Petersen

Merge branch '6.16/scsi-queue' into 6.16/scsi-fixes

2025-06-09T19:34:06+00:00

Pull in remaining fixes from queue branch.

Signed-off-by: Martin K. Petersen