linux-toradex.git/drivers/serial/icom.c, branch v2.6.34

tty: Fix up char drivers request_room usage

2010-03-02T22:43:22+00:00

We can't change them all but quite a few misuse it.

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

tty: declare MODULE_FIRMWARE in various drivers

2010-03-02T22:43:15+00:00

Signed-off-by: Ben Hutchings 
Signed-off-by: Greg Kroah-Hartman

icom: convert space to tabs

2009-10-01T23:11:15+00:00

Convert spaces to tabs and remove wrong spaces

Signed-off-by: Breno Leitao 
Cc: Scott Kilau 
Cc: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

serial: move delta_msr_wait into the tty_port

2009-09-19T20:13:31+00:00

This is used by various drivers not just serial and can be extracted
as commonality

Signed-off-by: Alan Cox

serial: kill off uart_info

2009-09-19T20:13:28+00:00

We moved this into uart_state, now move the fields out of the separate
structure and kill it off.

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

tty: icom: bit and/or confusion?

2009-09-19T20:13:11+00:00

Previously, if any bit other than CMD_SND_BREAK was set, CMD_SND_BREAK
was not unset.

Signed-off-by: Roel Kluin 
Signed-off-by: Greg Kroah-Hartman

pci: use pci_ioremap_bar() in drivers/serial

2009-06-24T16:55:50+00:00

Use the newly introduced pci_ioremap_bar() function in drivers/serial.
pci_ioremap_bar() just takes a pci device and a bar number, with the goal
of making it really hard to get wrong, while also having a central place
to stick sanity checks.

Signed-off-by: Arjan van de Ven 
Signed-off-by: Andrew Morton 
Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

icom: fix compile errors when defining ICOM_TRACE

2009-06-11T15:51:03+00:00

As it is, defining ICOM_TRACE produces some compile errors, as
"parameter name omitted" and "redefinition of ‘trace’"

This patch removes the wrong trace definition.

Signed-off-by: Breno Leitao 
Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

icom: fixing a if clause spaghetti

2009-06-11T15:51:02+00:00

adapter->version can only be ADAPTER_V2 or ADAPTER_V1. So,
that OR operand in the "if" clause is non-sense and can be removed.

Signed-off-by: Breno Leitao 
Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

icom: fix rmmod crash

2009-05-23T04:47:52+00:00

Actually the icom driver is crashing when is being removed because
the driver is kfreeing the adapter structure before calling
pci_release_regions(), which result in the following error:

  Unable to handle kernel paging request for data at address 0x6b6b6b6b6b6b6d33
  Faulting instruction address: 0xc000000000246b80
  Oops: Kernel access of bad area, sig: 11 [#1]
  ....
  [c000000012d436a0] [c0000000001002d0] .kfree+0x120/0x34c (unreliable)
  [c000000012d43730] [c000000000246d60] .pci_release_selected_regions+0x3c/0x68
  [c000000012d437c0] [d000000002d54700] .icom_kref_release+0xf4/0x118 [icom]
  [c000000012d43850] [c000000000232e50] .kref_put+0x74/0x94
  [c000000012d438d0] [d000000002d56c58] .icom_remove+0x40/0xa4 [icom]
  [c000000012d43960] [c000000000249e48] .pci_device_remove+0x50/0x90
  [c000000012d439e0] [c0000000002d68d8] .__device_release_driver+0x94/0xd4
  [c000000012d43a70] [c0000000002d7104] .driver_detach+0xf8/0x12c
  [c000000012d43b00] [c0000000002d549c] .bus_remove_driver+0xbc/0x11c
  [c000000012d43b90] [c0000000002d71dc] .driver_unregister+0x60/0x80
  [c000000012d43c20] [c00000000024a07c] .pci_unregister_driver+0x44/0xe8
  [c000000012d43cb0] [d000000002d56bf4] .icom_exit+0x1c/0x40 [icom]
  [c000000012d43d30] [c000000000095fa8] .SyS_delete_module+0x214/0x2a8
  [c000000012d43e30] [c00000000000852c] syscall_exit+0x0/0x40

Signed-off-by: Breno Leitao 
Cc: stable@kernel.org
Cc: Alan Cox 
Signed-off-by: Linus Torvalds