linux-toradex.git/drivers/serial/serial_core.c, branch v2.6.34.8

serial: Fix crash if the minimum rate of the device is > 9600 baud

2010-01-20T23:03:29+00:00

In that situation if the old rate is invalid and the new rate is invalid
and the chip cannot do 9600 baud we report zero, which makes all the
drivers explode.

Instead force the rate based on min/max

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

serial-core: resume serial hardware with no_console_suspend

2010-01-20T23:03:29+00:00

Perform a tricky suspend/resume even with no_console_suspend.

With no_console_suspend, kernel skips serial port suspend/resume and the
serial hardware may remain in undefined state after resume. It actually
happens on devices that don't have BIOS that handle serial
initialization. It makes impossible to use serial console after resume.

Devices affected by this problem include:
Sharp Zaurus devices
Several PXA based ARM embedded boards

The patch does:
- Save the hardware state
- Perform buffer flush in time of its suspend call
- Tell the driver that port is suspended
- But still accept new data
- And keep console hardware in state that allows to send them

It allows to capture late console messages without breaking console
after resume.

This is just a resend of a patch discussed in these threads, as the
patch was not yet applied.

"Possible suspend/resume regression in .32-rc?" (Nov 1-5, 2009, ARM
list, later LKML)

"serial-core: resume serial hardware with no_console_suspend" (Sep
15-Oct 18, 2009, LKML & ARM lists)

Signed-off-by: Stanislav Brabec 
Tested-by: Haojian Zhuang 
Tested-by: Daniel Mack 
Signed-off-by: Greg Kroah-Hartman

serial: cascade needless conditionals

2009-12-11T23:18:04+00:00

Signed-off-by: André Goddard Rosa 
Signed-off-by: Greg Kroah-Hartman

serial: fix NULL pointer dereference

2009-12-11T23:18:04+00:00

If kzalloc() or alloc_tty_driver() fails, we call:
    put_tty_driver(normal = NULL).

Then:
    put_tty_driver -> tty_driver_kref_put -> kref_put(&NULL->kref, ...)

Signed-off-by: André Goddard Rosa 
Signed-off-by: Greg Kroah-Hartman

tty, serial: Fix race and NULL check in uart_close()

2009-10-12T17:21:33+00:00

Commit 46d57a449aa1 ("serial: use tty_port pointers in the core code")
contained two bugs that causes (rare) crashes:

 - the rename typoed one site

 - a NULL check was missed

Reported-and-tested-by: Ingo Molnar 
Cc: Greg KH 
Cc: Alan Cox 
Signed-off-by: Ingo Molnar 
Signed-off-by: Linus Torvalds

serial core: fix new kernel-doc warnings

2009-09-23T18:24:57+00:00

Fix new kernel-doc warnings in serial_core.[hc] files.

  Warning(include/linux/serial_core.h:485): No description found for parameter 'uport'
  Warning(include/linux/serial_core.h:485): Excess function parameter 'port' description in 'uart_handle_dcd_change'
  Warning(include/linux/serial_core.h:511): No description found for parameter 'uport'
  Warning(include/linux/serial_core.h:511): Excess function parameter 'port' description in 'uart_handle_cts_change'
  Warning(drivers/serial/serial_core.c:2437): No description found for parameter 'uport'
  Warning(drivers/serial/serial_core.c:2437): Excess function parameter 'port' description in 'uart_add_one_port'
  Warning(drivers/serial/serial_core.c:2509): No description found for parameter 'uport'
  Warning(drivers/serial/serial_core.c:2509): Excess function parameter 'port' description in 'uart_remove_one_port'

Signed-off-by: Randy Dunlap 
Signed-off-by: Linus Torvalds

Set proper console speed on resume if console suspend is disabled

2009-09-19T20:13:33+00:00

Commit b5b82df6, from May 2007, breaks no_console_suspend on the OLPC
XO laptop. Basically what happens is that upon returning from resume,
serial8250_resume_port() will reconfigure the port for high speed
mode and all console output will be garbled, making debug of the
resume path painful. This patch modifies uart_resume_port() to
reset the port to the state it was in before we suspended.

Original patch by Marcelo Tosatti

Second patch by Deepak then reworked by Alan to fit with the tty changes
before it got submitted. Also fixed the console path to set c_i/ospeed as
some drivers require the termios fields are valid

Signed-off-by: Deepak Saxena 
Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

serial: introduce tty krefs

2009-09-19T20:13:33+00:00

Initially just use the helper and thus krefs when we set and clear the
port values.

Signed-off-by: Alan Cox

serial: kill USF_CLOSING_* definitions

2009-09-19T20:13:32+00:00

The serial layer for some reason uses different defines for the special
case close delays and then conditionally switches to/from the normal ones
in the ioctls.

Remove this rather pointless abstraction

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

serial: move port users helper

2009-09-19T20:13:32+00:00

This little helper is now tty_port specific and useful generally so move it

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman