linux-toradex.git/drivers/spi/spi-davinci.c, branch v4.9.98

spi: davinci: fix up dma_mapping_error() incorrect patch

2018-04-08T10:13:01+00:00

commit aabb797b4c1204b2e8518538b2616e476f2bac92, which is commit
c5a2a394835f473ae23931eda5066d3771d7b2f8 upstream had an error in it.

Ben writes:
	The '!' needs to be deleted.  This appears to have been fixed upstream
	by:

	commit 8aedbf580d21121d2a032e4c8ea12d8d2d85e275
	Author: Fabien Parent 
	Date:   Thu Feb 23 19:01:56 2017 +0100

	    spi: davinci: Use SPI framework to handle DMA mapping

	which is not suitable for stable.

So I'm just fixing this up directly.

Reported-by: Ben Hutchings 
Cc: Kevin Hilman 
Cc: Mark Brown 
Cc: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

spi: davinci: use dma_mapping_error()

2017-07-05T12:40:25+00:00

[ Upstream commit c5a2a394835f473ae23931eda5066d3771d7b2f8 ]

The correct error checking for dma_map_single() is to use
dma_mapping_error().

Signed-off-by: Kevin Hilman 
Signed-off-by: Mark Brown 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

spi: davinci: Use dma_request_chan() for requesting DMA channel

2016-04-29T17:15:15+00:00

With the new dma_request_chan() the client driver does not need to look for
the DMA resource and it does not need to pass filter_fn anymore.
By switching to the new API the driver can now support deferred probing
against DMA.

Signed-off-by: Peter Ujfalusi 
Signed-off-by: Mark Brown

spi: davinci: use dev_err() for error reporting

2015-12-12T22:57:44+00:00

Use dev_err() for reporting errors rather than
dev_dbg().

Signed-off-by: Sekhar Nori 
Signed-off-by: Mark Brown

spi: davinci: fix spurious i/o error

2015-12-12T22:57:44+00:00

davinci_spi_bufs() uses wait_for_completion_interruptible()
without bothering to handle -ERESTARTSYS. Due to this,
sometime, it returns prematurely when a signal is received.
Since the return value is never checked, userspace eventually
receives a spurious -EIO.

To fix this, use un-interruptible wait_for_completion_timeout().

Signed-off-by: Sekhar Nori 
Signed-off-by: Mark Brown

Merge remote-tracking branch 'spi/topic/davinci' into spi-next

2015-11-04T11:02:02+00:00

spi: davinci: use spi->cs_gpio directly

2015-10-16T18:09:01+00:00

Use spi->cs_gpio directly to remove the following build warning:
drivers/spi/spi-davinci.c:219:6: warning: 'gpio' may be used uninitialized in this function

Signed-off-by: Luis de Bethencourt 
Suggested-by: Geert Uytterhoeven 
Signed-off-by: Mark Brown

spi: davinci: fix handling platform_get_irq result

2015-09-25T18:08:08+00:00

The function can return negative value.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107

Signed-off-by: Andrzej Hajda 
Signed-off-by: Mark Brown

spi: davinci: Choose correct pre-scaler limit based on SOC

2015-07-24T16:35:51+00:00

Currently the pre-scaler limit is incorrect. The value differs slightly
for various devices so a single value can't be used. Using the compatible
field select the correct pre-scaler limit.

Add new compatible field value for Keystone devices to support their
unique pre-scaler limit value.

Signed-off-by: Franklin S Cooper Jr 
Reviewed-by: Sekhar Nori 
Signed-off-by: Mark Brown

spi: davinci: Set prescale value based on register value

2015-07-24T16:35:48+00:00

Within davinci_spi_get_prescale() the prescale has two meanings. First one
being the calculated prescale value and then at the end translates it to the
prescale value that will be written to the SPI register.

At first glance this can be confusing especially when comparing the minimum
prescale value against what is seen in the TRM.

To simplify things make it clear that the calculated prescale value will always
be based on the value that will be written into the SPI register.

Signed-off-by: Franklin S Cooper Jr 
Signed-off-by: Mark Brown