linux-toradex.git/drivers/ssb, branch v4.20-rc3

ssb: chipcommon: fix fall-through annotation

2018-10-05T08:37:20+00:00

Replace "Fallthough" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling
-Wimplicit-fallthrough

Signed-off-by: Gustavo A. R. Silva 
Acked-by: Michael Buesch 
Signed-off-by: Kalle Valo

ssb: Remove SSB_WARN_ON, SSB_BUG_ON and SSB_DEBUG

2018-08-09T15:47:47+00:00

Use the standard WARN_ON instead.
If a small kernel is desired, WARN_ON can be disabled globally.

Also remove SSB_DEBUG. Besides WARN_ON it only adds a tiny debug check.
Include this check unconditionally.

Signed-off-by: Michael Buesch 
Signed-off-by: Kalle Valo

ssb: Remove home-grown printk wrappers

2018-08-09T15:45:50+00:00

Replace the ssb printk wrappers by standard print helpers.
Also remove SSB_SILENT. Nobody should use it anyway.

Originally submitted by Joe Perches .
Modified to add dev_... based printks.

Signed-off-by: Michael Buesch 
Tested-by: Michael Buesch 
Cc: Joe Perches 
Signed-off-by: Kalle Valo

ssb: driver_gige: use true and false for boolean values

2018-08-09T15:15:46+00:00

Return statements in functions returning bool should use true or false
instead of an integer value.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva 
Reviewed-by: Michael Buesch 
Signed-off-by: Kalle Valo

ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y

2018-05-12T08:38:13+00:00

SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported
symbols pcibios_enable_device and register_pci_controller. This code is
supposed to be compiled only with ssb builtin.

This fixes:
ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1

Reported-by: Matt Redfearn 
Signed-off-by: Rafał Miłecki 
Reviewed-by: Larry Finger 
Signed-off-by: Kalle Valo

Revert "ssb: Prevent build of PCI host features in module"

2018-05-12T08:38:13+00:00

This reverts commit 882164a4a928bcaa53280940436ca476e6b1db8e.

Above commit added "SSB = y" dependency to the wrong symbol
SSB_DRIVER_PCICORE_POSSIBLE and prevented SSB_DRIVER_PCICORE from being
selected when needed. PCI core driver for core running in clienthost
mode is important for bus initialization. It's perfectly valid scenario
to have ssb built as module and use it with buses on PCI cards.

This fixes regression that affected all *module* users with PCI cards.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1572349
Signed-off-by: Rafał Miłecki 
Signed-off-by: Kalle Valo

ssb: use put_device() if device_register fail

2018-03-13T16:48:29+00:00

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.

Signed-off-by: Arvind Yadav 
Signed-off-by: Kalle Valo

ssb: Prevent build of PCI host features in module

2018-02-28T14:38:06+00:00

Attempting to build ssb.ko with CONFIG_SSB_DRIVER_PCICORE=y results in
a build error due to use of symbols not exported from vmlinux:

ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1

To prevent this, don't allow the host mode feature to be built if
CONFIG_SSB=m

Signed-off-by: Matt Redfearn 
Signed-off-by: Kalle Valo

ssb: return boolean instead of integer in ssb_dma_translation_special_bit

2018-02-27T16:14:11+00:00

Return statements in functions returning bool should use
true/false instead of 1/0.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Kalle Valo

Merge git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git

2018-02-01T08:37:39+00:00

The last pull request didn't make it to v4.15 (I was too late) so pull it to
wireless-drivers-next.git instead so that it can go to v4.16.