linux-toradex.git/drivers/staging, branch v3.2.12

media: staging: lirc_serial: Do not assume error codes returned by request_irq()

2012-03-12T19:31:39+00:00

commit affc9a0d59ac49bd304e2137bd5e4ffdd6fdfa52 upstream.

lirc_serial_probe() must fail if request_irq() returns an error, even if
it isn't EBUSY or EINVAL,

Signed-off-by: Ben Hutchings 
Signed-off-by: Mauro Carvalho Chehab 
Signed-off-by: Jonathan Nieder 
Signed-off-by: Greg Kroah-Hartman

media: staging: lirc_serial: Fix deadlock on resume failure

2012-03-12T19:31:39+00:00

commit 1ff1d88e862948ae5bfe490248c023ff8ac2855d upstream.

A resume function cannot remove the device it is resuming!

Signed-off-by: Ben Hutchings 
Signed-off-by: Mauro Carvalho Chehab 
Signed-off-by: Jonathan Nieder 
Signed-off-by: Greg Kroah-Hartman

media: staging: lirc_serial: Free resources on failure paths of lirc_serial_probe()

2012-03-12T19:31:39+00:00

commit c8e57e1b766c2321aa76ee5e6878c69bd2313d62 upstream.

Failure to allocate the I/O region leaves the IRQ allocated.
A later failure leaves them both allocated.

Reported-by: Torsten Crass 
Signed-off-by: Ben Hutchings 
Signed-off-by: Mauro Carvalho Chehab 
Signed-off-by: Jonathan Nieder 
Signed-off-by: Greg Kroah-Hartman

media: staging: lirc_serial: Fix init/exit order

2012-03-12T19:31:39+00:00

commit 9105b8b200410383d0854bbe237ee385d7d33ba6 upstream.

Currently the module init function registers a platform_device and
only then allocates its IRQ and I/O region.  This allows allocation to
race with the device's suspend() function.  Instead, allocate
resources in the platform driver's probe() function and free them in
the remove() function.

The module exit function removes the platform device before the
character device that provides access to it.  Change it to reverse the
order of initialisation.

Signed-off-by: Ben Hutchings 
Signed-off-by: Mauro Carvalho Chehab 
Signed-off-by: Jonathan Nieder 
Signed-off-by: Greg Kroah-Hartman

zcache: fix deadlock condition

2012-02-13T19:17:04+00:00

commit 9256a4789be3dae37d00924c03546ba7958ea5a3 upstream.

I discovered this deadlock condition awhile ago working on RAMster
but it affects zcache as well.  The list spinlock must be
locked prior to the page spinlock and released after.  As
a result, the page copy must also be done while the locks are held.

Applies to 3.2.  Konrad, please push (via GregKH?)...
this is definitely a bug fix so need not be pushed during
a -rc0 window.

Signed-off-by: Dan Magenheimer 
Acked-by: Konrad Rzeszutek Wilk 
Signed-off-by: Greg Kroah-Hartman

zcache: Set SWIZ_BITS to 8 to reduce tmem bucket lock contention.

2012-02-13T19:17:04+00:00

commit e8b4553457e78bcff90f70a31212a40a8fd4f0db upstream.

SWIZ_BITS > 8 results in a much larger number of "tmem_obj"
allocations, likely one per page-placed-in-frontswap.  The
tmem_obj is not huge (roughly 100 bytes), but it is large
enough to add a not-insignificant memory overhead to zcache.

The SWIZ_BITS=8  will get roughly the same lock contention
without the space wastage.

The effect of SWIZ_BITS can be thought of as "2^SWIZ_BITS is
the number of unique oids that be generated" (This concept is
limited to frontswap's use of tmem).

Acked-by: Seth Jennings 
Signed-off-by: Konrad Rzeszutek Wilk 
Signed-off-by: Greg Kroah-Hartman

staging: r8712u: Use asynchronous firmware loading

2012-02-13T19:17:03+00:00

commit 8c213fa59199f9673d66970d6940fa093186642f upstream.

In https://bugs.archlinux.org/task/27996, failure of driver r8712u is
reported, with a timeout during module loading due to synchronous loading
of the firmware. The code now uses request_firmware_nowait().

Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

staging: r8712u: Add new Sitecom UsB ID

2012-02-13T19:17:03+00:00

commit 1793bf1deddc8ce25dc41925d5dbe64536c841b6 upstream.

Add USB ID for SITECOM WLA-1000 V1 001 WLAN

Reported-and-tested-by: Roland Gruber 
Reported-and-tested-by: Dario Lucia 
Signed-off-by: Larry Finger 
Signed-off-by: Greg Kroah-Hartman

Staging: asus_oled: fix NULL-ptr crash on unloading

2012-02-13T19:17:02+00:00

commit 3589e74595a4332ebf77b5ed006f3c6686071ecd upstream.

Asus_oled triggers the following bug on module unloading:

 usbcore: deregistering interface driver asus-oled
 BUG: unable to handle kernel NULL pointer dereference at 0000000000000038
 IP: [] sysfs_delete_link+0x30/0x66

 Call Trace:
  [] device_remove_class_symlinks+0x6b/0x70
  [] device_del+0x9f/0x1ab
  [] device_unregister+0x11/0x1e
  [] asus_oled_disconnect+0x4f/0x9e [asus_oled]
  [] usb_unbind_interface+0x54/0x103
  [] __device_release_driver+0xa2/0xeb
  [] driver_detach+0x87/0xad
  [] bus_remove_driver+0x91/0xc1
  [] driver_unregister+0x66/0x6e
  [] usb_deregister+0xbb/0xc4
  [] asus_oled_exit+0x2f/0x31 [asus_oled]
  [] sys_delete_module+0x1b8/0x21b
  [] ? do_munmap+0x2ef/0x313
  [] system_call_fastpath+0x16/0x1b

This is due to an incorrect destruction sequence in asus_oled_exit().

Fix the order, fixes the bug. Tested on an Asus G50V laptop only.

Cc: Jakub Schmidtke 
Signed-off-by: Pekka Paalanen 
Signed-off-by: Greg Kroah-Hartman

Staging: asus_oled: fix image processing

2012-02-13T19:17:02+00:00

commit 635032cb397b396241372fa0ff36ae758e658b23 upstream.

Programming an image was broken, because odev->buf_offs was not advanced
for val == 0 in append_values(). This regression was introduced in:

 commit 1ff12a4aa354bed093a0240d5e6347b1e27601bc
 Author: Kevin A. Granade 
 Date:   Sat Sep 5 01:03:39 2009 -0500

     Staging: asus_oled: Cleaned up checkpatch issues.

Fix the image processing by special-casing val == 0.

I have tested this change on an Asus G50V laptop only.

Cc: Jakub Schmidtke 
Cc: Kevin A. Granade 
Signed-off-by: Pekka Paalanen 
Signed-off-by: Greg Kroah-Hartman