linux-toradex.git/drivers/target/iscsi/iscsi_target_tpg.c, branch v4.4.53

target/iscsi: Fix double free in lio_target_tiqn_addtpg()

2017-01-12T10:22:49+00:00

commit a91918cd3ea11f91c68e08e1e8ce1b560447a80e upstream.

This iscsit_tpg_add_portal_group() function is only called from
lio_target_tiqn_addtpg().  Both functions free the "tpg" pointer on
error so it's a double free bug.  The memory is allocated in the caller
so it should be freed in the caller and not here.

Fixes: e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1")
Signed-off-by: Dan Carpenter 
Reviewed-by: David Disseldorp 
[ bvanassche: Added "Fix" at start of patch title ]
Signed-off-by: Bart Van Assche 
Signed-off-by: Greg Kroah-Hartman

target/iscsi: Replace __kernel_sockaddr_storage with sockaddr_storage

2015-08-27T06:27:25+00:00

It appears to be what the rest of the kernel does, so let's do it too.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/iscsi: Keep local_ip as the actual sockaddr

2015-08-27T06:27:16+00:00

This is a more natural format that lets us format it with the appropriate
printk specifier as needed.

This also lets us handle v4-mapped ipv6 addresses a little more nicely, by
storing the addr as an actual v4 sockaddr in conn->local_sockaddr.

Finally, we no longer need to maintain variables for port, since this is
contained in sockaddr. Remove iscsi_np.np_port and iscsi_conn.local_port.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/iscsi: Fix np_ip bracket issue by removing np_ip

2015-08-27T06:27:09+00:00

Revert commit 1997e6259, which causes double brackets on ipv6
inaddr_any addresses.

Since we have np_sockaddr, if we need a textual representation we can
use "%pISc".

Change iscsit_add_network_portal() and iscsit_add_np() signatures to remove
*ip_str parameter.

Fix and extend some comments earlier in the function.

Tested to work for :: and ::1 via iscsiadm, previously :: failed, see
https://bugzilla.redhat.com/show_bug.cgi?id=1249107 .

CC: stable@vger.kernel.org
Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

iscsi-target: Add tpg_enabled_sendtargets for disabled discovery

2015-08-03T04:59:59+00:00

This patch adds a new tpg_enabled_sendtargets configfs attribute
to allow in-band sendtargets discovery information to include
target-portal-groups (TPGs) in !TPG_STATE_ACTIVE state.

This functionality is useful for clustered iSCSI targets, where
TPGTs handled on remote cluster nodes should be advertised in
the SendTargets response.

By default, this new attribute retains the default behaviour of
existing code which to ignore portal-groups in !TPG_STATE_ACTIVE
state.

Signed-off-by: David Disseldorp 
Signed-off-by: Nicholas Bellinger

target: Drop unnecessary core_tpg_register TFO parameter

2015-06-16T06:23:22+00:00

This patch drops unnecessary target_core_fabric_ops parameter usage
for core_tpg_register() during fabric driver TFO->fabric_make_tpg()
se_portal_group creation callback execution.

Instead, use the existing se_wwn->wwn_tf->tf_ops pointer to ensure
fabric driver is really using the same TFO provided at module_init
time.

Also go ahead and drop the forward TFO declarations tree-wide, and
handling the special case for iscsi-target discovery TPG.

Cc: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Nicholas Bellinger

target: Convert se_portal_group->tpg_lun_list[] to RCU hlist

2015-06-01T07:24:33+00:00

This patch converts the fixed size se_portal_group->tpg_lun_list[]
to use modern RCU with hlist_head in order to support an arbitary
number of se_lun ports per target endpoint.

It includes dropping core_tpg_alloc_lun() from core_dev_add_lun(),
and calling it directly from target_fabric_make_lun() to allocate
a new se_lun.  And add a new target_fabric_port_release() configfs
item callback to invoke kfree_rcu() to release memory during
se_lun->lun_group shutdown.

Also now that se_node_acl->lun_entry_hlist is using RCU, convert
existing tpg_lun_lock to struct mutex so core_tpg_add_node_to_devs()
can perform RCU updater logic without releasing ->tpg_lun_mutex.

Also, drop core_tpg_clear_object_luns() and it's single consumer
in iscsi-target, which is duplicating TPG LUN shutdown logic and
is current code results in a NOP.

Finally, sbp-target and xen-scsiback fabric driver conversions are
included, which are required due to the non-standard way they use
->tpg_lun_hlist.

Reviewed-by: Hannes Reinecke 
Cc: Christoph Hellwig 
Cc: Sagi Grimberg 
Cc: Paul E. McKenney 
Cc: Chris Boot 
Signed-off-by: Nicholas Bellinger

target: target_core_configfs.h is not needed in fabric drivers

2015-05-31T05:42:39+00:00

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: change core_tpg_register prototype

2015-05-31T05:42:27+00:00

Remove the unneeded fabric_ptr argument, and change the type argument
to pass in a SPC protocol identifier.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: Drop signal_pending checks after interruptible lock acquire

2015-05-19T22:18:20+00:00

Once upon a time, iscsit_get_tpg() was using an un-interruptible
lock.  The signal_pending() usage was a check to allow userspace
to break out of the operation with SIGINT.

AFAICT, there's no reason why this is necessary anymore, and as
reported by Alexey can be potentially dangerous.  Also, go ahead
and drop the other two problematic cases within iscsit_access_np()
and sbc_compare_and_write() as well.

Found by Linux Driver Verification project (linuxtesting.org).

Reported-by: Alexey Khoroshilov 
Signed-off-by: Nicholas Bellinger