linux-toradex.git/drivers/target/iscsi, branch v3.6

target: Check idr_get_new return value in iscsi_login_zero_tsih_s1

2012-08-27T06:27:08+00:00

This patch updates iscsi_login_zero_tsih_s1() usage for generating
iscsi_session->session_index to properly check the return value from
idr_get_new(), and reject the iSCSI login attempt with exception
status ISCSI_LOGIN_STATUS_NO_RESOURCES in the event of a failure.

Signed-off-by: Benjamin Wang 
Signed-off-by: Nicholas Bellinger

iscsi-target: Drop bogus struct file usage for iSCSI/SCTP

2012-07-21T09:44:13+00:00

From Al Viro:

	BTW, speaking of struct file treatment related to sockets -
        there's this piece of code in iscsi:
        /*
         * The SCTP stack needs struct socket->file.
         */
        if ((np->np_network_transport == ISCSI_SCTP_TCP) ||
            (np->np_network_transport == ISCSI_SCTP_UDP)) {
                if (!new_sock->file) {
                        new_sock->file = kzalloc(
                                        sizeof(struct file), GFP_KERNEL);

For one thing, as far as I can see it'not true - sctp does *not* depend on
socket->file being non-NULL; it does, in one place, check socket->file->f_flags
for O_NONBLOCK, but there it treats NULL socket->file as "flag not set".
Which is the case here anyway - the fake struct file created in
__iscsi_target_login_thread() (and in iscsi_target_setup_login_socket(), with
the same excuse) do *not* get that flag set.

Moreover, it's a bloody serious violation of a bunch of asserts in VFS;
all struct file instances should come from filp_cachep, via get_empty_filp()
(or alloc_file(), which is a wrapper for it).  FWIW, I'm very tempted to
do this and be done with the entire mess:

Signed-off-by: Al Viro 
Cc: Andy Grover 
Cc: Hannes Reinecke 
Cc: Christoph Hellwig 
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger

target: Misc retval cleanups

2012-07-17T00:35:23+00:00

Bubble-up retval from iscsi_update_param_value() and
iscsit_ta_authentication().

Other very small retval cleanups.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

target: Remove unneeded double parentheses

2012-07-17T00:35:22+00:00

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger

iscsit: use target_execute_cmd for WRITEs

2012-07-17T00:35:18+00:00

All three callers of transport_generic_handle_data are from user context
and can use target_execute_cmd directly to handle the backend I/O submission
of WRITE I/O.

Signed-off-by: Christoph Hellwig 
Cc: Andy Grover 
Signed-off-by: Nicholas Bellinger

target/iscsi: Remove dead code in lio_get_tpg_from_tpg_item()

2012-07-17T00:29:11+00:00

It's got no callers...

Signed-off-by: Roland Dreier 
Signed-off-by: Nicholas Bellinger

target: move ref_cmd from the generic se_tmr_req into iscsi code

2012-07-17T00:29:11+00:00

Also remove the unused ref_task_lun field in struct se_tmr_req.

(nab: Add missing TASK_REASSIGN ref_lun vs. ref_cmd orig_fe_lun checks
      in iscsit_tmr_task_reassign)

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

iscsi-target: Fix iov_count calculation bug in iscsit_allocate_iovecs

2012-05-21T00:25:24+00:00

This patch fixes a bug in iscsit_allocate_iovecs() where iov_count was
incorrectly calculated using min(1UL, data_length / PAGE_SIZE) instead of
max(1UL, data_length / PAGE_SIZE), that ends up triggering an OOPs for
large block I/O when the SGL <-> iovec mapping exceeds the bogus iov_count
allocation size.

This is a regression introduced during the iscsi-target conversion back
to using core memory allocation here:

commit bfb79eac2026b411df9e253a9c350039b4b04bb7
Author: Andy Grover 
Date:   Tue Apr 3 15:51:29 2012 -0700

    target/iscsi: Go back to core allocating data buffer for cmd

Cc: Andy Grover 
Signed-off-by: Nicholas Bellinger

iscsi-target: remove dead code in iscsi_check_valuelist_for_support

2012-05-17T19:04:53+00:00

Neither "acceptor_values" nor "proposer_values" can be NULL here when
scanning the value lists for incoming iSCSI login parameters such as
HeaderDigest=CRC32C,None.

Smatch complains because we are not allowed to pass NULL pointers to
strchr().  Also I removed a second later check for "!acceptor_values"
because it gets checked on the next line in the do while condition.

Signed-off-by: Dan Carpenter 
Signed-off-by: Nicholas Bellinger

target/iscsi: cleanup some allocation style issues

2012-05-06T22:02:33+00:00

We can use kcalloc() here instead of kzalloc().  It's better style and
it has overflow checking built in.

Also -ENOMEM is the correct error code for allocation errors.  -1 means
-EPERM.  None of the callers preserve the error codes so it doesn't
matter except as a cleanup.

Signed-off-by: Dan Carpenter 
Signed-off-by: Nicholas Bellinger