linux-toradex.git/drivers/target/loopback/tcm_loop.c, branch v4.18-rc4

target/tcm_loop: Use blk_queue_flag_set()

2018-03-08T21:13:48+00:00

Use blk_queue_flag_set() instead of open-coding this function.

Cc: Nicholas A. Bellinger 
Cc: Christoph Hellwig 
Cc: Hannes Reinecke 
Cc: Ming Lei 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Bart Van Assche 
Signed-off-by: Jens Axboe

target: tcm_loop: Use seq_puts() in tcm_loop_show_info()

2018-01-12T23:07:26+00:00

The script "checkpatch.pl" pointed information out like the following.

WARNING: Prefer seq_puts to seq_printf

Thus fix the affected source code place.

Signed-off-by: Markus Elfring 
Signed-off-by: Nicholas Bellinger

target: tcm_loop: Delete an unnecessary return statement in tcm_loop_submission_work()

2018-01-12T23:07:25+00:00

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected function.

Signed-off-by: Markus Elfring 
Signed-off-by: Nicholas Bellinger

target: tcm_loop: Delete two unnecessary variable initialisations in tcm_loop_issue_tmr()

2018-01-12T23:07:24+00:00

The variables "se_cmd" and "tl_cmd" will eventually be set to appropriate
pointers a bit later.
Thus omit the explicit initialisation at the beginning.

Signed-off-by: Markus Elfring 
Signed-off-by: Nicholas Bellinger

target: tcm_loop: Combine substrings for 26 messages

2018-01-12T23:07:23+00:00

The script "checkpatch.pl" pointed information out like the following.

WARNING: quoted string split across lines

Thus fix the affected source code places.

Signed-off-by: Markus Elfring 
Signed-off-by: Nicholas Bellinger

target: tcm_loop: Improve a size determination in two functions

2018-01-12T23:07:23+00:00

Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Nicholas Bellinger

target: tcm_loop: Delete an error message for a failed memory allocation in four functions

2018-01-12T23:07:22+00:00

Omit an extra message for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Nicholas Bellinger

target/tcm_loop: Make TMF processing slightly faster

2017-07-07T06:11:25+00:00

Target drivers must guarantee that struct se_cmd and struct se_tmr_req
exist as long as target_tmr_work() is in progress. This is why the
tcm_loop driver today passes 1 as second argument to
transport_generic_free_cmd() from inside the TMF code. Instead of
making the TMF code wait, make the TMF code obtain two references
(SCF_ACK_KREF) and drop one reference from inside the .check_stop_free()
callback.

Signed-off-by: Bart Van Assche 
Cc: Christoph Hellwig 
Cc: Hannes Reinecke 
Cc: David Disseldorp 
Signed-off-by: Nicholas Bellinger

target/tcm_loop: Use target_submit_tmr() instead of open-coding this function

2017-07-07T06:11:25+00:00

Use target_submit_tmr() instead of open-coding this function. The
only functional change is that TMFs are now added to sess_cmd_list,
something the current code does not do. This behavior change is a
bug fix because it makes LUN RESETs wait for other TMFs that are in
progress for the same LUN.

Signed-off-by: Bart Van Assche 
Cc: Christoph Hellwig 
Cc: Hannes Reinecke 
Cc: David Disseldorp 
Signed-off-by: Nicholas Bellinger

target/tcm_loop: Replace a waitqueue and a counter by a completion

2017-07-07T06:11:24+00:00

This patch simplifies the implementation of the tcm_loop driver
but does not change its behavior.

Signed-off-by: Bart Van Assche 
Cc: Christoph Hellwig 
Cc: Hannes Reinecke 
Cc: David Disseldorp 
Signed-off-by: Nicholas Bellinger