linux-toradex.git/drivers/target/loopback/tcm_loop.c, branch v4.19-rc8

scsi: target: loop, usb, vhost, xen: use target_remove_session

2018-08-02T19:29:31+00:00

This converts drivers that were only calling transport_deregister_session
to use target_remove_session. The calling of
transport_deregister_session_configfs via target_remove_session for these
types of drivers is ok, because they were not exporting info from fields
like sess_acl_list, sess->se_tpg and sess->fabric_sess_ptr from configfs
accessible functions, so they will see no difference.

Signed-off-by: Mike Christie 
Reviewed-by: Bart Van Assche 
Reviewed-by: Christoph Hellwig 
Cc: Felipe Balbi 
Cc: Sebastian Andrzej Siewior 
Cc: Andrzej Pietrasiewicz 
Cc: Michael S. Tsirkin 
Cc: Juergen Gross 
Signed-off-by: Martin K. Petersen

scsi: target: rename target_alloc_session

2018-08-02T19:29:31+00:00

Rename target_alloc_session to target_setup_session to avoid confusion with
the other transport session allocation function that only allocates the
session and because the target_alloc_session does so much more. It
allocates the session, sets up the nacl and registers the session.

The next patch will then add a remove function to match the setup in this
one, so it should make sense for all drivers, except iscsi, to just call
those 2 functions to setup and remove a session.

iscsi will continue to be the odd driver.

Signed-off-by: Mike Christie 
Reviewed-by: Bart Van Assche 
Reviewed-by: Christoph Hellwig 
Cc: Chris Boot 
Cc: Bryant G. Ly 
Cc: Michael Cyr 
Cc: 
Cc: Johannes Thumshirn 
Cc: Felipe Balbi 
Cc: Sebastian Andrzej Siewior 
Cc: Andrzej Pietrasiewicz 
Cc: Michael S. Tsirkin 
Cc: Juergen Gross 
Signed-off-by: Martin K. Petersen

scsi: target/tcm_loop: Avoid that static checkers warn about dead code

2018-07-02T20:44:32+00:00

The code under the "release:" label can only be reached after se_cmd has
been set to a non-NULL value. Hence remove the if (se_cmd) test.  Keep the
else-part since calling transport_generic_free_cmd() is not necessary for a
command that has not been submitted to the core.

Reported-by: Dan Carpenter 
Fixes: 4d3895d5ea43 ("target/tcm_loop: Merge struct tcm_loop_cmd and struct tcm_loop_tmr")
Signed-off-by: Bart Van Assche 
Reviewed-by: Mike Christie 
Cc: Dan Carpenter 
Cc: Hannes Reinecke 
Cc: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: target: Remove second argument from fabric_make_tpg()

2018-07-02T20:44:32+00:00

Since most target drivers do not use the second fabric_make_tpg() argument
("group") and since it is trivial to derive the group pointer from the wwn
pointer, do not pass the group pointer to fabric_make_tpg().

Signed-off-by: Bart Van Assche 
Reviewed-by: Mike Christie 
Cc: Felipe Balbi 
Cc: Hannes Reinecke 
Cc: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

target/tcm_loop: Use blk_queue_flag_set()

2018-03-08T21:13:48+00:00

Use blk_queue_flag_set() instead of open-coding this function.

Cc: Nicholas A. Bellinger 
Cc: Christoph Hellwig 
Cc: Hannes Reinecke 
Cc: Ming Lei 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Bart Van Assche 
Signed-off-by: Jens Axboe

target: tcm_loop: Use seq_puts() in tcm_loop_show_info()

2018-01-12T23:07:26+00:00

The script "checkpatch.pl" pointed information out like the following.

WARNING: Prefer seq_puts to seq_printf

Thus fix the affected source code place.

Signed-off-by: Markus Elfring 
Signed-off-by: Nicholas Bellinger

target: tcm_loop: Delete an unnecessary return statement in tcm_loop_submission_work()

2018-01-12T23:07:25+00:00

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected function.

Signed-off-by: Markus Elfring 
Signed-off-by: Nicholas Bellinger

target: tcm_loop: Delete two unnecessary variable initialisations in tcm_loop_issue_tmr()

2018-01-12T23:07:24+00:00

The variables "se_cmd" and "tl_cmd" will eventually be set to appropriate
pointers a bit later.
Thus omit the explicit initialisation at the beginning.

Signed-off-by: Markus Elfring 
Signed-off-by: Nicholas Bellinger

target: tcm_loop: Combine substrings for 26 messages

2018-01-12T23:07:23+00:00

The script "checkpatch.pl" pointed information out like the following.

WARNING: quoted string split across lines

Thus fix the affected source code places.

Signed-off-by: Markus Elfring 
Signed-off-by: Nicholas Bellinger

target: tcm_loop: Improve a size determination in two functions

2018-01-12T23:07:23+00:00

Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Nicholas Bellinger