linux-toradex.git/drivers/target/target_core_pscsi.c, branch v3.10.43

target/pscsi: fix return value check

2013-11-13T03:05:32+00:00

commit 58932e96e438cd78f75e765d7b87ef39d3533d15 upstream.

In case of error, the function scsi_host_lookup() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: Wei Yongjun 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

target/pscsi: Reject cross page boundary case in pscsi_map_sg

2013-03-20T00:31:14+00:00

We can only have one page of data in each sg element, so we can not
cross a page boundary. Fail this case.

The 'while (len > 0 && data_len > 0) {}' loop is not necessary. The loop
can only be executed once.

Signed-off-by: Asias He 
Signed-off-by: Nicholas Bellinger

target/pscsi: Rename sg_num to nr_vecs in pscsi_get_bio()

2013-02-28T03:24:20+00:00

It is actually a vector not a sg, so nr_vecs is better than sg_num.

Signed-off-by: Asias He 
Signed-off-by: Nicholas Bellinger

target/pscsi: Fix page increment

2013-02-28T03:20:21+00:00

The page++ is wrong. It makes bio_add_pc_page() pointing to a wrong page
address if the 'while (len > 0 && data_len > 0) { ... }' loop is
executed more than one once.

Signed-off-by: Asias He 
Cc: 
Signed-off-by: Nicholas Bellinger

target/pscsi: Drop unnecessary NULL assignment to bio->bi_next

2013-02-28T03:15:58+00:00

Signed-off-by: Asias He 
Signed-off-by: Nicholas Bellinger

target: Add __exit annotation for module_exit functions

2013-02-28T03:12:10+00:00

Inclues sbp_exit, fileio_module_exit, iblock_module_exit and
pscsi_module_exit.

Note: rd_module_exit() can not be annotated by __exit, becasue it is
called by target_core_init_configfs() which is annotated by __init.

Signed-off-by: Asias He 
Signed-off-by: Nicholas Bellinger

target: Update copyright information to 2012

2012-11-28T06:47:02+00:00

v2: Use correct target_core_stat.c 2006 copyright year
v3: Drop extra unnessary legal verbage from header (hch)

Cc: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

target: pass sense_reason as a return value

2012-11-07T04:55:46+00:00

Pass the sense reason as an explicit return value from the I/O submission
path instead of storing it in struct se_cmd and using negative return
values.  This cleans up a lot of the code pathes, and with the sparse
annotations for the new sense_reason_t type allows for much better
error checking.

(nab: Convert spc_emulate_modesense + spc_emulate_modeselect to use
      sense_reason_t with Roland's MODE SELECT changes)

Signed-off-by: Christoph Hellwig 
Cc: Roland Dreier 
Signed-off-by: Nicholas Bellinger

target: remove ->get_device_rev

2012-11-07T04:55:45+00:00

Now that the reservations and ALUA code have been cleaned up there is no need
for the get_device_rev method, as we only need the standards revision in the
inquiry data, where we can hardcode it.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger

pscsi: fix REPORT LUNS handling

2012-11-07T04:55:45+00:00

We need to assign spc_emulate_report_luns to the execute_cmd callback
and not execute it directly.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Nicholas Bellinger