linux-toradex.git/drivers/target/target_core_pscsi.c, branch v3.12.51

target/pscsi: Don't leak scsi_host if hba is VIRTUAL_HOST

2015-06-03T09:33:09+00:00

commit 5a7125c64def3b21f8147eca8b54949a60963942 upstream.

See https://bugzilla.redhat.com/show_bug.cgi?id=1025672

We need to put() the reference to the scsi host that we got in
pscsi_configure_device(). In VIRTUAL_HOST mode it is associated with
the dev_virt, not the hba_virt.

Signed-off-by: Andy Grover 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Jiri Slaby

target/pscsi: Fix NULL pointer dereference in get_device_type

2015-04-09T11:14:21+00:00

commit 215a8fe4198f607f34ecdbc9969dae783d8b5a61 upstream.

This patch fixes a NULL pointer dereference OOPs with pSCSI backends
within target_core_stat.c code.  The bug is caused by a configfs attr
read if no pscsi_dev_virt->pdv_sd has been configured.

Reported-by: Olaf Hering 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: Jiri Slaby

target/pscsi: fix return value check

2013-10-25T17:42:09+00:00

In case of error, the function scsi_host_lookup() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: Wei Yongjun 
Cc: 
Signed-off-by: Nicholas Bellinger

target: Update copyright ownership/year information to 2013

2013-09-11T03:23:36+00:00

Update copyright ownership/year information for target-core,
loopback, iscsi-target, tcm_qla2xx, vhost and iser-target.

Signed-off-by: Nicholas Bellinger

target/pscsi: remove an unneeded check

2013-09-09T21:29:23+00:00

blk_get_request() just returns NULL on error, it doesn't return an
ERR_PTR.

Signed-off-by: Dan Carpenter 
Signed-off-by: Nicholas Bellinger

target/pscsi: Reject cross page boundary case in pscsi_map_sg

2013-03-20T00:31:14+00:00

We can only have one page of data in each sg element, so we can not
cross a page boundary. Fail this case.

The 'while (len > 0 && data_len > 0) {}' loop is not necessary. The loop
can only be executed once.

Signed-off-by: Asias He 
Signed-off-by: Nicholas Bellinger

target/pscsi: Rename sg_num to nr_vecs in pscsi_get_bio()

2013-02-28T03:24:20+00:00

It is actually a vector not a sg, so nr_vecs is better than sg_num.

Signed-off-by: Asias He 
Signed-off-by: Nicholas Bellinger

target/pscsi: Fix page increment

2013-02-28T03:20:21+00:00

The page++ is wrong. It makes bio_add_pc_page() pointing to a wrong page
address if the 'while (len > 0 && data_len > 0) { ... }' loop is
executed more than one once.

Signed-off-by: Asias He 
Cc: 
Signed-off-by: Nicholas Bellinger

target/pscsi: Drop unnecessary NULL assignment to bio->bi_next

2013-02-28T03:15:58+00:00

Signed-off-by: Asias He 
Signed-off-by: Nicholas Bellinger

target: Add __exit annotation for module_exit functions

2013-02-28T03:12:10+00:00

Inclues sbp_exit, fileio_module_exit, iblock_module_exit and
pscsi_module_exit.

Note: rd_module_exit() can not be annotated by __exit, becasue it is
called by target_core_init_configfs() which is annotated by __init.

Signed-off-by: Asias He 
Signed-off-by: Nicholas Bellinger