linux-toradex.git/drivers/target/target_core_tpg.c, branch v3.4.87

target: Fix lookup of dynamic NodeACLs during cached demo-mode operation

2013-03-03T22:06:39+00:00

commit fcf29481fb8e106daad6688f2e898226ee928992 upstream.

This patch fixes a bug in core_tpg_check_initiator_node_acl() ->
core_tpg_get_initiator_node_acl() where a dynamically created
se_node_acl generated during session login would be skipped during
subsequent lookup due to the '!acl->dynamic_node_acl' check, causing
a new se_node_acl to be created with a duplicate ->initiatorname.

This would occur when a fabric endpoint was configured with
TFO->tpg_check_demo_mode()=1 + TPF->tpg_check_demo_mode_cache()=1
preventing the release of an existing se_node_acl during se_session
shutdown.

Also, drop the unnecessary usage of core_tpg_get_initiator_node_acl()
within core_dev_init_initiator_node_lun_acl() that originally
required the extra '!acl->dynamic_node_acl' check, and just pass
the configfs provided se_node_acl pointer instead.

Signed-off-by: Nicholas Bellinger 
Signed-off-by: Greg Kroah-Hartman

target: Add link_magic for fabric allow_link destination target_items

2013-01-21T19:45:24+00:00

commit 0ff8754981261a80f4b77db2536dfea92c2d4539 upstream.

This patch adds [dev,lun]_link_magic value assignment + checks within generic
target_fabric_port_link() and target_fabric_mappedlun_link() code to ensure
destination config_item *target_item sent from configfs_symlink() ->
config_item_operations->allow_link() is the underlying se_device->dev_group
and se_lun->lun_group that we expect to symlink.

Reported-by: Sebastian Andrzej Siewior 
Cc: Sebastian Andrzej Siewior 
Signed-off-by: Nicholas Bellinger 
Signed-off-by: CAI Qian 
Signed-off-by: Greg Kroah-Hartman

target: Drop incorrect se_lun_acl release for dynamic -> explict ACL conversion

2012-05-11T21:55:19+00:00

This patch removes some potentially problematic legacy code within
core_clear_initiator_node_from_tpg() that was originally intended to
release left over se_lun_acl setup during dynamic NodeACL+MappedLUN
generate when running with TPG demo-mode operation.

Since we now only ever expect to allocate and release se_lun_acl from
within target_core_fabric_configfs.c:target_fabric_make_mappedlun() and
target_fabric_drop_mappedlun() context respectively, this code for
demo-mode release is incorrect and needs to be removed.

Cc: Christoph Hellwig 
Cc: Andy Grover 
Cc: 
Signed-off-by: Nicholas Bellinger

target: remove obvious warnings

2012-03-16T02:16:09+00:00

Get rid of a bunch of write-only variables.  In a number of cases I
suspect actual bugs to be present, so I left all of those for a second
look.

(nab: fix lio-core patch fuzz)

Signed-off-by: Joern Engel 
Signed-off-by: Nicholas Bellinger

target: Use array_zalloc for device_list

2012-03-16T02:15:51+00:00

Turns an order-8 allocation into slab-sized ones, thereby preventing
allocation failures with memory fragmentation.

This likely saves memory as well, as the slab allocator can pack objects
more tightly than the buddy allocator.

(nab: Fix lio-core patch fuzz)

Signed-off-by: Joern Engel 
Signed-off-by: Nicholas Bellinger

target: Use array_zalloc for tpg_lun_list

2012-03-16T02:15:38+00:00

Turns an order-10 allocation into slab-sized ones, thereby preventing
allocation failures with memory fragmentation.

This likely saves memory as well, as the slab allocator can pack objects
more tightly than the buddy allocator.

Signed-off-by: Joern Engel 
Signed-off-by: Nicholas Bellinger

target: Convert se_node_acl->acl_group removal to use ->acl_kref

2012-03-10T22:42:19+00:00

This patch converts core_tpg_del_initiator_node_acl() shutdown from configfs
context to use se_node_acl->acl_kref and ->acl_free_comp in order to wait for
outstanding fabric callbacks to complete via transport_deregister_session()
callbacks before waking ->acl_free_comp from the last ->acl_kref put.

It also changes core_tpg_del_initiator_node_acl() to setup a local sess_list
with target_get_session() + acl->acl_stop = 1 for active sessions that will
be shutdown, and changes transport_deregister_session_configfs() to check
for ->acl_stop usage.

Cc: Roland Dreier 
Cc: Christoph Hellwig 
Cc: Joern Engel 
Cc: Andy Grover 
Signed-off-by: Nicholas Bellinger

target: Add se_node_acl->acl_kref for ->acl_free_comp usage

2012-03-10T22:42:09+00:00

This patch adds se_node_acl->acl_kref for use with ->acl_free_comp
during explict se_node_acl release.  It adds kref_init() during
se_node_acl setup, kref_get() during __transport_register_session()
-> target_put_nacl() with existing transport_deregister_session()
fabric callback usage.

It also moves transport_free_session() to release *se_sess memory
after target_put_nacl() execution in transport_deregister_session()

Cc: Roland Dreier 
Cc: Christoph Hellwig 
Cc: Joern Engel 
Cc: Andy Grover 
Signed-off-by: Nicholas Bellinger

target: Add se_node_acl->acl_free_comp for NodeACL release path

2012-03-10T22:41:59+00:00

Add se_node_acl->acl_free_comp for NodeACL release path to wait for outstanding
fabric session shutdown to complete in transport_deregister_session() before
finishing NodeACL release from configfs process context.

Also make transport_deregister_session() clear the comp_nacl bit
to skip se_node_acl->acl_free_comp completion for dynamically generated
NodeACL during fabric session shutdown.

Cc: Roland Dreier 
Cc: Christoph Hellwig 
Cc: Joern Engel 
Cc: Andy Grover 
Signed-off-by: Nicholas Bellinger

target: Convert session_lock to irqsave

2012-03-10T21:59:03+00:00

This patch converts the remaining struct se_portal_group->session_lock
usage to use irqsave+irqrestore to address the following warnings for
hardware target mode interrupt context usage.  This change generate
other warnings for current iscsi-target mode still using ->session_lock
with spin_lock_bh, which will need to be converted in a seperate patch.

[  492.480728] [ INFO: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected ]
[  492.488194] 3.0.0+ #23
[  492.490820] ------------------------------------------------------
[  492.497704] sh/7162 [HC0[0]:SC0[2]:HE0:SE0] is trying to acquire:
[  492.504493] (&(&se_tpg->session_lock)->rlock){+.....}, at: [] transport_deregister_session+0x2d/0x163 [target_core_mod]
  492.518390]
[  492.518390] and this task is already holding:
[  492.524897] (&(&ha->hardware_lock)->rlock){-.-...}, at: [] qla_tgt_stop_phase1+0x5e/0x27e [qla2xxx]
[  492.536856] which would create a new lock dependency:
[  492.542481] (&(&ha->hardware_lock)->rlock){-.-...} -> (&(&se_tpg->session_lock)->rlock){+.....}
[  492.552321]
[  492.552321] but this new dependency connects a HARDIRQ-irq-safe lock:
[  492.561149] (&(&ha->hardware_lock)->rlock){-.-...}
[  492.566400] ... which became HARDIRQ-irq-safe at:
[  492.571841]   [] __lock_acquire+0x68f/0x921
[  492.578247]   [] lock_acquire+0xe0/0x10d
[  492.584367]   [] _raw_spin_lock_irqsave+0x44/0x56
[  492.591358]   [] qla24xx_msix_default+0x5c/0x2aa [qla2xxx]
[  492.599227]   [] handle_irq_event_percpu+0x5a/0x197
[  492.606413]   [] handle_irq_event+0x3c/0x5c
[  492.612822]   [] handle_edge_irq+0xcc/0xf1
[  492.619138]   [] handle_irq+0x83/0x8e
[  492.624971]   [] do_IRQ+0x48/0xaf
[  492.630413]   [] ret_from_intr+0x0/0x1a
[  492.636437]   [] cpu_idle+0x5b/0x8d
[  492.642073]   [] rest_init+0xad/0xb4
[  492.647809]   [] start_kernel+0x366/0x371
[  492.654030]   [] x86_64_start_reservations+0xb8/0xbc
[  492.661311]   [] x86_64_start_kernel+0x101/0x110
[  492.668204]
[  492.668205] to a HARDIRQ-irq-unsafe lock:
[  492.674324] (&(&se_tpg->session_lock)->rlock){+.....}
[  492.679862] ... which became HARDIRQ-irq-unsafe at:
[  492.685497] ...  [] __lock_acquire+0x709/0x921
[  492.692209]   [] lock_acquire+0xe0/0x10d
[  492.698330]   [] _raw_spin_lock_bh+0x31/0x40
[  492.704836]   [] core_tpg_del_initiator_node_acl+0x89/0x336 [target_core_mod]
[  492.714546]   [] tcm_qla2xxx_drop_nodeacl+0x20/0x2d [tcm_qla2xxx]
[  492.723087]   [] target_fabric_nacl_base_release+0x22/0x24 [target_core_mod]
[  492.732698]   [] config_item_release+0x7d/0xa3 [configfs]
[  492.740465]   [] kref_put+0x43/0x4d
[  492.746101]   [] config_item_put+0x19/0x1b [configfs]
[  492.753481]   [] configfs_rmdir+0x1eb/0x258 [configfs]
[  492.760957]   [] vfs_rmdir+0x79/0xd0
[  492.766690]   [] do_rmdir+0xc2/0x111
[  492.772423]   [] sys_rmdir+0x11/0x13
[  492.778156]   [] system_call_fastpath+0x16/0x1b
[  492.784953]

Signed-off-by: Nicholas Bellinger